Re: [Buildroot] [PATCH v2 1/5] package: python-pymupdf: add missing python-zlib dependency

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Fri,  7 Jun 2024 18:32:02 +0200
Raphaël Mélotte via buildroot <buildroot@buildroot.org> wrote:

> It turns out that python-pymupdf doesn't require zlib directly, but it
> does require the zlib python module.
> 
> This fixes the following runtime error:
> 
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "/usr/lib/python3.11/site-packages/fitz/__init__.py", line 22, in <module>
>   File "/usr/lib/python3.11/site-packages/fitz/fitz.py", line 3402, in <module>
>   File "/usr/lib/python3.11/gzip.py", line 9, in <module>
> ModuleNotFoundError: No module named 'zlib'
> 
> Signed-off-by: Raphaël Mélotte <raphael.melotte@mind.be>

You had forgotten to drop the "zlib" dependency in MUPDF_DEPENDENCIES,
so I dropped it as well. And applied your patch!

And in fact this lead me to look more into mupdf, and I was curious to
see why it depended on X11. Except it does not: it is a purely optional
dependency. And I found other things that were not correct/useful
anymore in the package so I did a few preparation commits:

https://gitlab.com/buildroot.org/buildroot/-/commit/f7deaa1330baad303afb76a7711faeeb1ddfee5d
https://gitlab.com/buildroot.org/buildroot/-/commit/90f0a484671098f9a94ce66b8f8af94e106ae106
https://gitlab.com/buildroot.org/buildroot/-/commit/2c0d7b72c0993a55c8dcb7b38d85792e1bf6e8bc

and ultimately, I dropped the X.org dependency also on python-pymupdf:

https://gitlab.com/buildroot.org/buildroot/-/commit/edfa6f29785e618b75739b702fc863ee2410908d

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot