From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Raphaël Mélotte via buildroot" <buildroot@buildroot.org>
Cc: "Raphaël Mélotte" <raphael.melotte@mind.be>
Subject: Re: [Buildroot] [PATCH v2 3/5] package/mupdf: fix building shared libraries
Date: Sat, 13 Jul 2024 22:36:15 +0200 [thread overview]
Message-ID: <20240713223615.28cd0fab@windsurf> (raw)
In-Reply-To: <20240607163208.1445715-3-raphael.melotte@mind.be>
On Fri, 7 Jun 2024 18:32:04 +0200
Raphaël Mélotte via buildroot <buildroot@buildroot.org> wrote:
> +ifeq ($(BR2_STATIC_LIBS),y)
> +MUPDF_MAKE_OPTS += shared=no
> +else
> +MUPDF_MAKE_OPTS += shared=yes
> +endif
This allowed to also drop the manual addition of -fPIC, because it's
done automatically by the package Makefile when shared=yes.
See https://gitlab.com/buildroot.org/buildroot/-/commit/401162d4a947184654d8202392425a625d000172
Applied with this change. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-13 20:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 21:13 [Buildroot] [PATCH 0/5] package/python-pymupdf: bump to version 1.23.22 Raphaël Mélotte via buildroot
2024-02-16 21:13 ` [Buildroot] [PATCH 1/5] package: python-pymupdf: add missing python-zlib dependency Raphaël Mélotte via buildroot
2024-06-07 16:32 ` [Buildroot] [PATCH v2 " Raphaël Mélotte via buildroot
2024-06-07 16:32 ` [Buildroot] [PATCH v2 2/5] support/testing: add new test for python-pymupdf Raphaël Mélotte via buildroot
2024-07-13 20:35 ` Thomas Petazzoni via buildroot
2024-08-12 9:51 ` Peter Korsgaard
2024-06-07 16:32 ` [Buildroot] [PATCH v2 3/5] package/mupdf: fix building shared libraries Raphaël Mélotte via buildroot
2024-07-13 20:36 ` Thomas Petazzoni via buildroot [this message]
2024-08-12 9:14 ` Peter Korsgaard
2024-06-07 16:32 ` [Buildroot] [PATCH v2 4/5] package/mupdf: bump to version 1.23.9 Raphaël Mélotte via buildroot
2024-07-13 20:36 ` Thomas Petazzoni via buildroot
2024-06-07 16:32 ` [Buildroot] [PATCH v2 5/5] package/python-pymupdf: bump to version 1.23.22 Raphaël Mélotte via buildroot
2024-07-13 20:38 ` Thomas Petazzoni via buildroot
2024-07-13 20:34 ` [Buildroot] [PATCH v2 1/5] package: python-pymupdf: add missing python-zlib dependency Thomas Petazzoni via buildroot
2024-08-12 9:51 ` Peter Korsgaard
2024-02-16 21:13 ` [Buildroot] [PATCH 2/5] support/testing: add new test for python-pymupdf Raphaël Mélotte via buildroot
2024-02-16 21:13 ` [Buildroot] [PATCH 3/5] package/mupdf: fix building shared libraries Raphaël Mélotte via buildroot
2024-04-01 20:06 ` Arnout Vandecappelle via buildroot
2024-06-07 16:44 ` Raphaël Mélotte via buildroot
2024-02-16 21:13 ` [Buildroot] [PATCH 4/5] package/mupdf: bump to version 1.23.9 Raphaël Mélotte via buildroot
2024-02-16 21:13 ` [Buildroot] [PATCH 5/5] package/python-pymupdf: bump to version 1.23.22 Raphaël Mélotte via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240713223615.28cd0fab@windsurf \
--to=buildroot@buildroot.org \
--cc=raphael.melotte@mind.be \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox