Re: [Buildroot] [PATCH v4 3/3] board/raspberrypi: add support for Raspberry Pi 5

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Athaariq Ardhiansyah <foss@athaariq.my.id>
Cc: Martin Bark <martin@barkynet.com>,
	Julien Grossholtz <julien.grossholtz@openest.io>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v4 3/3] board/raspberrypi: add support for Raspberry Pi 5
Date: Sun, 14 Jul 2024 18:59:11 +0200	[thread overview]
Message-ID: <20240714185911.2740dc9d@windsurf> (raw)
In-Reply-To: <20240714160457.39434-3-foss@athaariq.my.id>

Hello,

On Sun, 14 Jul 2024 23:04:54 +0700
Athaariq Ardhiansyah <foss@athaariq.my.id> wrote:

> Since the last Raspberry Pi 5 submission has no progress, I'm submitting
> these patches anyway. The newly released Raspberry Pi 5 board shares
> similar software structure except it has less proprietary API.
> Therefore, rpi-userland and all of raspberry-centric GPIO utilities are
> no longer supported.
> 
> Keep in mind that RPi 5 has no native 32-bit support due to Cortex-A76
> processor specification. That is the reason why I did not add _64.
> 
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
> 
> ---
> Changes v1 -> v2:
>   - Fix missing newlines due to terminal issue
> 
> Changes v3 -> v4:
>   - Rebase to master
>   - Drop 4K page size, until we figured out how to run 32bit userspace
>     on top of 64bit kernel
>   - Change back from commit ID to commit tag
>   - Rewrite the commit description
>   - Fix incorrect CPU from upstream config, RPi5 has no LITTLE.big
> 
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
> ---
>  board/raspberrypi/config_5.txt                | 42 +++++++++++++++++++
>  .../patches/linux-headers/linux-headers.hash  |  1 -
>  board/raspberrypi/patches/linux/linux.hash    |  2 +-
>  configs/raspberrypi5_defconfig                | 17 ++++----
>  4 files changed, 50 insertions(+), 12 deletions(-)
>  delete mode 120000 board/raspberrypi/patches/linux-headers/linux-headers.hash

Thanks, but here you're submitted a diff against the previous
raspberrypi5_defconfig submission. Please submit a full patch adding
the complete support for RPi5, not a diff against some random other
patch posted on the mailing list.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot