Re: [Buildroot] [PATCH v4 1/3] package/rpi-firmware: bump version to 1.20240529

["Gaël PORTAY" <gael.portay@gmail.com>]

Hello Athaariq,

Thanks for the bump!

On Sun Jul 14, 2024 at 6:04 PM CEST, Athaariq Ardhiansyah wrote:
> Latest RPi firmware already provided support for Raspberry Pi 5.
>

Well, I think there is no big value about that message; furthermore, the
current raspberry5_defconfig does not (really) use that package:
 - It needs the config.txt that is **NOT** part of that package, weird
   though.
 - Since the pi4, (i.e pi5 included) the firmware is contained in the
   EEPROM (i.e. there is no more bootcode.bin in the first boot
   partition to boot a pi).
 - The device-tree blobs are taken from the linux kernel (not from the
   rpi-firmware).
 - The pi5 has its own dedicated console[1], therefore there is no more
   needs for the dtoverlay=miniuart-bt to have a console; this is why
   the raspberrypi5_defconfig unsets the config
   BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS.

Let's back to the commit message; it would have more sense if you tell
your change updates to the package version to a tag (instead of a taking
a "random" commit between tags). These days, upstream has released (i.e.
it has tagged commits) more often than we have bumped the package.
Therefore, it makes sense to bump the rpi-firmware to a tagged commit.
(TBH, the commit title suffices by itself, so leaving it blank is fine
with me).

However, and this is important, the rpi-firmware and the linux kernel
for raspberrypi are closely "linked" together because of the device-tree
blobs.

Indeed, the rpi-firmware provides the device-tree blob overlays and
these files needs the symbols of the matching device-tree blobs that are
provided by the kernel.

As a consequence, the version between rpi-firmware and linux ~~should~~
**MUST** match to avoid any boot-failure with the the load of overlays.

In all, a bump of the rpi-firmware **SHOULD** correspond to a bump of
the linux kernel, for every raspberrypi defconfig files (in a separate
commit). See commit[2][3].

You will find the commit id in extra/git_hash[4] in the rpi-firmware
tree: c1432b4bae5b6582f4d32ba381459f33c34d1424. And, you will figure out
it corresponds to tag stable_20240529[5] in the linux-raspberrypi tree.

Could you update BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION accordingly in
a dedicated commit? (I think you could use the tag name, no tested).

Thanks.

> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>
>
> ---
> Changes v1 -> v2:
>   - Fix missing description due to terminal issue
>
> Changes v2 -> v4:
>   - Change back from commit ID to commit tag
>
> Signed-off-by: Athaariq Ardhiansyah <foss@athaariq.my.id>

It is not necessary to Signed-off-by (twice) in the changelog :).

> ---
>  package/rpi-firmware/rpi-firmware.hash | 2 +-
>  package/rpi-firmware/rpi-firmware.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpi-firmware/rpi-firmware.hash b/package/rpi-firmware/rpi-firmware.hash
> index 4501db739c..5dc6efd8b3 100644
> --- a/package/rpi-firmware/rpi-firmware.hash
> +++ b/package/rpi-firmware/rpi-firmware.hash
> @@ -1,3 +1,3 @@
>  # Locally computed
> -sha256  00fe5487376e9d5ed14cbc72a9b7a5bd8d6900c84aee10f6d656f192a26d161c  rpi-firmware-5476720d52cf579dc1627715262b30ba1242525e.tar.gz
> +sha256  48d0b1b041bf77dc81d7ed04c423a7f4ce0afd0e3fbea26462309e738b89a552  rpi-firmware-1.20240529.tar.gz
>  sha256  c7283ff51f863d93a275c66e3b4cb08021a5dd4d8c1e7acc47d872fbe52d3d6b  boot/LICENCE.broadcom
> diff --git a/package/rpi-firmware/rpi-firmware.mk b/package/rpi-firmware/rpi-firmware.mk
> index 7ae9ff6c28..81066f0fc0 100644
> --- a/package/rpi-firmware/rpi-firmware.mk
> +++ b/package/rpi-firmware/rpi-firmware.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -RPI_FIRMWARE_VERSION = 5476720d52cf579dc1627715262b30ba1242525e
> +RPI_FIRMWARE_VERSION = 1.20240529
>  RPI_FIRMWARE_SITE = $(call github,raspberrypi,firmware,$(RPI_FIRMWARE_VERSION))
>  RPI_FIRMWARE_LICENSE = BSD-3-Clause
>  RPI_FIRMWARE_LICENSE_FILES = boot/LICENCE.broadcom

Please tell me if it is unclear or if I missed something; I am no
maintainer, and I may say stupid things :)

Regards,
Gaël

[1]: https://www.raspberrypi.com/documentation/computers/configuration.html#primary-and-secondary-uart
[2]: https://github.com/buildroot/buildroot/commit/51b4421758e5ccba0f051672ccd28bc3114948d9
[3]: https://github.com/buildroot/buildroot/commit/28e6953ba84d39a6074aee439a64ef86b109dcf0
[4]: https://github.com/raspberrypi/firmware/blob/1.20240529/extra/git_hash
[5]: https://github.com/raspberrypi/linux/commit/c1432b4bae5b6582f4d32ba381459f33c34d1424
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot