From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: "J. Neuschäfer" <j.neuschaefer@gmx.net>,
"Yann E. MORIN" <yann.morin.1998@free.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] Config.in: ban textrels on musl toolchains
Date: Mon, 15 Jul 2024 11:06:11 +0200 [thread overview]
Message-ID: <20240715110611.6a872bab@windsurf> (raw)
In-Reply-To: <50c04b02-5140-4c0c-b06d-e80eca7564af@mind.be>
On Mon, 15 Jul 2024 10:51:03 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> After some discussion, we concluded that we don't see the point of making this
> a user-settable Config.in option. It should be completely in the Makefile.in,
> with a comment explaining why. So something like this (untested!):
>
> # musl's dynamic loader doesn't support DT_TEXTREL, which results in a runtime
> # crash if it gets used. The "-z text" linker option issues a build-time error
> # when DT_TEXREL is used, so we capture the problem earlier.
> ifeq ($(BR2_TOOLCHAIN_USES_MUSL)$(BR2_STATIC_LIBS),yy)
> TARGET_LDFLAGS += -#l,-z,text
^^^ this should have been -Wl,-z,text of course
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-15 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 18:05 [Buildroot] [PATCH v3] Config.in: ban textrels on musl toolchains J. Neuschäfer via buildroot
2024-07-15 8:51 ` Arnout Vandecappelle via buildroot
2024-07-15 9:06 ` Thomas Petazzoni via buildroot [this message]
2024-07-17 11:52 ` J. Neuschäfer via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715110611.6a872bab@windsurf \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=j.neuschaefer@gmx.net \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox