Re: [Buildroot] [PATCH v3] Config.in: ban textrels on musl toolchains

["J. Neuschäfer via buildroot" <buildroot@buildroot.org>]

On Mon, Jul 15, 2024 at 10:51:03AM +0200, Arnout Vandecappelle wrote:
>  Hi J.,
>
>  [BTW are you OK with me calling you "J."? It feels a bit weird...]

It's ok, as well as jn ("jay-enn"). which is also ok.

>
> On 04/07/2024 20:05, J. Neuschäfer via buildroot wrote:
[...]
> > +ifeq ($(BR2_LINK_ALLOW_TEXTREL),)
> > +TARGET_LDFLAGS += -z text
> > +endif
>
>  After some discussion, we concluded that we don't see the point of making
> this a user-settable Config.in option. It should be completely in the
> Makefile.in, with a comment explaining why. So something like this
> (untested!):
>
> # musl's dynamic loader doesn't support DT_TEXTREL, which results in a runtime
> # crash if it gets used. The "-z text" linker option issues a build-time error
> # when DT_TEXREL is used, so we capture the problem earlier.
> ifeq ($(BR2_TOOLCHAIN_USES_MUSL)$(BR2_STATIC_LIBS),yy)
> TARGET_LDFLAGS += -#l,-z,text
> endif
>
>  Note also that we use -Wl,-z,... everywhere else to pass the -z options to
> the linker. Maybe that's because older GCC don't understand -z. But anyway,
> to be consistent, let's do the same here.
>
>  Can you test the above version and resubmit? Oh, and please also in the
> commit message give an example of how you can test it (e.g. by removing the
> micropyton patch and building micropyton under musl?)

Yep, will do!
Thanks again for your review.


jn
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot