From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Marcus Hoffmann via buildroot <buildroot@buildroot.org>
Cc: Sergio Prado <sergio.prado@e-labworks.com>,
Marcus Hoffmann <buildroot@bubu1.eu>
Subject: Re: [Buildroot] [PATCH 1/2] package/tio: install bash-completions
Date: Mon, 15 Jul 2024 12:50:50 +0200 [thread overview]
Message-ID: <20240715125050.0a6328a5@windsurf> (raw)
In-Reply-To: <20240213114933.2444440-1-buildroot@bubu1.eu>
Hello Marcus,
On Tue, 13 Feb 2024 12:49:31 +0100
Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote:
> See meson_options.txt file [1].
>
> [1] https://github.com/tio/tio/blob/master/meson_options.txt
>
> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
> ---
> package/tio/tio.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/tio/tio.mk b/package/tio/tio.mk
> index d7b554ee84..a7d3537850 100644
> --- a/package/tio/tio.mk
> +++ b/package/tio/tio.mk
> @@ -10,5 +10,10 @@ TIO_SITE = https://github.com/tio/tio/releases/download/v$(TIO_VERSION)
> TIO_LICENSE = GPL-2.0+
> TIO_LICENSE_FILES = LICENSE
> TIO_DEPENDENCIES = inih
> +ifeq ($(BR2_PACKAGE_BASH_COMPLETION),y)
Added an empty line between the TIO_DEPENDENCIES line and the condition.
> +TIO_CONF_OPTS +=-Dbashcompletiondir=/usr/share/bash-completion/completions/
Dropped the final / to match with other usage of
/usr/share/bash-completion/completions in the tree.
Applied with those minor nits fixed. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-07-15 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 11:49 [Buildroot] [PATCH 1/2] package/tio: install bash-completions Marcus Hoffmann via buildroot
2024-02-13 11:49 ` [Buildroot] [PATCH 2/2] package/tio: disable installing man page Marcus Hoffmann via buildroot
2024-07-15 10:52 ` Thomas Petazzoni via buildroot
2024-07-15 10:50 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715125050.0a6328a5@windsurf \
--to=buildroot@buildroot.org \
--cc=buildroot@bubu1.eu \
--cc=sergio.prado@e-labworks.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox