From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Marcus Hoffmann via buildroot <buildroot@buildroot.org>
Cc: Sergio Prado <sergio.prado@e-labworks.com>,
Marcus Hoffmann <buildroot@bubu1.eu>
Subject: Re: [Buildroot] [PATCH 2/2] package/tio: disable installing man page
Date: Mon, 15 Jul 2024 12:52:37 +0200 [thread overview]
Message-ID: <20240715125237.04908049@windsurf> (raw)
In-Reply-To: <20240213114933.2444440-2-buildroot@bubu1.eu>
Hello Marcus,
On Tue, 13 Feb 2024 12:49:32 +0100
Marcus Hoffmann via buildroot <buildroot@buildroot.org> wrote:
> Remove the man subdir from inclusion in the main meson.build file.
>
> Reported upstream to get an option to disable this properly:
> https://github.com/tio/tio/issues/222
>
> Signed-off-by: Marcus Hoffmann <buildroot@bubu1.eu>
I did not apply this patch. Indeed, man pages are anyway removed at the
end of the build, so we don't really care that much if they are
installed. Of course, if there's a convenient option to disable
installing manpages we can use it (and upstream has added one following
your bug report, and therefore once we upgrade to a newer release that
has this option, we can use it). But when we don't go through great
lengths to disable manpages otherwise, *except* if building the
manpages requires some additional tools that would bring in extra
dependencies into the build.
So I've marked your patch as Rejected. Feel free to use the new option
to disable manpages at the next version bump of tio.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-15 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 11:49 [Buildroot] [PATCH 1/2] package/tio: install bash-completions Marcus Hoffmann via buildroot
2024-02-13 11:49 ` [Buildroot] [PATCH 2/2] package/tio: disable installing man page Marcus Hoffmann via buildroot
2024-07-15 10:52 ` Thomas Petazzoni via buildroot [this message]
2024-07-15 10:50 ` [Buildroot] [PATCH 1/2] package/tio: install bash-completions Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715125237.04908049@windsurf \
--to=buildroot@buildroot.org \
--cc=buildroot@bubu1.eu \
--cc=sergio.prado@e-labworks.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox