Re: [Buildroot] [PATCH 2/4] package/fwupd-efi: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/4] package/fwupd-efi: new package
Date: Tue, 16 Jul 2024 14:15:33 +0200	[thread overview]
Message-ID: <20240716141533.7a23365d@windsurf> (raw)
In-Reply-To: <20240605234131.3370484-2-james.hilliard1@gmail.com>

Hello James,

On Wed,  5 Jun 2024 17:41:29 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/Config.in                |  1 +
>  package/fwupd-efi/Config.in      |  8 ++++++++
>  package/fwupd-efi/fwupd-efi.hash |  3 +++
>  package/fwupd-efi/fwupd-efi.mk   | 25 +++++++++++++++++++++++++
>  4 files changed, 37 insertions(+)
>  create mode 100644 package/fwupd-efi/Config.in
>  create mode 100644 package/fwupd-efi/fwupd-efi.hash
>  create mode 100644 package/fwupd-efi/fwupd-efi.mk

Thanks for the patch! Entry in DEVELOPERS file is missing (I had added
it locally), but more importantly, the build fails:

FAILED: efi/fwup-sbat.o 
/home/thomas/projets/buildroot/output/build/fwupd-efi-1.6/efi/generate_sbat.py efi/fwup-sbat.o --cc /home/thomas/projets/buildroot/output/host/bin/arm-linux-gcc --cflags '-Og -g3 --param=ssp-buffer-size=4 -fexceptions -Wall -Wextra -Wvla -std=gnu11 -fpic -funsigned-char -fshort-wchar -ffreestanding -fno-strict-aliasing -fno-stack-protector -fno-stack-check -fno-merge-all-constants -Wsign-compare -Wno-missing-field-initializers -Wno-address-of-packed-member -grecord-gcc-switches -DDEBUGDIR="/usr/lib/debug" -I. -isystem /home/thomas/projets/buildroot/output/host/arm-buildroot-linux-musleabihf/sysroot/usr/include/efi -isystem /home/thomas/projets/buildroot/output/host/arm-buildroot-linux-musleabihf/sysroot/usr/include/efi/arm -fno-merge-constants' --objcopy /usr/bin/objcopy --project-name fwupd-efi --project-version 1.6 --sbat-version 1 --sbat-generation 1 --sbat-distro-id buildroot --sbat-distro-generation 0 --sbat-distro-summary Buildroot --sbat-distro-pkgname fwupd-efi --sbat-distro-
 version fwupd-efi-1.6 --sbat-distro-url https://gitlab.com/buildroot.org/buildroot/-/tree/master/package/fwupd-efi
/usr/bin/objcopy: Unable to recognise the format of the input file `efi/fwup-sbat.o'
Traceback (most recent call last):
  File "/home/thomas/projets/buildroot/output/build/fwupd-efi-1.6/efi/generate_sbat.py", line 118, in <module>
    _generate_sbat(_args)
  File "/home/thomas/projets/buildroot/output/build/fwupd-efi-1.6/efi/generate_sbat.py", line 80, in _generate_sbat
    subprocess.run(argv, check=True)
  File "/usr/lib64/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/bin/objcopy', '--add-section', '.sbat=/tmp/tmpd55y25q9', '--set-section-flags', '.sbat=contents,alloc,load,readonly,data', 'efi/fwup-sbat.o']' returned non-zero exit status 1.

I think it's due to the fact that it is using /usr/bin/objcopy instead
of the cross objcopy. You probably didn't notice as you were building
for x86-64, and therefore the host objcopy didn't work.

Could you test building for a foreign architecture, and preferably
using ./utils/docker-run (see my review on PATCH 4/4 to understand why
docker-run is important).

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot