Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Olivain <ju.o@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/4] package/fwupd-efi: new package
Date: Thu, 06 Jun 2024 21:25:37 +0200	[thread overview]
Message-ID: <2ecf3de13be3195cafaffacec85cb04f@free.fr> (raw)
In-Reply-To: <20240605234131.3370484-2-james.hilliard1@gmail.com>

Hi James,

Thanks for the patch!

On 06/06/2024 01:41, James Hilliard wrote:
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/Config.in                |  1 +
>  package/fwupd-efi/Config.in      |  8 ++++++++
>  package/fwupd-efi/fwupd-efi.hash |  3 +++
>  package/fwupd-efi/fwupd-efi.mk   | 25 +++++++++++++++++++++++++
>  4 files changed, 37 insertions(+)
>  create mode 100644 package/fwupd-efi/Config.in
>  create mode 100644 package/fwupd-efi/fwupd-efi.hash
>  create mode 100644 package/fwupd-efi/fwupd-efi.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 9a948c5536..2be39f98c7 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -519,6 +519,7 @@ endmenu
>  	source "package/fmtools/Config.in"
>  	source "package/freeipmi/Config.in"
>  	source "package/freescale-imx/Config.in"
> +	source "package/fwupd-efi/Config.in"
>  	source "package/fxload/Config.in"
>  	source "package/gcnano-binaries/Config.in"
>  	source "package/gpm/Config.in"
> diff --git a/package/fwupd-efi/Config.in b/package/fwupd-efi/Config.in
> new file mode 100644
> index 0000000000..3d82f480be
> --- /dev/null
> +++ b/package/fwupd-efi/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_FWUPD_EFI
> +	bool "fwupd-efi"
> +	depends on BR2_PACKAGE_GNU_EFI_ARCH_SUPPORTS
> +	select BR2_PACKAGE_GNU_EFI
> +	help
> +	  EFI Application used by uefi-capsule plugin in fwupd.
> +
> +	  https://github.com/fwupd/fwupd-efi
> diff --git a/package/fwupd-efi/fwupd-efi.hash 
> b/package/fwupd-efi/fwupd-efi.hash
> new file mode 100644
> index 0000000000..35dc9625ca
> --- /dev/null
> +++ b/package/fwupd-efi/fwupd-efi.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  
> afd0805a2ad081a7caff2ef5bc004ce3a0147b538015e8eca966341716b1260e  
> fwupd-efi-1.6.tar.xz
> +sha256  
> dc626520dcd53a22f727af3ee42c770e56c97a64fe3adb063799d8ab032fe551  
> COPYING
> diff --git a/package/fwupd-efi/fwupd-efi.mk 
> b/package/fwupd-efi/fwupd-efi.mk
> new file mode 100644
> index 0000000000..575cf73b95
> --- /dev/null
> +++ b/package/fwupd-efi/fwupd-efi.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# fwupd-efi
> +#
> +################################################################################
> +
> +FWUPD_EFI_VERSION = 1.6
> +FWUPD_EFI_SITE = 
> https://github.com/fwupd/fwupd-efi/releases/download/$(FWUPD_EFI_VERSION)
> +FWUPD_EFI_SOURCE = fwupd-efi-$(FWUPD_EFI_VERSION).tar.xz
> +FWUPD_EFI_LICENSE = LGPL-2.1+
> +FWUPD_EFI_LICENSE_FILES = COPYING
> +FWUPD_EFI_INSTALL_STAGING = YES
> +FWUPD_EFI_DEPENDENCIES = gnu-efi
> +FWUPD_EFI_CONF_OPTS = \
> +	-Defi-libdir=$(STAGING_DIR)/usr/lib \
> +	-Defi-ldsdir=$(STAGING_DIR)/usr/lib \
> +	-Defi-includedir=$(STAGING_DIR)/usr/include/efi \
> +	-Defi_sbat_fwupd_generation=1 \
> +	-Defi_sbat_distro_id=buildroot \
> +	-Defi_sbat_distro_summary=Buildroot \
> +	-Defi_sbat_distro_pkgname=fwupd-efi \
> +	-Defi_sbat_distro_version=fwupd-efi-$(FWUPD_EFI_VERSION) \
> +	-Defi_sbat_distro_url=https://git.buildroot.net/buildroot/tree/package/fwupd-efi

According to:
https://gitlab.com/buildroot.org/buildroot/-/commit/3e3bcd633875db0e1f366e86fe8763b5b2d9112e
the official git repository is on gitlab.

Therefore, I think this line should be:

https://gitlab.com/buildroot.org/buildroot/-/tree/master/package/fwupd-efi


> +
> +$(eval $(meson-package))
> --
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-06-06 19:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 23:41 [Buildroot] [PATCH 1/4] package/libjcat: new package James Hilliard
2024-06-05 23:41 ` [Buildroot] [PATCH 2/4] package/fwupd-efi: " James Hilliard
2024-06-06 19:25   ` Julien Olivain [this message]
2024-07-16 12:15   ` Thomas Petazzoni via buildroot
2024-07-16 18:04     ` James Hilliard
2024-06-05 23:41 ` [Buildroot] [PATCH 3/4] package/flashrom: install to staging with meson James Hilliard
2024-06-05 23:41 ` [Buildroot] [PATCH 4/4] package/fwupd: new package James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ecf3de13be3195cafaffacec85cb04f@free.fr \
    --to=ju.o@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=eric.le.bihan.dev@free.fr \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox