Re: [Buildroot] [PATCH v2 4/4] package/fwupd: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 11 Jun 2024 09:22:02 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/Config.in        |   1 +
>  package/fwupd/Config.in  |  19 ++++
>  package/fwupd/fwupd.hash |   3 +
>  package/fwupd/fwupd.mk   | 208 +++++++++++++++++++++++++++++++++++++++
>  4 files changed, 231 insertions(+)
>  create mode 100644 package/fwupd/Config.in
>  create mode 100644 package/fwupd/fwupd.hash
>  create mode 100644 package/fwupd/fwupd.mk

Entry in the DEVELOPERS is missing (I had added it locally, but
encountered other issues).

Then, udev dependency is missing:

output/build/fwupd-1.9.20/meson.build:278:11: ERROR: Dependency "udev" not found, tried pkgconfig and cmake

so I added it. But then:

output/build/fwupd-1.9.20/meson.build:327:32: ERROR: Feature offline cannot be enabled: -Doffline=enabled requires systemd

so I moved -Doffline=enabled into the systemd condition.

But then:

output/build/fwupd-1.9.20/meson.build:594:9: ERROR: Command `/home/thomas/projets/buildroot/output/host/bin/python3 -c 'import jinja2; print(jinja2.__version__)'` failed with status 1.

Which probably you had not seen because you had jinja2 installed on
your system. Could you make sure to test build packages with
./utils/docker-run to catch such "spurious" host dependencies?

I quickly grepped for jinja2 in the tree, but it wasn't immediately
clear if it was absolutely mandatory, exactly for what, etc. Hopefully
you'll be able to figure out. It would be nice to not make it a
mandatory dependency to build fwupd, if possible of course.

Could you have a look?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot