Re: [Buildroot] [PATCH v2 4/4] package/fwupd: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello James,

Thanks for the quick turnaround. One question below.

On Tue, 16 Jul 2024 11:55:18 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Fixed in v3 by setting -Dudevdir=/usr/lib/udev which eliminates the
> udev dependency.

It seems very odd to me to set -Dudevdir=/usr/lib/udev when the
directory doesn't exist because udev isn't enabled. Could you clarify
how this can be correct?


> > Which probably you had not seen because you had jinja2 installed on
> > your system. Could you make sure to test build packages with
> > ./utils/docker-run to catch such "spurious" host dependencies?  
> 
> It was missed because I was testing with systemd enabled, which has a
> transitive dependency on host-python-jinja2.

Indeed.

> > I quickly grepped for jinja2 in the tree, but it wasn't immediately
> > clear if it was absolutely mandatory, exactly for what, etc. Hopefully
> > you'll be able to figure out. It would be nice to not make it a
> > mandatory dependency to build fwupd, if possible of course.  
> 
> Yeah, it's mandatory for some scripts, fixed in v3.

OK.

> v3:
> https://patchwork.ozlabs.org/project/buildroot/patch/20240716175037.1844929-5-james.hilliard1@gmail.com/

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot