[Buildroot] [PATCH 1/1] package/flashrom: disable -Werror

[Buildroot] [PATCH 1/1] package/flashrom: disable -Werror

[Fabrice Fontaine]

Disable -Werror to avoid the following build failure raised since bump
to version 1.3.0 in commit 073b0fc9c1fe9945eccf4b792b948633aae9a9b8:

chipset_enable.c:27: error: "_LARGEFILE64_SOURCE" redefined [-Werror]
   27 | #define _LARGEFILE64_SOURCE
      |
<command-line>: note: this is the location of the previous definition

Fixes:
 - http://autobuild.buildroot.org/results/b8d8c30d1306c2ba8f59b48f457a7ef930306b8c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/flashrom/flashrom.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/flashrom/flashrom.mk b/package/flashrom/flashrom.mk
index ca55592dba..1ccef572da 100644
--- a/package/flashrom/flashrom.mk
+++ b/package/flashrom/flashrom.mk
@@ -9,6 +9,7 @@ FLASHROM_SOURCE = flashrom-v$(FLASHROM_VERSION).tar.bz2
 FLASHROM_SITE = https://download.flashrom.org/releases
 FLASHROM_LICENSE = GPL-2.0+
 FLASHROM_LICENSE_FILES = COPYING
+FLASHROM_MAKE_OPTS = WARNERROR=no
 
 ifeq ($(BR2_PACKAGE_LIBFTDI),y)
 FLASHROM_DEPENDENCIES += host-pkgconf libftdi
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/flashrom: disable -Werror

[Thomas Petazzoni via buildroot]

On Mon, 30 Oct 2023 14:10:52 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Disable -Werror to avoid the following build failure raised since bump
> to version 1.3.0 in commit 073b0fc9c1fe9945eccf4b792b948633aae9a9b8:
> 
> chipset_enable.c:27: error: "_LARGEFILE64_SOURCE" redefined [-Werror]
>    27 | #define _LARGEFILE64_SOURCE
>       |
> <command-line>: note: this is the location of the previous definition
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/b8d8c30d1306c2ba8f59b48f457a7ef930306b8c
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/flashrom/flashrom.mk | 1 +
>  1 file changed, 1 insertion(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/1] package/flashrom: disable -Werror

[Fabrice Fontaine]

Disable -Werror to avoid the following build failure raised since switch
to meson-package in commit 37dded43ae681e8319d7b76f9a612c71991467a9:

../stlinkv3_spi.c: In function 'stlinkv3_spi_init':
../stlinkv3_spi.c:508:12: error: 'stlinkv3_handle' may be used uninitialized [-Werror=maybe-uninitialized]
  508 |         if (!stlinkv3_handle) {
      |            ^
../stlinkv3_spi.c:485:31: note: 'stlinkv3_handle' was declared here
  485 |         libusb_device_handle *stlinkv3_handle;
      |                               ^~~~~~~~~~~~~~~

Fixes: 37dded43ae681e8319d7b76f9a612c71991467a9
 - http://autobuild.buildroot.org/results/eecabbdd0d21344991379a57e605845e73ef679e

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/flashrom/flashrom.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/flashrom/flashrom.mk b/package/flashrom/flashrom.mk
index 60774b9621..0b474caab4 100644
--- a/package/flashrom/flashrom.mk
+++ b/package/flashrom/flashrom.mk
@@ -15,7 +15,8 @@ FLASHROM_CONF_OPTS = \
 	-Dclassic_cli_print_wiki=disabled \
 	-Dich_descriptors_tool=enabled \
 	-Dtests=disabled \
-	-Duse_internal_dmi=true
+	-Duse_internal_dmi=true \
+	-Dwerror=false
 
 FLASHROM_PROGRAMMERS = \
 	buspirate_spi \
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/flashrom: disable -Werror

[Thomas Petazzoni via buildroot]

On Sat, 20 Jul 2024 16:48:31 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Disable -Werror to avoid the following build failure raised since switch
> to meson-package in commit 37dded43ae681e8319d7b76f9a612c71991467a9:
> 
> ../stlinkv3_spi.c: In function 'stlinkv3_spi_init':
> ../stlinkv3_spi.c:508:12: error: 'stlinkv3_handle' may be used uninitialized [-Werror=maybe-uninitialized]
>   508 |         if (!stlinkv3_handle) {
>       |            ^
> ../stlinkv3_spi.c:485:31: note: 'stlinkv3_handle' was declared here
>   485 |         libusb_device_handle *stlinkv3_handle;
>       |                               ^~~~~~~~~~~~~~~
> 
> Fixes: 37dded43ae681e8319d7b76f9a612c71991467a9
>  - http://autobuild.buildroot.org/results/eecabbdd0d21344991379a57e605845e73ef679e
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/flashrom/flashrom.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot