[Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[Alexander Mukhin]

Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>
---
 package/zfs/zfs.hash | 4 ++--
 package/zfs/zfs.mk   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/zfs/zfs.hash b/package/zfs/zfs.hash
index 01c86f2b..9c8d4cec 100644
--- a/package/zfs/zfs.hash
+++ b/package/zfs/zfs.hash
@@ -1,5 +1,5 @@
-# From https://github.com/openzfs/zfs/releases/download/zfs-2.2.2/zfs-2.2.2.sha256.asc
-sha256  76bc0547d9ba31d4b0142e417aaaf9f969072c3cb3c1a5b10c8738f39ed12fc9  zfs-2.2.2.tar.gz
+# From https://github.com/openzfs/zfs/releases/download/zfs-2.2.4/zfs-2.2.4.sha256.asc
+sha256  9790905f7683d41759418e1ef3432828c31116654ff040e91356ff1c21c31ec0  zfs-2.2.4.tar.gz
 
 # Hash for license files:
 sha256  1ffb70c33c4f79f04e947facc5c7851f289609256aacb47fc115f700427d9520  LICENSE
diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
index 59cdd319..fa6d282f 100644
--- a/package/zfs/zfs.mk
+++ b/package/zfs/zfs.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-ZFS_VERSION = 2.2.2
+ZFS_VERSION = 2.2.4
 ZFS_SITE = https://github.com/openzfs/zfs/releases/download/zfs-$(ZFS_VERSION)
 ZFS_SELINUX_MODULES = zfs
 ZFS_LICENSE = CDDL
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[Peter Korsgaard]

>>>>> "Alexander" == Alexander Mukhin <alexander.i.mukhin@gmail.com> writes:

 > Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[Peter Korsgaard]

>>>>> "Alexander" == Alexander Mukhin <alexander.i.mukhin@gmail.com> writes:

 > Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[Thomas Petazzoni via buildroot]

Hello Alexander,

I'm not sure if it's related to this version bump, or to something
else, but the ZFS runtime test is failing:

  https://gitlab.com/buildroot.org/buildroot/-/jobs/7391793226

Could you perhaps have a look at what's going on?

Thanks a lot,

Thomas

On Fri, 24 May 2024 21:18:56 +0300
Alexander Mukhin <alexander.i.mukhin@gmail.com> wrote:

> Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>
> ---
>  package/zfs/zfs.hash | 4 ++--
>  package/zfs/zfs.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/zfs/zfs.hash b/package/zfs/zfs.hash
> index 01c86f2b..9c8d4cec 100644
> --- a/package/zfs/zfs.hash
> +++ b/package/zfs/zfs.hash
> @@ -1,5 +1,5 @@
> -# From https://github.com/openzfs/zfs/releases/download/zfs-2.2.2/zfs-2.2.2.sha256.asc
> -sha256  76bc0547d9ba31d4b0142e417aaaf9f969072c3cb3c1a5b10c8738f39ed12fc9  zfs-2.2.2.tar.gz
> +# From https://github.com/openzfs/zfs/releases/download/zfs-2.2.4/zfs-2.2.4.sha256.asc
> +sha256  9790905f7683d41759418e1ef3432828c31116654ff040e91356ff1c21c31ec0  zfs-2.2.4.tar.gz
>  
>  # Hash for license files:
>  sha256  1ffb70c33c4f79f04e947facc5c7851f289609256aacb47fc115f700427d9520  LICENSE
> diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
> index 59cdd319..fa6d282f 100644
> --- a/package/zfs/zfs.mk
> +++ b/package/zfs/zfs.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -ZFS_VERSION = 2.2.2
> +ZFS_VERSION = 2.2.4
>  ZFS_SITE = https://github.com/openzfs/zfs/releases/download/zfs-$(ZFS_VERSION)
>  ZFS_SELINUX_MODULES = zfs
>  ZFS_LICENSE = CDDL



-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[José Luis Salvador Rufo]

[-- Attachment #1.1: Type: text/plain, Size: 2946 bytes --]

Hello Thomas, Alexander, and everyone,

Yes, indeed, the problem is due to a backported patch included in ZFS
2.2.4. That is why I haven't sent the upgrade to Buildroot yet. Instead, I
am currently working with upstream to include a fix (
https://github.com/openzfs/zfs/pull/16169). However, upstream has many
different opinions on how to resolve the issue, and they tend to change as
soon as I submit a patch (which is common in the OSS space). Once upstream
approves the patch, I will send it to Buildroot.

In the meantime, I recommend the following options:

A) Revert to the previous version (OpenZFS v2.2.3). This is not ideal for
people who have already upgraded.

B) Include a work-in-progress (it works for buildroot, I tested it) patch:
https://github.com/openzfs/zfs/pull/16169.patch.

C) Disable the test for uClibc and disable ZFS when uClibc is selected as
the toolkit.

Thoughts?

El lun, 22 jul 2024 a las 14:47, Thomas Petazzoni (<
thomas.petazzoni@bootlin.com>) escribió:

> Hello Alexander,
>
> I'm not sure if it's related to this version bump, or to something
> else, but the ZFS runtime test is failing:
>
>   https://gitlab.com/buildroot.org/buildroot/-/jobs/7391793226
>
> Could you perhaps have a look at what's going on?
>
> Thanks a lot,
>
> Thomas
>
> On Fri, 24 May 2024 21:18:56 +0300
> Alexander Mukhin <alexander.i.mukhin@gmail.com> wrote:
>
> > Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com>
> > ---
> >  package/zfs/zfs.hash | 4 ++--
> >  package/zfs/zfs.mk   | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/package/zfs/zfs.hash b/package/zfs/zfs.hash
> > index 01c86f2b..9c8d4cec 100644
> > --- a/package/zfs/zfs.hash
> > +++ b/package/zfs/zfs.hash
> > @@ -1,5 +1,5 @@
> > -# From
> https://github.com/openzfs/zfs/releases/download/zfs-2.2.2/zfs-2.2.2.sha256.asc
> > -sha256
> 76bc0547d9ba31d4b0142e417aaaf9f969072c3cb3c1a5b10c8738f39ed12fc9
> zfs-2.2.2.tar.gz
> > +# From
> https://github.com/openzfs/zfs/releases/download/zfs-2.2.4/zfs-2.2.4.sha256.asc
> > +sha256
> 9790905f7683d41759418e1ef3432828c31116654ff040e91356ff1c21c31ec0
> zfs-2.2.4.tar.gz
> >
> >  # Hash for license files:
> >  sha256
> 1ffb70c33c4f79f04e947facc5c7851f289609256aacb47fc115f700427d9520  LICENSE
> > diff --git a/package/zfs/zfs.mk b/package/zfs/zfs.mk
> > index 59cdd319..fa6d282f 100644
> > --- a/package/zfs/zfs.mk
> > +++ b/package/zfs/zfs.mk
> > @@ -4,7 +4,7 @@
> >  #
> >
> ################################################################################
> >
> > -ZFS_VERSION = 2.2.2
> > +ZFS_VERSION = 2.2.4
> >  ZFS_SITE =
> https://github.com/openzfs/zfs/releases/download/zfs-$(ZFS_VERSION)
> >  ZFS_SELINUX_MODULES = zfs
> >  ZFS_LICENSE = CDDL
>
>
>
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 4622 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[Thomas Petazzoni via buildroot]

Hello José,

Thanks for your super quick feedback!

On Mon, 22 Jul 2024 15:01:45 +0200
José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:

> In the meantime, I recommend the following options:
> 
> A) Revert to the previous version (OpenZFS v2.2.3). This is not ideal for
> people who have already upgraded.
> 
> B) Include a work-in-progress (it works for buildroot, I tested it) patch:
> https://github.com/openzfs/zfs/pull/16169.patch.

Please do this option (B), and also contribute SEEK_DATA support to
uClibc. I've added Waldemar, the uClibc-ng maintainer, in Cc.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[José Luis Salvador Rufo]

[-- Attachment #1.1: Type: text/plain, Size: 1362 bytes --]

Hello Waldemar Brodkorb,

I saw the commit
https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=05b11809bd11450aff3d20e43f18415ce58601e7
that defines SEEK_DATA and SEEK_HOLE. However, I noticed that the following
code could fail at runtime:
https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/libc/sysdeps/linux/common/lseek.c?id=05b11809bd11450aff3d20e43f18415ce58601e7#n44

Should SEEK_DATA and SEEK_HOLE be included here as well?

Regards.

El lun, 22 jul 2024 a las 15:18, Thomas Petazzoni (<
thomas.petazzoni@bootlin.com>) escribió:

> Hello José,
>
> Thanks for your super quick feedback!
>
> On Mon, 22 Jul 2024 15:01:45 +0200
> José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:
>
> > In the meantime, I recommend the following options:
> >
> > A) Revert to the previous version (OpenZFS v2.2.3). This is not ideal for
> > people who have already upgraded.
> >
> > B) Include a work-in-progress (it works for buildroot, I tested it)
> patch:
> > https://github.com/openzfs/zfs/pull/16169.patch.
>
> Please do this option (B), and also contribute SEEK_DATA support to
> uClibc. I've added Waldemar, the uClibc-ng maintainer, in Cc.
>
> Thanks a lot!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 2263 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/zfs: bump version to 2.2.4

[Waldemar Brodkorb]

Hi,
José Luis Salvador Rufo wrote,

> Hello Waldemar Brodkorb,
> 
> I saw the commit https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=
> 05b11809bd11450aff3d20e43f18415ce58601e7 that defines SEEK_DATA and SEEK_HOLE.
> However, I noticed that the following code could fail at runtime: https://
> cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/libc/sysdeps/linux/common/
> lseek.c?id=05b11809bd11450aff3d20e43f18415ce58601e7#n44

Do you understand the ifdef constructions? Under which condition it
will use this code?
 
> Should SEEK_DATA and SEEK_HOLE be included here as well?

Not sure. Do you have a simple test case I can try?

best regards
 Waldemar
 
> Regards.
> 
> El lun, 22 jul 2024 a las 15:18, Thomas Petazzoni (<
> thomas.petazzoni@bootlin.com>) escribió:
> 
>     Hello José,
> 
>     Thanks for your super quick feedback!
> 
>     On Mon, 22 Jul 2024 15:01:45 +0200
>     José Luis Salvador Rufo <salvador.joseluis@gmail.com> wrote:
> 
>     > In the meantime, I recommend the following options:
>     >
>     > A) Revert to the previous version (OpenZFS v2.2.3). This is not ideal for
>     > people who have already upgraded.
>     >
>     > B) Include a work-in-progress (it works for buildroot, I tested it)
>     patch:
>     > https://github.com/openzfs/zfs/pull/16169.patch.
> 
>     Please do this option (B), and also contribute SEEK_DATA support to
>     uClibc. I've added Waldemar, the uClibc-ng maintainer, in Cc.
> 
>     Thanks a lot!
> 
>     Thomas
>     --
>     Thomas Petazzoni, co-owner and CEO, Bootlin
>     Embedded Linux and Kernel engineering and training
>     https://bootlin.com
> 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot