From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Woodrow Douglass via buildroot <buildroot@buildroot.org>
Cc: Woodrow Douglass <wdouglass@carnegierobotics.com>
Subject: Re: [Buildroot] [PATCH] package/chicken: move literals into text section for xtensa architecture
Date: Mon, 22 Jul 2024 15:41:29 +0200 [thread overview]
Message-ID: <20240722154129.024b7f45@windsurf> (raw)
In-Reply-To: <20240722131117.273274-1-wdouglass@carnegierobotics.com>
Hello Woodrow,
On Mon, 22 Jul 2024 09:11:16 -0400
Woodrow Douglass via buildroot <buildroot@buildroot.org> wrote:
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
Thanks for the patch. Would be good to have a non-empty commit message.
> -# If ARCH is not set, it attempts to autodiscover. But it is anyway not used.
> CHICKEN_MAKE_OPTS = \
> - ARCH=unused \
> + ARCH=$(BR2_NORMALIZED_ARCH) \
Are you sure that all values of BR2_NORMALIZED_ARCH are supported by
the chicken build system? What happens when the value passed is unknown
to the chicken build system?
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-22 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 13:11 [Buildroot] [PATCH] package/chicken: move literals into text section for xtensa architecture Woodrow Douglass via buildroot
2024-07-22 13:41 ` Thomas Petazzoni via buildroot [this message]
2024-07-22 14:30 ` Woodrow Douglass via buildroot
2024-07-22 14:57 ` Baruch Siach via buildroot
2024-07-22 15:07 ` Woody Douglass via buildroot
2024-07-22 15:08 ` Woodrow Douglass via buildroot
2024-07-22 16:15 ` Thomas Petazzoni via buildroot
2024-07-22 17:24 ` Woody Douglass via buildroot
2024-07-22 17:31 ` Woodrow Douglass via buildroot
2024-08-02 17:10 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722154129.024b7f45@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wdouglass@carnegierobotics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox