Re: [Buildroot] [PATCH] package/chicken: move literals into text section for xtensa architecture

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Woodrow,

On Mon, 22 Jul 2024 13:31:36 -0400
Woodrow Douglass via buildroot <buildroot@buildroot.org> wrote:

> This solves a build problem -- by default xtensa-gcc puts literals in a
> different section of memory then the program text, and chicken is a very
> literal-heavy program, so they don't all fit there. This avoids that problem.
> 
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>

Thanks, I have applied your patch, with a few fixes.

First, I've added a reference to an autobuilder failure fixed by this
patch, as follows:

"""
    Fixes:
    
      http://autobuild.buildroot.net/results/ce36170d67c4702f34bee025d8a46e5269c4573e/
  
"""

> -# If ARCH is not set, it attempts to autodiscover. But it is anyway not used.
> +#Chicken only uses the "arch" variable for some special-case compile arguments
> +#If it's empty, it tries to detect the arch host
> +#Filter out values that have an effect, or pass "unused" here

We always put a space after the # sign starting a comment.

> +ifeq ($(BR2_NORMALIZED_ARCH),"x86_64")

I've used $(NORMALIZED_ARCH) instead, which already has double quotes
stripped, so instead of "x86_64" we can use just x86_64.

> +CHICKEN_ARCH="x86-64"

Spaces around = sign, no double quotes around x86-64.

> +else ifeq ($(BR2_NORMALIZED_ARCH),"xtensa")
> +CHICKEN_ARCH="xtensa"
> +else
> +CHICKEN_ARCH="unused"
> +endif
> +
>  CHICKEN_MAKE_OPTS = \
> -	ARCH=unused \
> +	ARCH=$(CHICKEN_ARCH) \

and instead, used ARCH="$(CHICKEN_ARCH)" here

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot