From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "J. Neuschäfer via buildroot" <buildroot@buildroot.org>
Cc: "J. Neuschäfer" <j.neuschaefer@gmx.net>,
"Yann E. MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v5] Config.in: ban textrels on musl toolchains
Date: Mon, 22 Jul 2024 18:31:57 +0200 [thread overview]
Message-ID: <20240722183157.103992e5@windsurf> (raw)
In-Reply-To: <20240719-ztext-v5-1-ec46696d4ed9@gmx.net>
Hello J,
On Fri, 19 Jul 2024 17:27:19 +0200
J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:
> musl-libc doesn't support TEXTRELs[1] and programs with TEXTRELs will
> crash on start-up under musl.
>
> This patch forbids the use of TEXTRELs on musl toolchains with dynamic
> linking.
>
> To verify this patch:
>
> - Delete package/micropython/0001-py-nlrthumb-Make-non-Thumb2-long-jump-workaround-opt.patch
> - Build micropython (before v1.23) with a musl toolchain and
> BR2_SHARED_LIBS. The build should abort while linking micropython.
>
> [1]: https://www.openwall.com/lists/musl/2020/09/25/4
>
> Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> ---
> Changes in v5:
> - Fix boolean logic (ifeq...)
> - Link to v4: https://lore.kernel.org/r/20240718-ztext-v4-1-15a9744f1edb@gmx.net
Applied to master, thanks. If you could
monitor http://autobuild.buildroot.net/?libc=musl in the next
few days to check for any issue related to this change, it would be
nice. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-07-22 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 15:27 [Buildroot] [PATCH v5] Config.in: ban textrels on musl toolchains J. Neuschäfer via buildroot
2024-07-22 16:31 ` Thomas Petazzoni via buildroot [this message]
2024-07-30 22:03 ` Thomas Petazzoni via buildroot
2024-08-04 22:31 ` J. Neuschäfer via buildroot
2024-08-13 9:09 ` yann.morin
2024-08-23 10:21 ` J. Neuschäfer via buildroot
2024-08-24 19:36 ` J. Neuschäfer via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240722183157.103992e5@windsurf \
--to=buildroot@buildroot.org \
--cc=j.neuschaefer@gmx.net \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox