Re: [Buildroot] [PATCH v5] Config.in: ban textrels on musl toolchains

["J. Neuschäfer via buildroot" <buildroot@buildroot.org>]

On Wed, Jul 31, 2024 at 12:03:59AM +0200, Thomas Petazzoni wrote:
> Hello J,
>
> On Fri, 19 Jul 2024 17:27:19 +0200
> J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:
>
> > +# See also: https://www.openwall.com/lists/musl/2020/09/25/4
> > +ifeq ($(BR2_TOOLCHAIN_USES_MUSL):$(BR2_STATIC_LIBS),y:)
> > +TARGET_LDFLAGS += -Wl,-z,text
> > +endif
>
> Unfortunately, this change is breaking the build of gnu-efi:
>
>   http://autobuild.buildroot.net/results/e3d/e3dec7e0323a3fcb07269b3f9e73becaafeedecd/build-end.log
>
> It seems like gnu-efi uses $(TARGET_LDFLAGS) directly as arguments to
> the linker, not as arguments to gcc-used-as-a-linker, and the linker
> doesn't know about -Wl,-z,-text.

Hm, this is an interesting case, because AFAIU gnu-efi is a bare-metal
library (more or less), so it won't be using the musl ld.so anyway.
So it would be completely reasonable to strip out the -z text here.

> So, either we to "-z text" which I believe is understood by both gcc
> and ld, or we somehow fix gnu-efi.

I think I prefer the first option (with an explanatory comment). I'll
send a patch when I get around to it.


-- jn
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot