* [Buildroot] [PATCH buildroot v2 1/2] package/python-uvicorn: requires PYTHON3_SSL @ 2024-02-05 17:09 ~bubu 2024-02-05 17:25 ` [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test ~bubu 0 siblings, 1 reply; 12+ messages in thread From: ~bubu @ 2024-02-05 17:09 UTC (permalink / raw) To: buildroot; +Cc: James Hilliard, Asaf Kahlon From: Marcus Hoffmann <bubu@bubu1.eu> Uvicorn has a hard requirement on the python ssl module. Without it even running uvicorn --help fails. Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu> --- package/python-uvicorn/Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/package/python-uvicorn/Config.in b/package/python-uvicorn/Config.in index 3e769392f9..c84f54781f 100644 --- a/package/python-uvicorn/Config.in +++ b/package/python-uvicorn/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_PYTHON_UVICORN bool "python-uvicorn" select BR2_PACKAGE_PYTHON_CLICK # runtime select BR2_PACKAGE_PYTHON_H11 # runtime + select BR2_PACKAGE_PYTHON3_SSL # runtime help The lightning-fast ASGI server. -- 2.38.5 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-02-05 17:09 [Buildroot] [PATCH buildroot v2 1/2] package/python-uvicorn: requires PYTHON3_SSL ~bubu @ 2024-02-05 17:25 ` ~bubu 2024-02-05 18:34 ` Marcus Hoffmann via buildroot ` (2 more replies) 0 siblings, 3 replies; 12+ messages in thread From: ~bubu @ 2024-02-05 17:25 UTC (permalink / raw) To: buildroot; +Cc: James Hilliard, Asaf Kahlon From: Marcus Hoffmann <bubu@bubu1.eu> Add a runtime test for fastapi. Use uvicorn as the asgi server application as does the fastapi hello world example [1]. Fastapi depends on PydanticV2 now which is written in rust so we need to run the test on armv7. [1] https://fastapi.tiangolo.com/tutorial/first-steps/ Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu> --- .../tests/package/sample_python_fastapi.py | 8 ++++ .../tests/package/test_python_fastapi.py | 47 +++++++++++++++++++ 2 files changed, 55 insertions(+) create mode 100644 support/testing/tests/package/sample_python_fastapi.py create mode 100644 support/testing/tests/package/test_python_fastapi.py diff --git a/support/testing/tests/package/sample_python_fastapi.py b/support/testing/tests/package/sample_python_fastapi.py new file mode 100644 index 0000000000..3116df3a93 --- /dev/null +++ b/support/testing/tests/package/sample_python_fastapi.py @@ -0,0 +1,8 @@ +from fastapi import FastAPI + +app = FastAPI() + +@app.get("/") +async def root(): + return {"message": "Hello World"} + diff --git a/support/testing/tests/package/test_python_fastapi.py b/support/testing/tests/package/test_python_fastapi.py new file mode 100644 index 0000000000..1a78fa6c58 --- /dev/null +++ b/support/testing/tests/package/test_python_fastapi.py @@ -0,0 +1,47 @@ +import os +import time + +from tests.package.test_python import TestPythonPackageBase + + +class TestPythonPy3Fastapi(TestPythonPackageBase): + __test__ = True + config = \ + """ + BR2_arm=y + BR2_cortex_a9=y + BR2_ARM_ENABLE_NEON=y + BR2_ARM_ENABLE_VFP=y + BR2_TOOLCHAIN_EXTERNAL=y + BR2_PACKAGE_PYTHON3=y + BR2_PACKAGE_PYTHON_FASTAPI=y + BR2_PACKAGE_PYTHON_UVICORN=y + BR2_TARGET_ROOTFS_CPIO=y + # BR2_TARGET_ROOTFS_TAR is not set + BR2_CCACHE=y + BR2_CCACHE_DIR="/home/bubu/.buildroot-ccache" + """ + sample_scripts = ["tests/package/sample_python_fastapi.py"] + timeout = 60 + + def test_run(self): + self.login() + self.check_sample_scripts_exist() + cmd = "uvicorn sample_python_fastapi:app > /dev/null 2>&1 &" + + _, exit_code = self.emulator.run(cmd, timeout=self.timeout) + + # Give enough time for the uvicorn server to start up + time.sleep(30) + + cmd = "wget -q -O - http://127.0.0.1:8000/" + output, exit_code = self.emulator.run(cmd, timeout=self.timeout) + self.assertEqual(exit_code, 0) + self.assertEqual(output[0], '{"message":"Hello World"}') + + def login(self): + cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") + self.emulator.boot(arch="armv7", + kernel="builtin", + options=["-initrd", cpio_file]) + self.emulator.login() -- 2.38.5 _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-02-05 17:25 ` [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test ~bubu @ 2024-02-05 18:34 ` Marcus Hoffmann via buildroot 2024-02-06 12:39 ` Arnout Vandecappelle via buildroot 2024-07-22 12:52 ` Thomas Petazzoni via buildroot 2 siblings, 0 replies; 12+ messages in thread From: Marcus Hoffmann via buildroot @ 2024-02-05 18:34 UTC (permalink / raw) To: buildroot On 05.02.24 18:25, ~bubu wrote: > From: Marcus Hoffmann <bubu@bubu1.eu> > > Add a runtime test for fastapi. Use uvicorn as the asgi server > application as does the fastapi hello world example [1]. > > Fastapi depends on PydanticV2 now which is written in rust so we need to > run the test on armv7. > > [1] https://fastapi.tiangolo.com/tutorial/first-steps/ > > Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu> > --- > .../tests/package/sample_python_fastapi.py | 8 ++++ > .../tests/package/test_python_fastapi.py | 47 +++++++++++++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 support/testing/tests/package/sample_python_fastapi.py > create mode 100644 support/testing/tests/package/test_python_fastapi.py > > diff --git a/support/testing/tests/package/sample_python_fastapi.py b/support/testing/tests/package/sample_python_fastapi.py > new file mode 100644 > index 0000000000..3116df3a93 > --- /dev/null > +++ b/support/testing/tests/package/sample_python_fastapi.py > @@ -0,0 +1,8 @@ > +from fastapi import FastAPI > + > +app = FastAPI() > + > +@app.get("/") > +async def root(): > + return {"message": "Hello World"} > + > diff --git a/support/testing/tests/package/test_python_fastapi.py b/support/testing/tests/package/test_python_fastapi.py > new file mode 100644 > index 0000000000..1a78fa6c58 > --- /dev/null > +++ b/support/testing/tests/package/test_python_fastapi.py > @@ -0,0 +1,47 @@ > +import os > +import time > + > +from tests.package.test_python import TestPythonPackageBase > + > + > +class TestPythonPy3Fastapi(TestPythonPackageBase): > + __test__ = True > + config = \ > + """ > + BR2_arm=y > + BR2_cortex_a9=y > + BR2_ARM_ENABLE_NEON=y > + BR2_ARM_ENABLE_VFP=y > + BR2_TOOLCHAIN_EXTERNAL=y > + BR2_PACKAGE_PYTHON3=y > + BR2_PACKAGE_PYTHON_FASTAPI=y > + BR2_PACKAGE_PYTHON_UVICORN=y > + BR2_TARGET_ROOTFS_CPIO=y > + # BR2_TARGET_ROOTFS_TAR is not set > + BR2_CCACHE=y > + BR2_CCACHE_DIR="/home/bubu/.buildroot-ccache" Oops, I forgot to remove the 2 CCACHE lines before submitting. Don't forget to remove these when applying. :-) > + """ > + sample_scripts = ["tests/package/sample_python_fastapi.py"] > + timeout = 60 > + > + def test_run(self): > + self.login() > + self.check_sample_scripts_exist() > + cmd = "uvicorn sample_python_fastapi:app > /dev/null 2>&1 &" > + > + _, exit_code = self.emulator.run(cmd, timeout=self.timeout) > + > + # Give enough time for the uvicorn server to start up > + time.sleep(30) > + > + cmd = "wget -q -O - http://127.0.0.1:8000/" > + output, exit_code = self.emulator.run(cmd, timeout=self.timeout) > + self.assertEqual(exit_code, 0) > + self.assertEqual(output[0], '{"message":"Hello World"}') > + > + def login(self): > + cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") > + self.emulator.boot(arch="armv7", > + kernel="builtin", > + options=["-initrd", cpio_file]) > + self.emulator.login() _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-02-05 17:25 ` [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test ~bubu 2024-02-05 18:34 ` Marcus Hoffmann via buildroot @ 2024-02-06 12:39 ` Arnout Vandecappelle via buildroot 2024-07-22 12:52 ` Thomas Petazzoni via buildroot 2 siblings, 0 replies; 12+ messages in thread From: Arnout Vandecappelle via buildroot @ 2024-02-06 12:39 UTC (permalink / raw) To: ~bubu, buildroot; +Cc: James Hilliard, Asaf Kahlon On 05/02/2024 18:25, ~bubu wrote: > From: Marcus Hoffmann <bubu@bubu1.eu> > > Add a runtime test for fastapi. Use uvicorn as the asgi server > application as does the fastapi hello world example [1]. > > Fastapi depends on PydanticV2 now which is written in rust so we need to > run the test on armv7. > > [1] https://fastapi.tiangolo.com/tutorial/first-steps/ > > Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu> Both applied to master, but this one with a bunch of modifications: - fix flake8 errors support/testing/tests/package/sample_python_fastapi.py:5:1: E302 expected 2 blank lines, found 1 support/testing/tests/package/sample_python_fastapi.py:8:1: W391 blank line at end of file - Remove BR2_CCACHE (as requested by Marcus). - Add a comment explaining that this also tests uvicorn and pydantic. - Re-try wget in a loop instead of a fixed timeout of 30 seconds. - Add a DEVELOPERS entry. Regards, Arnout > --- > .../tests/package/sample_python_fastapi.py | 8 ++++ > .../tests/package/test_python_fastapi.py | 47 +++++++++++++++++++ > 2 files changed, 55 insertions(+) > create mode 100644 support/testing/tests/package/sample_python_fastapi.py > create mode 100644 support/testing/tests/package/test_python_fastapi.py > > diff --git a/support/testing/tests/package/sample_python_fastapi.py b/support/testing/tests/package/sample_python_fastapi.py > new file mode 100644 > index 0000000000..3116df3a93 > --- /dev/null > +++ b/support/testing/tests/package/sample_python_fastapi.py > @@ -0,0 +1,8 @@ > +from fastapi import FastAPI > + > +app = FastAPI() > + > +@app.get("/") > +async def root(): > + return {"message": "Hello World"} > + > diff --git a/support/testing/tests/package/test_python_fastapi.py b/support/testing/tests/package/test_python_fastapi.py > new file mode 100644 > index 0000000000..1a78fa6c58 > --- /dev/null > +++ b/support/testing/tests/package/test_python_fastapi.py > @@ -0,0 +1,47 @@ > +import os > +import time > + > +from tests.package.test_python import TestPythonPackageBase > + > + > +class TestPythonPy3Fastapi(TestPythonPackageBase): > + __test__ = True > + config = \ > + """ > + BR2_arm=y > + BR2_cortex_a9=y > + BR2_ARM_ENABLE_NEON=y > + BR2_ARM_ENABLE_VFP=y > + BR2_TOOLCHAIN_EXTERNAL=y > + BR2_PACKAGE_PYTHON3=y > + BR2_PACKAGE_PYTHON_FASTAPI=y > + BR2_PACKAGE_PYTHON_UVICORN=y > + BR2_TARGET_ROOTFS_CPIO=y > + # BR2_TARGET_ROOTFS_TAR is not set > + BR2_CCACHE=y > + BR2_CCACHE_DIR="/home/bubu/.buildroot-ccache" > + """ > + sample_scripts = ["tests/package/sample_python_fastapi.py"] > + timeout = 60 > + > + def test_run(self): > + self.login() > + self.check_sample_scripts_exist() > + cmd = "uvicorn sample_python_fastapi:app > /dev/null 2>&1 &" > + > + _, exit_code = self.emulator.run(cmd, timeout=self.timeout) > + > + # Give enough time for the uvicorn server to start up > + time.sleep(30) > + > + cmd = "wget -q -O - http://127.0.0.1:8000/" > + output, exit_code = self.emulator.run(cmd, timeout=self.timeout) > + self.assertEqual(exit_code, 0) > + self.assertEqual(output[0], '{"message":"Hello World"}') > + > + def login(self): > + cpio_file = os.path.join(self.builddir, "images", "rootfs.cpio") > + self.emulator.boot(arch="armv7", > + kernel="builtin", > + options=["-initrd", cpio_file]) > + self.emulator.login() _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-02-05 17:25 ` [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test ~bubu 2024-02-05 18:34 ` Marcus Hoffmann via buildroot 2024-02-06 12:39 ` Arnout Vandecappelle via buildroot @ 2024-07-22 12:52 ` Thomas Petazzoni via buildroot 2024-07-22 14:48 ` Marcus Hoffmann via buildroot 2 siblings, 1 reply; 12+ messages in thread From: Thomas Petazzoni via buildroot @ 2024-07-22 12:52 UTC (permalink / raw) To: ~bubu; +Cc: James Hilliard, Asaf Kahlon, ~bubu, buildroot Hello Marcus, On Mon, 05 Feb 2024 18:25:10 +0100 ~bubu <bubu@git.sr.ht> wrote: > From: Marcus Hoffmann <bubu@bubu1.eu> > > Add a runtime test for fastapi. Use uvicorn as the asgi server > application as does the fastapi hello world example [1]. > > Fastapi depends on PydanticV2 now which is written in rust so we need to > run the test on armv7. > > [1] https://fastapi.tiangolo.com/tutorial/first-steps/ > > Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu> It looks like this test is no longer passing in our CI: https://gitlab.com/buildroot.org/buildroot/-/jobs/7391793123 Could you perhaps have a look? Thanks a lot! Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-07-22 12:52 ` Thomas Petazzoni via buildroot @ 2024-07-22 14:48 ` Marcus Hoffmann via buildroot 2024-07-22 16:06 ` Thomas Petazzoni via buildroot 0 siblings, 1 reply; 12+ messages in thread From: Marcus Hoffmann via buildroot @ 2024-07-22 14:48 UTC (permalink / raw) To: Thomas Petazzoni, ~bubu; +Cc: James Hilliard, ~bubu, Asaf Kahlon, buildroot Hi, On 22.07.24 14:52, Thomas Petazzoni via buildroot wrote: > Hello Marcus, > > On Mon, 05 Feb 2024 18:25:10 +0100 > ~bubu <bubu@git.sr.ht> wrote: > >> From: Marcus Hoffmann <bubu@bubu1.eu> >> >> Add a runtime test for fastapi. Use uvicorn as the asgi server >> application as does the fastapi hello world example [1]. >> >> Fastapi depends on PydanticV2 now which is written in rust so we need to >> run the test on armv7. >> >> [1] https://fastapi.tiangolo.com/tutorial/first-steps/ >> >> Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu> > > It looks like this test is no longer passing in our CI: > > https://gitlab.com/buildroot.org/buildroot/-/jobs/7391793123 > > Could you perhaps have a look? This is caused by our pydantic-core install apparently being broken: File "/root/sample_python_fastapi.py", line 1, in <module> from fastapi import FastAPI File "/usr/lib/python3.12/site-packages/fastapi/__init__.py", line 7, in <module> File "/usr/lib/python3.12/site-packages/fastapi/applications.py", line 16, in <module> File "/usr/lib/python3.12/site-packages/fastapi/routing.py", line 22, in <module> File "/usr/lib/python3.12/site-packages/fastapi/params.py", line 5, in <module> File "/usr/lib/python3.12/site-packages/fastapi/openapi/models.py", line 4, in <module> File "/usr/lib/python3.12/site-packages/fastapi/_compat.py", line 20, in <module> File "/usr/lib/python3.12/site-packages/fastapi/exceptions.py", line 3, in <module> File "/usr/lib/python3.12/site-packages/pydantic/__init__.py", line 404, in __getattr__ File "/usr/lib/python3.12/importlib/__init__.py", line 90, in import_module File "/usr/lib/python3.12/site-packages/pydantic/main.py", line 29, in <module> ImportError: cannot import name 'PydanticUndefined' from 'pydantic_core' (unknown location) People have hit that here through conda forge as well: https://github.com/pydantic/pydantic/issues/8429 James, can you take a look maybe? (We still use pydantic-v1, so I don't really have any idea about pydantic rust core build topics. Marcus > > Thanks a lot! > > Thomas _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-07-22 14:48 ` Marcus Hoffmann via buildroot @ 2024-07-22 16:06 ` Thomas Petazzoni via buildroot 2024-07-22 16:11 ` James Hilliard 0 siblings, 1 reply; 12+ messages in thread From: Thomas Petazzoni via buildroot @ 2024-07-22 16:06 UTC (permalink / raw) To: Marcus Hoffmann; +Cc: James Hilliard, ~bubu, ~bubu, Asaf Kahlon, buildroot On Mon, 22 Jul 2024 16:48:08 +0200 Marcus Hoffmann <buildroot@bubu1.eu> wrote: > People have hit that here through conda forge as well: > https://github.com/pydantic/pydantic/issues/8429 > > James, can you take a look maybe? (We still use pydantic-v1, so I don't > really have any idea about pydantic rust core build topics. We have some updates to pydantic-core/pydantic pending: https://patchwork.ozlabs.org/project/buildroot/patch/20240719043739.3241372-1-james.hilliard1@gmail.com/ https://patchwork.ozlabs.org/project/buildroot/patch/20240719042632.3227242-1-james.hilliard1@gmail.com/ (I was about to merge them) Not sure if they are related / solve the issue? Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-07-22 16:06 ` Thomas Petazzoni via buildroot @ 2024-07-22 16:11 ` James Hilliard 2024-07-22 16:38 ` Thomas Petazzoni via buildroot 0 siblings, 1 reply; 12+ messages in thread From: James Hilliard @ 2024-07-22 16:11 UTC (permalink / raw) To: Thomas Petazzoni; +Cc: ~bubu, ~bubu, Marcus Hoffmann, Asaf Kahlon, buildroot On Mon, Jul 22, 2024 at 10:06 AM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Mon, 22 Jul 2024 16:48:08 +0200 > Marcus Hoffmann <buildroot@bubu1.eu> wrote: > > > People have hit that here through conda forge as well: > > https://github.com/pydantic/pydantic/issues/8429 > > > > James, can you take a look maybe? (We still use pydantic-v1, so I don't > > really have any idea about pydantic rust core build topics. > > We have some updates to pydantic-core/pydantic pending: > > https://patchwork.ozlabs.org/project/buildroot/patch/20240719043739.3241372-1-james.hilliard1@gmail.com/ > https://patchwork.ozlabs.org/project/buildroot/patch/20240719042632.3227242-1-james.hilliard1@gmail.com/ > > (I was about to merge them) > > Not sure if they are related / solve the issue? These setuptools/setuptools-rust/maturin patches might also help: https://patchwork.ozlabs.org/project/buildroot/patch/20240719045639.3336541-1-james.hilliard1@gmail.com/ https://patchwork.ozlabs.org/project/buildroot/patch/20240719050134.3338117-1-james.hilliard1@gmail.com/ https://patchwork.ozlabs.org/project/buildroot/patch/20240719052700.3427830-1-james.hilliard1@gmail.com/ > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-07-22 16:11 ` James Hilliard @ 2024-07-22 16:38 ` Thomas Petazzoni via buildroot 2024-07-22 17:21 ` James Hilliard 0 siblings, 1 reply; 12+ messages in thread From: Thomas Petazzoni via buildroot @ 2024-07-22 16:38 UTC (permalink / raw) To: James Hilliard; +Cc: ~bubu, ~bubu, Marcus Hoffmann, Asaf Kahlon, buildroot On Mon, 22 Jul 2024 10:11:31 -0600 James Hilliard <james.hilliard1@gmail.com> wrote: > > We have some updates to pydantic-core/pydantic pending: > > > > https://patchwork.ozlabs.org/project/buildroot/patch/20240719043739.3241372-1-james.hilliard1@gmail.com/ > > https://patchwork.ozlabs.org/project/buildroot/patch/20240719042632.3227242-1-james.hilliard1@gmail.com/ > > > > (I was about to merge them) > > > > Not sure if they are related / solve the issue? > > These setuptools/setuptools-rust/maturin patches might also help: > https://patchwork.ozlabs.org/project/buildroot/patch/20240719045639.3336541-1-james.hilliard1@gmail.com/ > https://patchwork.ozlabs.org/project/buildroot/patch/20240719050134.3338117-1-james.hilliard1@gmail.com/ > https://patchwork.ozlabs.org/project/buildroot/patch/20240719052700.3427830-1-james.hilliard1@gmail.com/ I applied them. But could we have some better answer than "might also help"? Like actually testing which thing is fixing what? Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-07-22 16:38 ` Thomas Petazzoni via buildroot @ 2024-07-22 17:21 ` James Hilliard 2024-07-23 10:21 ` Marcus Hoffmann via buildroot 0 siblings, 1 reply; 12+ messages in thread From: James Hilliard @ 2024-07-22 17:21 UTC (permalink / raw) To: Thomas Petazzoni; +Cc: ~bubu, ~bubu, Marcus Hoffmann, Asaf Kahlon, buildroot On Mon, Jul 22, 2024 at 10:38 AM Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > On Mon, 22 Jul 2024 10:11:31 -0600 > James Hilliard <james.hilliard1@gmail.com> wrote: > > > > We have some updates to pydantic-core/pydantic pending: > > > > > > https://patchwork.ozlabs.org/project/buildroot/patch/20240719043739.3241372-1-james.hilliard1@gmail.com/ > > > https://patchwork.ozlabs.org/project/buildroot/patch/20240719042632.3227242-1-james.hilliard1@gmail.com/ > > > > > > (I was about to merge them) > > > > > > Not sure if they are related / solve the issue? > > > > These setuptools/setuptools-rust/maturin patches might also help: > > https://patchwork.ozlabs.org/project/buildroot/patch/20240719045639.3336541-1-james.hilliard1@gmail.com/ > > https://patchwork.ozlabs.org/project/buildroot/patch/20240719050134.3338117-1-james.hilliard1@gmail.com/ > > https://patchwork.ozlabs.org/project/buildroot/patch/20240719052700.3427830-1-james.hilliard1@gmail.com/ > > I applied them. But could we have some better answer than "might also > help"? Like actually testing which thing is fixing what? Well...those are all in the build dependency tree for pydantic-core, so I if there was something there that needed to be updated was thinking that might help. > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-07-22 17:21 ` James Hilliard @ 2024-07-23 10:21 ` Marcus Hoffmann via buildroot 2024-07-23 15:12 ` James Hilliard 0 siblings, 1 reply; 12+ messages in thread From: Marcus Hoffmann via buildroot @ 2024-07-23 10:21 UTC (permalink / raw) To: James Hilliard, Thomas Petazzoni; +Cc: ~bubu, Asaf Kahlon, ~bubu, buildroot Hi, On 22.07.24 19:21, James Hilliard wrote: > On Mon, Jul 22, 2024 at 10:38 AM Thomas Petazzoni > <thomas.petazzoni@bootlin.com> wrote: >> >> On Mon, 22 Jul 2024 10:11:31 -0600 >> James Hilliard <james.hilliard1@gmail.com> wrote: >> >>>> We have some updates to pydantic-core/pydantic pending: >>>> >>>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719043739.3241372-1-james.hilliard1@gmail.com/ >>>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719042632.3227242-1-james.hilliard1@gmail.com/ >>>> >>>> (I was about to merge them) >>>> >>>> Not sure if they are related / solve the issue? >>> >>> These setuptools/setuptools-rust/maturin patches might also help: >>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719045639.3336541-1-james.hilliard1@gmail.com/ >>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719050134.3338117-1-james.hilliard1@gmail.com/ >>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719052700.3427830-1-james.hilliard1@gmail.com/ >> >> I applied them. But could we have some better answer than "might also >> help"? Like actually testing which thing is fixing what? > > Well...those are all in the build dependency tree for pydantic-core, so > I if there was something there that needed to be updated was thinking that > might help. It's still failing after all the bumps but reverting a14c862c08865e053d5fce90a0d0323b8f9e4bc0 "Create a .gitignore file in the CANONICAL_O directory" fixes it. Found a hint here https://github.com/conda-forge/pydantic-core-feedstock/pull/82/commits/f5c0909c79dff356c552b6dacf9dd62a62013c6a#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR17-R20 And also someone sent a mail to the list today complaining about a similar problem. So the culprit seems to be https://github.com/PyO3/maturin/issues/1911 Marcus > >> >> Thomas >> -- >> Thomas Petazzoni, co-owner and CEO, Bootlin >> Embedded Linux and Kernel engineering and training >> https://bootlin.com > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test 2024-07-23 10:21 ` Marcus Hoffmann via buildroot @ 2024-07-23 15:12 ` James Hilliard 0 siblings, 0 replies; 12+ messages in thread From: James Hilliard @ 2024-07-23 15:12 UTC (permalink / raw) To: Marcus Hoffmann; +Cc: Asaf Kahlon, ~bubu, ~bubu, Thomas Petazzoni, buildroot On Tue, Jul 23, 2024 at 4:21 AM Marcus Hoffmann <buildroot@bubu1.eu> wrote: > > Hi, > > On 22.07.24 19:21, James Hilliard wrote: > > On Mon, Jul 22, 2024 at 10:38 AM Thomas Petazzoni > > <thomas.petazzoni@bootlin.com> wrote: > >> > >> On Mon, 22 Jul 2024 10:11:31 -0600 > >> James Hilliard <james.hilliard1@gmail.com> wrote: > >> > >>>> We have some updates to pydantic-core/pydantic pending: > >>>> > >>>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719043739.3241372-1-james.hilliard1@gmail.com/ > >>>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719042632.3227242-1-james.hilliard1@gmail.com/ > >>>> > >>>> (I was about to merge them) > >>>> > >>>> Not sure if they are related / solve the issue? > >>> > >>> These setuptools/setuptools-rust/maturin patches might also help: > >>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719045639.3336541-1-james.hilliard1@gmail.com/ > >>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719050134.3338117-1-james.hilliard1@gmail.com/ > >>> https://patchwork.ozlabs.org/project/buildroot/patch/20240719052700.3427830-1-james.hilliard1@gmail.com/ > >> > >> I applied them. But could we have some better answer than "might also > >> help"? Like actually testing which thing is fixing what? > > > > Well...those are all in the build dependency tree for pydantic-core, so > > I if there was something there that needed to be updated was thinking that > > might help. > > It's still failing after all the bumps but reverting > a14c862c08865e053d5fce90a0d0323b8f9e4bc0 > "Create a .gitignore file in the CANONICAL_O directory" fixes it. > > Found a hint here > https://github.com/conda-forge/pydantic-core-feedstock/pull/82/commits/f5c0909c79dff356c552b6dacf9dd62a62013c6a#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9aR17-R20 > > And also someone sent a mail to the list today complaining about a > similar problem. > > So the culprit seems to be https://github.com/PyO3/maturin/issues/1911 Hmm, so thinking this is maybe a similar issue to this poetry bug I had fixed a while back: https://github.com/python-poetry/poetry-core/pull/611 > > Marcus > > > > >> > >> Thomas > >> -- > >> Thomas Petazzoni, co-owner and CEO, Bootlin > >> Embedded Linux and Kernel engineering and training > >> https://bootlin.com > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-07-23 15:12 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-02-05 17:09 [Buildroot] [PATCH buildroot v2 1/2] package/python-uvicorn: requires PYTHON3_SSL ~bubu 2024-02-05 17:25 ` [Buildroot] [PATCH buildroot v2 2/2] support/testing: add fastapi runtime test ~bubu 2024-02-05 18:34 ` Marcus Hoffmann via buildroot 2024-02-06 12:39 ` Arnout Vandecappelle via buildroot 2024-07-22 12:52 ` Thomas Petazzoni via buildroot 2024-07-22 14:48 ` Marcus Hoffmann via buildroot 2024-07-22 16:06 ` Thomas Petazzoni via buildroot 2024-07-22 16:11 ` James Hilliard 2024-07-22 16:38 ` Thomas Petazzoni via buildroot 2024-07-22 17:21 ` James Hilliard 2024-07-23 10:21 ` Marcus Hoffmann via buildroot 2024-07-23 15:12 ` James Hilliard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox