[Buildroot] [PATCH 1/1] package/speex: ARM5E needs ARM mode

[Buildroot] [PATCH 1/1] package/speex: ARM5E needs ARM mode

[Fabrice Fontaine]

Add a dependency on ARM mode for ARM5E to fix the following build
failure on arm926ej-s which only supports Thumb2 mode:

/tmp/ccJHSu7y.s:158: Error: selected processor does not support `smulbb r1,r6,lr' in Thumb mode

Fixes:
 - http://autobuild.buildroot.org/results/1575da3a8ea2bcde7fa9885df317a12d5c36918f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/speex/Config.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/speex/Config.in b/package/speex/Config.in
index c4e3df5dcd..134e6e4b35 100644
--- a/package/speex/Config.in
+++ b/package/speex/Config.in
@@ -18,6 +18,7 @@ config BR2_PACKAGE_SPEEX_ARM4
 config BR2_PACKAGE_SPEEX_ARM5E
 	bool
 	default y
-	depends on BR2_arm && !BR2_PACKAGE_SPEEX_ARM4
+	depends on BR2_arm && BR2_ARM_CPU_HAS_ARM && \
+		!BR2_PACKAGE_SPEEX_ARM4
 
 endif
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/speex: ARM5E needs ARM mode

[Thomas Petazzoni via buildroot]

Hello Fabrice,

On Tue, 23 Jul 2024 17:30:35 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Add a dependency on ARM mode for ARM5E to fix the following build
> failure on arm926ej-s which only supports Thumb2 mode:

This cannot be true, because ARM926EJ-S does not support Thumb2 at all.
ARM926EJ-S supports only the ARM instruction set and the classic Thumb
instruction set.

Thumb 2 was introduced in ARM1156, which is an ARMv6 core.

I'm not sure what you're pointing to ARM926EJ-S this the failing
configuration at:

> Fixes:
>  - http://autobuild.buildroot.org/results/1575da3a8ea2bcde7fa9885df317a12d5c36918f

This configuration builds for Cortex-M3, which only supports the Thumb2
instruction set if I understand correctly.

> @@ -18,6 +18,7 @@ config BR2_PACKAGE_SPEEX_ARM4
>  config BR2_PACKAGE_SPEEX_ARM5E
>  	bool
>  	default y
> -	depends on BR2_arm && !BR2_PACKAGE_SPEEX_ARM4
> +	depends on BR2_arm && BR2_ARM_CPU_HAS_ARM && \
> +		!BR2_PACKAGE_SPEEX_ARM4

So I do believe this change is correct, just the explanation in the
commit log isn't.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot