Re: [Buildroot] [PATCH 1/2] package/rpi-utils: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Gaël,

On Tue, 23 Jul 2024 23:20:10 +0200
"Gaël PORTAY" <gael.portay@gmail.com> wrote:

> The package rpi-userland has been marked as ancient and deprecated[1].
> 
> The useful tools (dtoverlay, dtmerge, vcmailbox, vcgencmd) were moved to
> the repository rpi-utils since then.
> 
> This adds the new package rpi-utils at latest commit as there is no
> tagged commit.
> 
> [1]: https://github.com/raspberrypi/userland/commit/96a7334ae9d5fc9db7ac92e59852377df63f1848
> 
> Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>

Thanks for the patch. See some comments below.

> ---
>  package/rpi-utils/Config.in      |  9 +++++++++
>  package/rpi-utils/rpi-utils.hash |  3 +++
>  package/rpi-utils/rpi-utils.mk   | 16 ++++++++++++++++
>  3 files changed, 28 insertions(+)

Please add an entry in the DEVELOPERS file for this new package.

>  create mode 100644 package/rpi-utils/Config.in
>  create mode 100644 package/rpi-utils/rpi-utils.hash
>  create mode 100644 package/rpi-utils/rpi-utils.mk
> 
> diff --git a/package/rpi-utils/Config.in b/package/rpi-utils/Config.in
> new file mode 100644
> index 0000000000..4ae82257a0
> --- /dev/null
> +++ b/package/rpi-utils/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_RPI_UTILS
> +	bool "rpi-utils"
> +	depends on !BR2_STATIC_LIBS # dtc
> +	select BR2_PACKAGE_DTC
> +	help
> +	  A collection of scripts and simple applications for the
> +	  Raspberry Pi.
> +
> +	  https://github.com/raspberrypi/utils/

Please add a Config.in comment:

comment "rpi-utils needs a toolchain w/ dynamic library"
	depends on BR2_STATIC_LIBS

also, this Config.in file is not included anywhere, so things cannot
work.


> diff --git a/package/rpi-utils/rpi-utils.mk b/package/rpi-utils/rpi-utils.mk
> new file mode 100644
> index 0000000000..1c74951e4a
> --- /dev/null
> +++ b/package/rpi-utils/rpi-utils.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# rpi-utils
> +#
> +################################################################################
> +
> +RPI_UTILS_VERSION = a1d522f0f1b50858a44fac80523a2bd80098e789
> +RPI_UTILS_SITE = $(call github,raspberrypi,utils,$(RPI_UTILS_VERSION))
> +RPI_UTILS_LICENSE = BSD-3-Clause
> +RPI_UTILS_LICENSE_FILES = LICENCE
> +RPI_UTILS_INSTALL_STAGING = YES
> +RPI_UTILS_DEPENDENCIES = dtc
> +
> +RPI_UTILS_CONF_OPTS = -DSTATIC=STATIC

What is this thing doing? It seems a bit odd.

Also, could you give a test to this package using the ./utils/test-pkg
utility?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot