[Buildroot] [PATCH 1/1] libpwquality: fix PAM module path

[Buildroot] [PATCH 1/1] libpwquality: fix PAM module path

[Danomi Manchego]

The libpwquality package provides the pam_pwquality PAM module - the
replacement for pam_cracklib that was dropped from linux-pam back in
version 1.5.0.  However, it currently installs it to the wrong place,
so passwd and friends fail to find it.  This commit sets the security
directory path to /lib/security to match the corresponding setting in
linux-pam.mk.

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/libpwquality/libpwquality.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/libpwquality/libpwquality.mk b/package/libpwquality/libpwquality.mk
index f12e583b2d..ba62cdfb09 100644
--- a/package/libpwquality/libpwquality.mk
+++ b/package/libpwquality/libpwquality.mk
@@ -23,7 +23,7 @@ LIBPWQUALITY_CONF_OPTS += --disable-python-bindings
 endif
 
 ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
-LIBPWQUALITY_CONF_OPTS += --enable-pam
+LIBPWQUALITY_CONF_OPTS += --enable-pam --with-securedir=/lib/security
 LIBPWQUALITY_DEPENDENCIES += linux-pam
 else
 LIBPWQUALITY_CONF_OPTS += --disable-pam
-- 
2.17.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] libpwquality: fix PAM module path

[Thomas Petazzoni via buildroot]

On Thu, 25 Jul 2024 22:55:39 -0400
Danomi Manchego <danomimanchego123@gmail.com> wrote:

> The libpwquality package provides the pam_pwquality PAM module - the
> replacement for pam_cracklib that was dropped from linux-pam back in
> version 1.5.0.  However, it currently installs it to the wrong place,
> so passwd and friends fail to find it.  This commit sets the security
> directory path to /lib/security to match the corresponding setting in
> linux-pam.mk.
> 
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
>  package/libpwquality/libpwquality.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the fix! Could you indicate more clearly in the commit log
which Buildroot commit caused the regression? Is it the bump of
linux-pam to >= 1.5.0 which happened in
276f1e0a896698abec85500a86686bf72c79eb91 ? At the time, was
libpwquality already providing a replacement PAM module ? If not, when
did libpwquality introduced this PAM module ?

Indeed, libpwquality had this optional dependency on linux-pam since
the package was added in 462040443ca943694fc59ec8380c82f8bf9aaddc, back
in 2017.

The whole reason why I'm asking for this additional detail is to
understand whether or not this patch needs to be backported to our LTS
branch, and therefore instead of just "fixing a problem" we need to
understand since when the problem started to exist.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot