Re: [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Thu,  1 Aug 2024 17:34:30 +0200
Philip-Dylan Gleonec <philip-dylan@gleonec.bzh> wrote:

> Philip-Dylan Gleonec (2):
>   configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
>   configs/mx6sx_udoo_neo_defconfig: add hashes

Thanks, both patches applied! A couple of small comments to improve
your future contributions:

- In the first patch, I added a short extract of the kernel build error
  being fixed, and also a link to the Gitlab CI failure being fixed by
  this. See the final commit
  at https://gitlab.com/buildroot.org/buildroot/-/commit/44b921f605dffd07bb6294e6368c2ace34a08266

- In the commit title, we normally use "configs/foo:" instead of
  "configs/foo_defconfig:". No strong reason, just a habit, and we like
  to be consistent.

- The wrapping/paragraph organization of your commit messages was a bit
  strange and not really consistent with what is done in Buildroot, but
  also in the kernel. Basically you tend to do:

Some explanation here.
Then some more explanation that might
span multiple
lines.
Then another explanations.

  While in most projects, including Buildroot, we expect:

Some explanation here.

Then some more explanation that might span
multiple lines.

Then another paragraph about something else.

- If you do have this board, it would be nice to add yourself for this
  defconfig, and its data file in board/ in the DEVELOPERS file. This
  way you will receive notifications when the build of this defconfig
  is broken, or when someone submits a patch touching this defconfig.

Thanks a lot!

Thomas

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot