* [Buildroot] [PATCH 0/2] Udoo Neo kernel update
@ 2024-07-31 14:55 Philip-Dylan Gleonec
2024-07-31 14:55 ` [Buildroot] [PATCH 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43 Philip-Dylan Gleonec
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Philip-Dylan Gleonec @ 2024-07-31 14:55 UTC (permalink / raw)
To: buildroot; +Cc: Fabio Estevam, Philip-Dylan Gleonec
Hello,
I'm currently playing with the Udoo Neo board and have found that the
kernel in the current board configuration does not build.
While a point release bump would be sufficient, I took the opportunity
to update the kernel to the latest LTS version. Hashes verification was
added to ensure the integrity of uboot and linux sources.
The 6.6 kernel does not add any regression compared to the latest 5.15
kernel.
Thanks for your time,
Philip-Dylan Gleonec
Philip-Dylan Gleonec (2):
configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
configs/mx6sx_udoo_neo_defconfig: add hashes
.checkpackageignore | 1 -
.../udoo/neo/patches/linux-headers/linux-headers.hash | 1 +
board/udoo/neo/patches/linux/linux.hash | 2 ++
board/udoo/neo/patches/uboot/uboot.hash | 2 ++
configs/mx6sx_udoo_neo_defconfig | 10 ++++++----
5 files changed, 11 insertions(+), 5 deletions(-)
create mode 120000 board/udoo/neo/patches/linux-headers/linux-headers.hash
create mode 100644 board/udoo/neo/patches/linux/linux.hash
create mode 100644 board/udoo/neo/patches/uboot/uboot.hash
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 12+ messages in thread* [Buildroot] [PATCH 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
2024-07-31 14:55 [Buildroot] [PATCH 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
@ 2024-07-31 14:55 ` Philip-Dylan Gleonec
2024-07-31 14:55 ` [Buildroot] [PATCH 2/2] configs/mx6sx_udoo_neo_defconfig: add hashes Philip-Dylan Gleonec
2024-08-01 15:34 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
2 siblings, 0 replies; 12+ messages in thread
From: Philip-Dylan Gleonec @ 2024-07-31 14:55 UTC (permalink / raw)
To: buildroot; +Cc: Fabio Estevam, Philip-Dylan Gleonec
The current 5.15.13 kernel fails to build.
This commit fixes this by using the opportunity to bump the kernel to
the latest LTS version.
While bumping the kernel, the headers to use are also updated, and the
selected device trees are updated to use the new dts per vendor
organization.
This update does not introduce any new error or warning with the
current configuration.
Signed-off-by: Philip-Dylan Gleonec <philip-dylan@gleonec.bzh>
---
configs/mx6sx_udoo_neo_defconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/configs/mx6sx_udoo_neo_defconfig b/configs/mx6sx_udoo_neo_defconfig
index 793d992ce7..71a7473307 100644
--- a/configs/mx6sx_udoo_neo_defconfig
+++ b/configs/mx6sx_udoo_neo_defconfig
@@ -3,8 +3,8 @@ BR2_cortex_a9=y
BR2_ARM_ENABLE_NEON=y
BR2_ARM_ENABLE_VFP=y
BR2_ARM_FPU_VFPV3=y
-# Linux headers same as kernel, a 5.15 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
+# Linux headers same as kernel, a 6.6 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/udoo/common/post-build.sh"
BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh"
BR2_TARGET_ROOTFS_EXT2=y
@@ -19,10 +19,10 @@ BR2_TARGET_UBOOT_SPL=y
BR2_TARGET_UBOOT_SPL_NAME="SPL"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.13"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.6.43"
BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6sx-udoo-neo-basic imx6sx-udoo-neo-full imx6sx-udoo-neo-extended"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="nxp/imx/imx6sx-udoo-neo-basic nxp/imx/imx6sx-udoo-neo-full nxp/imx/imx6sx-udoo-neo-extended"
BR2_LINUX_KERNEL_INSTALL_TARGET=y
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
# required tools to create the SD card image
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/2] configs/mx6sx_udoo_neo_defconfig: add hashes
2024-07-31 14:55 [Buildroot] [PATCH 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
2024-07-31 14:55 ` [Buildroot] [PATCH 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43 Philip-Dylan Gleonec
@ 2024-07-31 14:55 ` Philip-Dylan Gleonec
2024-07-31 17:01 ` Fabio Estevam
2024-08-01 15:34 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
2 siblings, 1 reply; 12+ messages in thread
From: Philip-Dylan Gleonec @ 2024-07-31 14:55 UTC (permalink / raw)
To: buildroot; +Cc: Fabio Estevam, Philip-Dylan Gleonec
Add hashes for uboot and linux, and enable
BR2_DOWNLOAD_FORCE_CHECK_HASHES.
Modify .checkpackageignore to enable the hash check for the Udoo Neo
config.
Signed-off-by: Philip-Dylan Gleonec <philip-dylan@gleonec.bzh>
---
.checkpackageignore | 1 -
| 1 +
board/udoo/neo/patches/linux/linux.hash | 2 ++
board/udoo/neo/patches/uboot/uboot.hash | 2 ++
configs/mx6sx_udoo_neo_defconfig | 2 ++
5 files changed, 7 insertions(+), 1 deletion(-)
create mode 120000 board/udoo/neo/patches/linux-headers/linux-headers.hash
create mode 100644 board/udoo/neo/patches/linux/linux.hash
create mode 100644 board/udoo/neo/patches/uboot/uboot.hash
diff --git a/.checkpackageignore b/.checkpackageignore
index 028b63b4d3..fe5d2618c6 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -202,7 +202,6 @@ configs/microchip_sama7g5ek_mmc_dev_defconfig lib_defconfig.ForceCheckHash
configs/minnowboard_max_defconfig lib_defconfig.ForceCheckHash
configs/mx25pdk_defconfig lib_defconfig.ForceCheckHash
configs/mx53loco_defconfig lib_defconfig.ForceCheckHash
-configs/mx6sx_udoo_neo_defconfig lib_defconfig.ForceCheckHash
configs/mx6udoo_defconfig lib_defconfig.ForceCheckHash
configs/nexbox_a95x_defconfig lib_defconfig.ForceCheckHash
configs/nitrogen6sx_defconfig lib_defconfig.ForceCheckHash
--git a/board/udoo/neo/patches/linux-headers/linux-headers.hash b/board/udoo/neo/patches/linux-headers/linux-headers.hash
new file mode 120000
index 0000000000..5808d92afe
--- /dev/null
+++ b/board/udoo/neo/patches/linux-headers/linux-headers.hash
@@ -0,0 +1 @@
+../linux/linux.hash
\ No newline at end of file
diff --git a/board/udoo/neo/patches/linux/linux.hash b/board/udoo/neo/patches/linux/linux.hash
new file mode 100644
index 0000000000..68677589fe
--- /dev/null
+++ b/board/udoo/neo/patches/linux/linux.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 5c3a3c03c055b8d601a6d7f80d1465ada6b83a12299f6ace2027b47f0baff538 linux-6.6.40.tar.xz
diff --git a/board/udoo/neo/patches/uboot/uboot.hash b/board/udoo/neo/patches/uboot/uboot.hash
new file mode 100644
index 0000000000..0bfbf306ff
--- /dev/null
+++ b/board/udoo/neo/patches/uboot/uboot.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 81b4543227db228c03f8a1bf5ddbc813b0bb8f6555ce46064ef721a6fc680413 u-boot-2022.01.tar.bz2
diff --git a/configs/mx6sx_udoo_neo_defconfig b/configs/mx6sx_udoo_neo_defconfig
index 71a7473307..adcd7aeb4e 100644
--- a/configs/mx6sx_udoo_neo_defconfig
+++ b/configs/mx6sx_udoo_neo_defconfig
@@ -1,5 +1,7 @@
BR2_arm=y
BR2_cortex_a9=y
+BR2_GLOBAL_PATCH_DIR="board/udoo/neo/patches"
+BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ARM_ENABLE_NEON=y
BR2_ARM_ENABLE_VFP=y
BR2_ARM_FPU_VFPV3=y
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update
2024-07-31 14:55 [Buildroot] [PATCH 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
2024-07-31 14:55 ` [Buildroot] [PATCH 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43 Philip-Dylan Gleonec
2024-07-31 14:55 ` [Buildroot] [PATCH 2/2] configs/mx6sx_udoo_neo_defconfig: add hashes Philip-Dylan Gleonec
@ 2024-08-01 15:34 ` Philip-Dylan Gleonec
2024-08-01 15:34 ` [Buildroot] [PATCH v2 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43 Philip-Dylan Gleonec
` (2 more replies)
2 siblings, 3 replies; 12+ messages in thread
From: Philip-Dylan Gleonec @ 2024-08-01 15:34 UTC (permalink / raw)
To: buildroot; +Cc: Fabio Estevam, Philip-Dylan Gleonec
Hello,
Please find attached the corrected patchet for the Udoo Neo kernel
update.
This fixes the linux hash to use the correct version.
Best regards,
Philip-Dylan Gleonec
Philip-Dylan Gleonec (2):
configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
configs/mx6sx_udoo_neo_defconfig: add hashes
.checkpackageignore | 1 -
.../udoo/neo/patches/linux-headers/linux-headers.hash | 1 +
board/udoo/neo/patches/linux/linux.hash | 2 ++
board/udoo/neo/patches/uboot/uboot.hash | 2 ++
configs/mx6sx_udoo_neo_defconfig | 10 ++++++----
5 files changed, 11 insertions(+), 5 deletions(-)
create mode 120000 board/udoo/neo/patches/linux-headers/linux-headers.hash
create mode 100644 board/udoo/neo/patches/linux/linux.hash
create mode 100644 board/udoo/neo/patches/uboot/uboot.hash
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 12+ messages in thread* [Buildroot] [PATCH v2 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
2024-08-01 15:34 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
@ 2024-08-01 15:34 ` Philip-Dylan Gleonec
2024-08-01 15:34 ` [Buildroot] [PATCH v2 2/2] configs/mx6sx_udoo_neo_defconfig: add hashes Philip-Dylan Gleonec
2024-08-01 21:20 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Thomas Petazzoni via buildroot
2 siblings, 0 replies; 12+ messages in thread
From: Philip-Dylan Gleonec @ 2024-08-01 15:34 UTC (permalink / raw)
To: buildroot; +Cc: Fabio Estevam, Philip-Dylan Gleonec
The current 5.15.13 kernel fails to build.
This commit fixes this by using the opportunity to bump the kernel to
the latest LTS version.
While bumping the kernel, the headers to use are also updated, and the
selected device trees are updated to use the new dts per vendor
organization.
This update does not introduce any new error or warning with the
current configuration.
Signed-off-by: Philip-Dylan Gleonec <philip-dylan@gleonec.bzh>
---
configs/mx6sx_udoo_neo_defconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/configs/mx6sx_udoo_neo_defconfig b/configs/mx6sx_udoo_neo_defconfig
index 793d992ce7..71a7473307 100644
--- a/configs/mx6sx_udoo_neo_defconfig
+++ b/configs/mx6sx_udoo_neo_defconfig
@@ -3,8 +3,8 @@ BR2_cortex_a9=y
BR2_ARM_ENABLE_NEON=y
BR2_ARM_ENABLE_VFP=y
BR2_ARM_FPU_VFPV3=y
-# Linux headers same as kernel, a 5.15 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
+# Linux headers same as kernel, a 6.6 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
BR2_ROOTFS_POST_BUILD_SCRIPT="board/udoo/common/post-build.sh"
BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh"
BR2_TARGET_ROOTFS_EXT2=y
@@ -19,10 +19,10 @@ BR2_TARGET_UBOOT_SPL=y
BR2_TARGET_UBOOT_SPL_NAME="SPL"
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.13"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.6.43"
BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6sx-udoo-neo-basic imx6sx-udoo-neo-full imx6sx-udoo-neo-extended"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="nxp/imx/imx6sx-udoo-neo-basic nxp/imx/imx6sx-udoo-neo-full nxp/imx/imx6sx-udoo-neo-extended"
BR2_LINUX_KERNEL_INSTALL_TARGET=y
BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
# required tools to create the SD card image
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v2 2/2] configs/mx6sx_udoo_neo_defconfig: add hashes
2024-08-01 15:34 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
2024-08-01 15:34 ` [Buildroot] [PATCH v2 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43 Philip-Dylan Gleonec
@ 2024-08-01 15:34 ` Philip-Dylan Gleonec
2024-08-01 21:20 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Thomas Petazzoni via buildroot
2 siblings, 0 replies; 12+ messages in thread
From: Philip-Dylan Gleonec @ 2024-08-01 15:34 UTC (permalink / raw)
To: buildroot; +Cc: Fabio Estevam, Philip-Dylan Gleonec
Add hashes for uboot and linux, and enable
BR2_DOWNLOAD_FORCE_CHECK_HASHES.
Modify .checkpackageignore to enable the hash check for the Udoo Neo
config.
Signed-off-by: Philip-Dylan Gleonec <philip-dylan@gleonec.bzh>
---
.checkpackageignore | 1 -
| 1 +
board/udoo/neo/patches/linux/linux.hash | 2 ++
board/udoo/neo/patches/uboot/uboot.hash | 2 ++
configs/mx6sx_udoo_neo_defconfig | 2 ++
5 files changed, 7 insertions(+), 1 deletion(-)
create mode 120000 board/udoo/neo/patches/linux-headers/linux-headers.hash
create mode 100644 board/udoo/neo/patches/linux/linux.hash
create mode 100644 board/udoo/neo/patches/uboot/uboot.hash
diff --git a/.checkpackageignore b/.checkpackageignore
index 028b63b4d3..fe5d2618c6 100644
--- a/.checkpackageignore
+++ b/.checkpackageignore
@@ -202,7 +202,6 @@ configs/microchip_sama7g5ek_mmc_dev_defconfig lib_defconfig.ForceCheckHash
configs/minnowboard_max_defconfig lib_defconfig.ForceCheckHash
configs/mx25pdk_defconfig lib_defconfig.ForceCheckHash
configs/mx53loco_defconfig lib_defconfig.ForceCheckHash
-configs/mx6sx_udoo_neo_defconfig lib_defconfig.ForceCheckHash
configs/mx6udoo_defconfig lib_defconfig.ForceCheckHash
configs/nexbox_a95x_defconfig lib_defconfig.ForceCheckHash
configs/nitrogen6sx_defconfig lib_defconfig.ForceCheckHash
--git a/board/udoo/neo/patches/linux-headers/linux-headers.hash b/board/udoo/neo/patches/linux-headers/linux-headers.hash
new file mode 120000
index 0000000000..5808d92afe
--- /dev/null
+++ b/board/udoo/neo/patches/linux-headers/linux-headers.hash
@@ -0,0 +1 @@
+../linux/linux.hash
\ No newline at end of file
diff --git a/board/udoo/neo/patches/linux/linux.hash b/board/udoo/neo/patches/linux/linux.hash
new file mode 100644
index 0000000000..b8935a250a
--- /dev/null
+++ b/board/udoo/neo/patches/linux/linux.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 0ad83b1a1a780a1aad948d55aa55ee63c50c626f2d46910b9d2180028d100a5e linux-6.6.43.tar.xz
diff --git a/board/udoo/neo/patches/uboot/uboot.hash b/board/udoo/neo/patches/uboot/uboot.hash
new file mode 100644
index 0000000000..0bfbf306ff
--- /dev/null
+++ b/board/udoo/neo/patches/uboot/uboot.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256 81b4543227db228c03f8a1bf5ddbc813b0bb8f6555ce46064ef721a6fc680413 u-boot-2022.01.tar.bz2
diff --git a/configs/mx6sx_udoo_neo_defconfig b/configs/mx6sx_udoo_neo_defconfig
index 71a7473307..adcd7aeb4e 100644
--- a/configs/mx6sx_udoo_neo_defconfig
+++ b/configs/mx6sx_udoo_neo_defconfig
@@ -1,5 +1,7 @@
BR2_arm=y
BR2_cortex_a9=y
+BR2_GLOBAL_PATCH_DIR="board/udoo/neo/patches"
+BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
BR2_ARM_ENABLE_NEON=y
BR2_ARM_ENABLE_VFP=y
BR2_ARM_FPU_VFPV3=y
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update
2024-08-01 15:34 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
2024-08-01 15:34 ` [Buildroot] [PATCH v2 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43 Philip-Dylan Gleonec
2024-08-01 15:34 ` [Buildroot] [PATCH v2 2/2] configs/mx6sx_udoo_neo_defconfig: add hashes Philip-Dylan Gleonec
@ 2024-08-01 21:20 ` Thomas Petazzoni via buildroot
2024-08-03 17:15 ` Philip-Dylan Gleonec
2 siblings, 1 reply; 12+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-08-01 21:20 UTC (permalink / raw)
To: Philip-Dylan Gleonec; +Cc: Fabio Estevam, kilian.zinnecker, buildroot
On Thu, 1 Aug 2024 17:34:30 +0200
Philip-Dylan Gleonec <philip-dylan@gleonec.bzh> wrote:
> Philip-Dylan Gleonec (2):
> configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
> configs/mx6sx_udoo_neo_defconfig: add hashes
Thanks, both patches applied! A couple of small comments to improve
your future contributions:
- In the first patch, I added a short extract of the kernel build error
being fixed, and also a link to the Gitlab CI failure being fixed by
this. See the final commit
at https://gitlab.com/buildroot.org/buildroot/-/commit/44b921f605dffd07bb6294e6368c2ace34a08266
- In the commit title, we normally use "configs/foo:" instead of
"configs/foo_defconfig:". No strong reason, just a habit, and we like
to be consistent.
- The wrapping/paragraph organization of your commit messages was a bit
strange and not really consistent with what is done in Buildroot, but
also in the kernel. Basically you tend to do:
Some explanation here.
Then some more explanation that might
span multiple
lines.
Then another explanations.
While in most projects, including Buildroot, we expect:
Some explanation here.
Then some more explanation that might span
multiple lines.
Then another paragraph about something else.
- If you do have this board, it would be nice to add yourself for this
defconfig, and its data file in board/ in the DEVELOPERS file. This
way you will receive notifications when the build of this defconfig
is broken, or when someone submits a patch touching this defconfig.
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update
2024-08-01 21:20 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Thomas Petazzoni via buildroot
@ 2024-08-03 17:15 ` Philip-Dylan Gleonec
0 siblings, 0 replies; 12+ messages in thread
From: Philip-Dylan Gleonec @ 2024-08-03 17:15 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
On 01/08/2024 23:20, Thomas Petazzoni wrote:
> On Thu, 1 Aug 2024 17:34:30 +0200
> Philip-Dylan Gleonec <philip-dylan@gleonec.bzh> wrote:
>
>> Philip-Dylan Gleonec (2):
>> configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
>> configs/mx6sx_udoo_neo_defconfig: add hashes
>
> Thanks, both patches applied! A couple of small comments to improve
> your future contributions:
>
> - In the first patch, I added a short extract of the kernel build error
> being fixed, and also a link to the Gitlab CI failure being fixed by
> this. See the final commit
> at https://gitlab.com/buildroot.org/buildroot/-/commit/44b921f605dffd07bb6294e6368c2ace34a08266
>
> - In the commit title, we normally use "configs/foo:" instead of
> "configs/foo_defconfig:". No strong reason, just a habit, and we like
> to be consistent.
>
> - The wrapping/paragraph organization of your commit messages was a bit
> strange and not really consistent with what is done in Buildroot, but
> also in the kernel. Basically you tend to do:
>
> Some explanation here.
> Then some more explanation that might
> span multiple
> lines.
> Then another explanations.
>
> While in most projects, including Buildroot, we expect:
>
> Some explanation here.
>
> Then some more explanation that might span
> multiple lines.
>
> Then another paragraph about something else.
>
> - If you do have this board, it would be nice to add yourself for this
> defconfig, and its data file in board/ in the DEVELOPERS file. This
> way you will receive notifications when the build of this defconfig
> is broken, or when someone submits a patch touching this defconfig.
>
> Thanks a lot!
>
> Thomas
>
Hi Thomas,
Thanks a lot for the merge and the feedback, I'll make sure to apply it
for the next patches.
Regards,
Philip-Dylan
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update
@ 2024-08-01 18:58 kilian.zinnecker--- via buildroot
0 siblings, 0 replies; 12+ messages in thread
From: kilian.zinnecker--- via buildroot @ 2024-08-01 18:58 UTC (permalink / raw)
To: buildroot, philip-dylan, festevam@gmail.com
Hello Philip, all,
> Please find attached the corrected patchet for the Udoo Neo kernel
> update.
> This fixes the linux hash to use the correct version.
Tested-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
Acked-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
I built the image and was able to boot it on my Udoo Neo Basic.
Sorry for not replying directly on your email - I currently don't receive
emails from the buildroot mailing list, hence I wasn't able to.
Best regards,
Kilian
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2024-08-03 17:15 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 14:55 [Buildroot] [PATCH 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
2024-07-31 14:55 ` [Buildroot] [PATCH 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43 Philip-Dylan Gleonec
2024-07-31 14:55 ` [Buildroot] [PATCH 2/2] configs/mx6sx_udoo_neo_defconfig: add hashes Philip-Dylan Gleonec
2024-07-31 17:01 ` Fabio Estevam
2024-07-31 19:51 ` Philip-Dylan Gleonec
2024-07-31 19:57 ` Fabio Estevam
2024-08-01 15:34 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Philip-Dylan Gleonec
2024-08-01 15:34 ` [Buildroot] [PATCH v2 1/2] configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43 Philip-Dylan Gleonec
2024-08-01 15:34 ` [Buildroot] [PATCH v2 2/2] configs/mx6sx_udoo_neo_defconfig: add hashes Philip-Dylan Gleonec
2024-08-01 21:20 ` [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update Thomas Petazzoni via buildroot
2024-08-03 17:15 ` Philip-Dylan Gleonec
-- strict thread matches above, loose matches on Subject: below --
2024-08-01 18:58 kilian.zinnecker--- via buildroot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox