Re: [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update

Re: [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update

[kilian.zinnecker--- via buildroot]

Hello Philip, all,

> Please find attached the corrected patchet for the Udoo Neo kernel
> update.
> This fixes the linux hash to use the correct version.

Tested-by: Kilian Zinnecker <kilian.zinnecker@mail.de>
Acked-by: Kilian Zinnecker <kilian.zinnecker@mail.de>

I built the image and was able to boot it on my Udoo Neo Basic.

Sorry for not replying directly on your email - I currently don't receive 
emails from the buildroot mailing list, hence I wasn't able to.

Best regards,
Kilian


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 0/2] Udoo Neo kernel update

[Philip-Dylan Gleonec]

Hello,

I'm currently playing with the Udoo Neo board and have found that the
kernel in the current board configuration does not build.

While a point release bump would be sufficient, I took the opportunity
to update the kernel to the latest LTS version. Hashes verification was
added to ensure the integrity of uboot and linux sources.

The 6.6 kernel does not add any regression compared to the latest 5.15
kernel.

Thanks for your time,
Philip-Dylan Gleonec

Philip-Dylan Gleonec (2):
  configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
  configs/mx6sx_udoo_neo_defconfig: add hashes

 .checkpackageignore                                    |  1 -
 .../udoo/neo/patches/linux-headers/linux-headers.hash  |  1 +
 board/udoo/neo/patches/linux/linux.hash                |  2 ++
 board/udoo/neo/patches/uboot/uboot.hash                |  2 ++
 configs/mx6sx_udoo_neo_defconfig                       | 10 ++++++----
 5 files changed, 11 insertions(+), 5 deletions(-)
 create mode 120000 board/udoo/neo/patches/linux-headers/linux-headers.hash
 create mode 100644 board/udoo/neo/patches/linux/linux.hash
 create mode 100644 board/udoo/neo/patches/uboot/uboot.hash

-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 0/2] Udoo Neo kernel update

[Philip-Dylan Gleonec]

Hello,

Please find attached the corrected patchet for the Udoo Neo kernel
update.
This fixes the linux hash to use the correct version.

Best regards,
Philip-Dylan Gleonec

Philip-Dylan Gleonec (2):
  configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
  configs/mx6sx_udoo_neo_defconfig: add hashes

 .checkpackageignore                                    |  1 -
 .../udoo/neo/patches/linux-headers/linux-headers.hash  |  1 +
 board/udoo/neo/patches/linux/linux.hash                |  2 ++
 board/udoo/neo/patches/uboot/uboot.hash                |  2 ++
 configs/mx6sx_udoo_neo_defconfig                       | 10 ++++++----
 5 files changed, 11 insertions(+), 5 deletions(-)
 create mode 120000 board/udoo/neo/patches/linux-headers/linux-headers.hash
 create mode 100644 board/udoo/neo/patches/linux/linux.hash
 create mode 100644 board/udoo/neo/patches/uboot/uboot.hash

-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update

[Thomas Petazzoni via buildroot]

On Thu,  1 Aug 2024 17:34:30 +0200
Philip-Dylan Gleonec <philip-dylan@gleonec.bzh> wrote:

> Philip-Dylan Gleonec (2):
>   configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
>   configs/mx6sx_udoo_neo_defconfig: add hashes

Thanks, both patches applied! A couple of small comments to improve
your future contributions:

- In the first patch, I added a short extract of the kernel build error
  being fixed, and also a link to the Gitlab CI failure being fixed by
  this. See the final commit
  at https://gitlab.com/buildroot.org/buildroot/-/commit/44b921f605dffd07bb6294e6368c2ace34a08266

- In the commit title, we normally use "configs/foo:" instead of
  "configs/foo_defconfig:". No strong reason, just a habit, and we like
  to be consistent.

- The wrapping/paragraph organization of your commit messages was a bit
  strange and not really consistent with what is done in Buildroot, but
  also in the kernel. Basically you tend to do:

Some explanation here.
Then some more explanation that might
span multiple
lines.
Then another explanations.

  While in most projects, including Buildroot, we expect:

Some explanation here.

Then some more explanation that might span
multiple lines.

Then another paragraph about something else.

- If you do have this board, it would be nice to add yourself for this
  defconfig, and its data file in board/ in the DEVELOPERS file. This
  way you will receive notifications when the build of this defconfig
  is broken, or when someone submits a patch touching this defconfig.

Thanks a lot!

Thomas

-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 0/2] Udoo Neo kernel update

[Philip-Dylan Gleonec]

On 01/08/2024 23:20, Thomas Petazzoni wrote:
> On Thu,  1 Aug 2024 17:34:30 +0200
> Philip-Dylan Gleonec <philip-dylan@gleonec.bzh> wrote:
> 
>> Philip-Dylan Gleonec (2):
>>   configs/mx6sx_udoo_neo_defconfig: bump kernel to 6.6.43
>>   configs/mx6sx_udoo_neo_defconfig: add hashes
> 
> Thanks, both patches applied! A couple of small comments to improve
> your future contributions:
> 
> - In the first patch, I added a short extract of the kernel build error
>   being fixed, and also a link to the Gitlab CI failure being fixed by
>   this. See the final commit
>   at https://gitlab.com/buildroot.org/buildroot/-/commit/44b921f605dffd07bb6294e6368c2ace34a08266
> 
> - In the commit title, we normally use "configs/foo:" instead of
>   "configs/foo_defconfig:". No strong reason, just a habit, and we like
>   to be consistent.
> 
> - The wrapping/paragraph organization of your commit messages was a bit
>   strange and not really consistent with what is done in Buildroot, but
>   also in the kernel. Basically you tend to do:
> 
> Some explanation here.
> Then some more explanation that might
> span multiple
> lines.
> Then another explanations.
> 
>   While in most projects, including Buildroot, we expect:
> 
> Some explanation here.
> 
> Then some more explanation that might span
> multiple lines.
> 
> Then another paragraph about something else.
> 
> - If you do have this board, it would be nice to add yourself for this
>   defconfig, and its data file in board/ in the DEVELOPERS file. This
>   way you will receive notifications when the build of this defconfig
>   is broken, or when someone submits a patch touching this defconfig.
> 
> Thanks a lot!
> 
> Thomas
> 

Hi Thomas,

Thanks a lot for the merge and the feedback, I'll make sure to apply it
for the next patches.

Regards,
Philip-Dylan
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot