* [Buildroot] Fwd: [PATCH 1/1] package/directfb2: add directfb2 packages
2024-07-05 13:25 [Buildroot] [PATCH 1/1] package/directfb2: add directfb2 packages Shengwen Cheng
@ 2024-08-07 3:05 ` Shengwen Cheng
2024-08-07 9:48 ` [Buildroot] " Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Shengwen Cheng @ 2024-08-07 3:05 UTC (permalink / raw)
To: thomas.petazzoni, buildroot; +Cc: Ching-Chun (Jim) Huang
[-- Attachment #1.1: Type: text/plain, Size: 20453 bytes --]
Hi Thomas Petazzoni,
I submitted a change regarding the inclusion of DirectFB2 into Buildroot on
July 5th, but I haven't received a response yet.
Could you please provide any advice for my submission?
Patchwork link :
https://patchwork.ozlabs.org/project/buildroot/patch/20240705132544.351613-1-shengwen1997.tw@gmail.com/
Thanks,
Colin Cheng
---------- Forwarded message ---------
From: Shengwen Cheng <shengwen1997.tw@gmail.com>
Date: Fri, Jul 5, 2024 at 9:26 PM
Subject: [PATCH 1/1] package/directfb2: add directfb2 packages
To: <buildroot@buildroot.org>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>, Jim Huang <
jserv@ccns.ncku.edu.tw>, Shengwen Cheng <shengwen1997.tw@gmail.com>
This introduces DirectFB2, a fork of DirectFB to the Buildroot. The original
DirectFB has not been maintained since 2016. Meanwhile, in 2022, DirectFB2
was
announced at FOSDEM in Brussels, with the goal of maintaining DirectFB for
use
on embedded systems.
New packages:
1. directfb2
2. directfb2-csource
3. directfb2-lite
4. directfb2-media
5. directfb2-tools
6. directfb2-examples
7. dfbterm
[1]
https://archive.fosdem.org/2022/schedule/event/directfb/attachments/slides/
5077/export/events/attachments/directfb/slides/5077/fosdem_2022_directfb2.pdf
<https://archive.fosdem.org/2022/schedule/event/directfb/attachments/slides/5077/export/events/attachments/directfb/slides/5077/fosdem_2022_directfb2.pdf>
Signed-off-by: Shengwen Cheng <shengwen1997.tw@gmail.com>
---
package/Config.in | 1 +
package/dfbterm/Config.in | 11 ++
package/dfbterm/dfbterm.mk | 14 +++
package/directfb2-csource/Config.in | 6 +
.../directfb2-csource/directfb2-csource.mk | 15 +++
package/directfb2-examples/Config.in | 104 ++++++++++++++++++
.../directfb2-examples/directfb2-examples.mk | 61 ++++++++++
package/directfb2-lite/Config.in | 7 ++
package/directfb2-lite/directfb2-lite.mk | 15 +++
package/directfb2-media/Config.in | 6 +
package/directfb2-media/directfb2-media.mk | 15 +++
package/directfb2-tools/Config.in | 5 +
package/directfb2-tools/directfb2-tools.mk | 14 +++
package/directfb2/Config.in | 70 ++++++++++++
package/directfb2/directfb2.mk | 62 +++++++++++
15 files changed, 406 insertions(+)
create mode 100644 package/dfbterm/Config.in
create mode 100644 package/dfbterm/dfbterm.mk
create mode 100644 package/directfb2-csource/Config.in
create mode 100644 package/directfb2-csource/directfb2-csource.mk
create mode 100644 package/directfb2-examples/Config.in
create mode 100644 package/directfb2-examples/directfb2-examples.mk
create mode 100644 package/directfb2-lite/Config.in
create mode 100644 package/directfb2-lite/directfb2-lite.mk
create mode 100644 package/directfb2-media/Config.in
create mode 100644 package/directfb2-media/directfb2-media.mk
create mode 100644 package/directfb2-tools/Config.in
create mode 100644 package/directfb2-tools/directfb2-tools.mk
create mode 100644 package/directfb2/Config.in
create mode 100644 package/directfb2/directfb2.mk
diff --git a/package/Config.in b/package/Config.in
index 550fdc1f41..d9b96201ff 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -346,6 +346,7 @@ comment "Graphic libraries"
source "package/cegui/Config.in"
source "package/directfb/Config.in"
source "package/directfb-examples/Config.in"
+ source "package/directfb2/Config.in"
source "package/efl/Config.in"
source "package/fb-test-app/Config.in"
source "package/fbdump/Config.in"
diff --git a/package/dfbterm/Config.in b/package/dfbterm/Config.in
new file mode 100644
index 0000000000..4258a857b9
--- /dev/null
+++ b/package/dfbterm/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_DFBTERM
+ bool "DFBTerm"
+ depends on BR2_PACKAGE_DIRECTFB2
+ select BR2_PACKAGE_DIRECTFB2_LITE
+ help
+ DFBTerm is a terminal emulator runnning on DirectFB2 and
+ based on libzvt.
+
+ libzvt (Zed's virtual terminal emulation library) is
+ included directly in the source code, although it is
+ possible to use the system's libzvt library.
diff --git a/package/dfbterm/dfbterm.mk b/package/dfbterm/dfbterm.mk
new file mode 100644
index 0000000000..8f53883dfc
--- /dev/null
+++ b/package/dfbterm/dfbterm.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# dfbterm
+#
+################################################################################
+
+DFBTERM_VERSION = 0e78750b5e58655d521da54540dc0a9bdca2f840
+DFBTERM_SITE = "https://github.com/directfb2/DFBTerm"
+DFBTERM_SITE_METHOD = git
+DFBTERM_LICENSE = GPL-2.0
+DFBTERM_LICENSE_FILES = COPYING
+DFBTERM_DEPENDENCIES = directfb2 directfb2-lite
+
+$(eval $(meson-package))
diff --git a/package/directfb2-csource/Config.in
b/package/directfb2-csource/Config.in
new file mode 100644
index 0000000000..0419bcb839
--- /dev/null
+++ b/package/directfb2-csource/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_DIRECTFB2_CSOURCE
+ bool "directfb2-csource"
+ depends on BR2_PACKAGE_DIRECTFB2
+ help
+ directfb2-csource is a data header file generation utility for
+ DirectFB2 code.
diff --git a/package/directfb2-csource/directfb2-csource.mk
b/package/directfb2-csource/directfb2-csource.mk
new file mode 100644
index 0000000000..231c848442
--- /dev/null
+++ b/package/directfb2-csource/directfb2-csource.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# directfb2-csource
+#
+################################################################################
+
+DIRECTFB2_CSOURCE_VERSION = 2758dee7937e8850d6c8105bd6ef1db06c86064f
+DIRECTFB2_CSOURCE_SITE = "https://github.com/directfb2/directfb-csource"
+DIRECTFB2_CSOURCE_SITE_METHOD = git
+DIRECTFB2_CSOURCE_LICENSE = GPL-2.0
+DIRECTFB2_CSOURCE_LICENSE_FILES = COPYING
+DIRECTFB2_CSOURCE_DEPENDENCIES = directfb2
+DIRECTFB2_CSOURCE_INSTALL_STAGING = YES
+
+$(eval $(meson-package))
diff --git a/package/directfb2-examples/Config.in
b/package/directfb2-examples/Config.in
new file mode 100644
index 0000000000..05f34ee002
--- /dev/null
+++ b/package/directfb2-examples/Config.in
@@ -0,0 +1,104 @@
+menuconfig BR2_PACKAGE_DIRECTFB2_EXAMPLES
+ bool "DirectFB2 examples"
+ depends on BR2_PACKAGE_DIRECTFB2
+ select BR2_PACKAGE_DIRECTFB2_CSOURCE
+ help
+ The DirectFB2-examples package contains a set of simple
+ DirectFB2 applications that can be used to test and
+ demonstrate various DirectFB2 features. Note that DirectFB2
+ is a fork of DirectFB, as the original DirectFB stopped
+ being maintained in 2016.
+
+ The official DirectFB2 website can be visited via
+ https://directfb2.github.io/
+
+if BR2_PACKAGE_DIRECTFB2_EXAMPLES
+
+choice
+ prompt "DirectFBGL interface version"
+ default BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_NULL
+
+config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_NULL
+ bool "-"
+comment "Build without version flag specified"
+
+config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_1
+ bool "1"
+comment "Pass -Ddirectfbgl=1 to the Meson build system"
+
+config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_2
+ bool "2"
+comment "Pass -Ddirectfbgl=2 to the Meson build system"
+
+endchoice
+
+config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL
+ string "PATH to OpenGL header"
+ default ""
+
+config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_CFLAGS
+ string "CFLAGS of the OpenGL implementation"
+ default ""
+
+config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_LDFLAGS
+ string "LDFLAGS of the OpenGL implementation"
+ default ""
+
+# Disabled for now as directfb2-csource currently does not generate
+# pkgconfig file
+#
+# choice
+# prompt "Select font header for DirectFB2 examples"
+# default BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_DISABLED
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_DISABLED
+# bool "disabled"
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_DGIFF
+# bool "dgiff"
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_ttf
+# bool "ttf"
+#
+#endchoice
+
+# Disabled for now as directfb2-csource currently does not generate
+# pkgconfig file
+#
+# choice
+# prompt "Select image header for DirectFB2 examples"
+# default BR2_PACKAGE_DIRECTFB2_EXAMPLES_DISABLED
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_DISABLED
+# bool "disabled"
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_DFIFF
+# bool "dfiff"
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_PNG
+# bool "png"
+#
+# endchoice
+
+# Disabled for now as directfb2-csource currently does not generate
+# pkgconfig file
+#
+# choice
+# prompt "Select video header for DirectFB2 examples"
+# default BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_DISABLED
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_DISABLED
+# bool "disabled"
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_DFVFF
+# bool "dfvff"
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_M2V
+# bool "m2v"
+#
+# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_264
+# bool "264"
+#
+# endchoice
+
+endif # BR2_PACKAGE_DIRECTFB2_EXAMPLES
diff --git a/package/directfb2-examples/directfb2-examples.mk
b/package/directfb2-examples/directfb2-examples.mk
new file mode 100644
index 0000000000..b627ba6906
--- /dev/null
+++ b/package/directfb2-examples/directfb2-examples.mk
@@ -0,0 +1,61 @@
+################################################################################
+#
+# directfb2-examples
+#
+################################################################################
+
+DIRECTFB2_EXAMPLES_VERSION = d627550430407ce6f1e42a861985ec42c0f4ac19
+DIRECTFB2_EXAMPLES_SITE = "https://github.com/directfb2/DirectFB-examples"
+DIRECTFB2_EXAMPLES_SITE_METHOD = git
+DIRECTFB2_EXAMPLES_LICENSE = MIT
+DIRECTFB2_EXAMPLES_LICENSE_FILES = COPYING
+DIRECTFB2_EXAMPLES_DEPENDENCIES = directfb2 directfb2-csource
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_1),y)
+DIRECTFB2_EXAMPLES_CONF_OPTS += -Ddirectfbgl=1
+else ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_2),y)
+DIRECTFB2_EXAMPLES_CONF_OPTS += -Ddirectfbgl=2
+endif
+
+ifneq ($(call qstrip, $(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL)),)
+DIRECTFB2_EXAMPLES_CONF_OPTS += -Dgl=$(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL)
+endif
+
+ifneq ($(call qstrip, $(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_CFLAGS)),)
+DIRECTFB2_EXAMPLES_CONF_OPTS +=
-Dgl-cflags=$(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_CFLAGS)
+endif
+
+ifneq ($(call qstrip, $(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_LDFLAGS)),)
+DIRECTFB2_EXAMPLES_CONF_OPTS +=
-Dgl-ldflags=$(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_LDFLAGS)
+endif
+
+# Disabled for now as directfb2-csource currently does not generate
+# pkgconfig file
+#
+# ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_DGIFF),y)
+# DIRECTFB2_EXAMPLES_CONF_OPTS += -Dfont-headers=dgiff
+# else ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_ttf),y)
+# DIRECTFB2_EXAMPLES_CONF_OPTS += -Dfont-headers=ttf
+# endif
+
+# Disabled for now as directfb2-csource currently does not generate
+# pkgconfig file
+#
+# ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_DFIFF),y)
+# DIRECTFB2_EXAMPLES_CONF_OPTS += -Dimage-headers=dfiff
+# else ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_PNG),y)
+# DIRECTFB2_EXAMPLES_CONF_OPTS += -Dimage-headers=png
+# endif
+
+# Disabled for now as directfb2-csource currently does not generate
+# pkgconfig file
+#
+# ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_DFVFF),y)
+# DIRECTFB2_EXAMPLES_CONF_OPTS += -Dvideo-headers=dfvff
+# else ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_M2V),y)
+# DIRECTFB2_EXAMPLES_CONF_OPTS += -Dvideo-headers=m2v
+# else ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_264),y)
+# DIRECTFB2_EXAMPLES_CONF_OPTS += -Dvideo-headers=264
+# endif
+
+$(eval $(meson-package))
diff --git a/package/directfb2-lite/Config.in
b/package/directfb2-lite/Config.in
new file mode 100644
index 0000000000..d76a2896e1
--- /dev/null
+++ b/package/directfb2-lite/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_DIRECTFB2_LITE
+ bool "directfb2-lite"
+ depends on BR2_PACKAGE_DIRECTFB2
+ help
+ LiTE stands for Lightweight Toolkit Enabler and is a simple
+ user interface library on top of DirectFB2. Widgets can be
+ used with a default theme, or with its own custom theme.
diff --git a/package/directfb2-lite/directfb2-lite.mk
b/package/directfb2-lite/directfb2-lite.mk
new file mode 100644
index 0000000000..56cb099e98
--- /dev/null
+++ b/package/directfb2-lite/directfb2-lite.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# directfb2-lite
+#
+################################################################################
+
+DIRECTFB2_LITE_VERSION = 164bb5eca507c3cee1be2adf3798745f305495d7
+DIRECTFB2_LITE_SITE = "https://github.com/directfb2/LiTE"
+DIRECTFB2_LITE_SITE_METHOD = git
+DIRECTFB2_LITE_LICENSE = LGPL-2.1
+DIRECTFB2_LITE_LICENSE_FILES = COPYING
+DIRECTFB2_LITE_DEPENDENCIES = directfb2
+DIRECTFB2_LITE_INSTALL_STAGING = YES
+
+$(eval $(meson-package))
diff --git a/package/directfb2-media/Config.in
b/package/directfb2-media/Config.in
new file mode 100644
index 0000000000..1a0e09d077
--- /dev/null
+++ b/package/directfb2-media/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_DIRECTFB2_MEDIA
+ bool "directfb2-media"
+ depends on BR2_PACKAGE_DIRECTFB2
+ help
+ DirectFB2-media contains additional font/image/music/video
+ providers for DirectFB2.
diff --git a/package/directfb2-media/directfb2-media.mk
b/package/directfb2-media/directfb2-media.mk
new file mode 100644
index 0000000000..50efa168d9
--- /dev/null
+++ b/package/directfb2-media/directfb2-media.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# directfb2-media
+#
+################################################################################
+
+DIRECTFB2_MEDIA_VERSION = 8f8cb02a3d67a3eb9726ca2927061e2697b7f2de
+DIRECTFB2_MEDIA_SITE = "https://github.com/directfb2/DirectFB2-media"
+DIRECTFB2_MEDIA_SITE_METHOD = git
+DIRECTFB2_MEDIA_LICENSE = LGPL-2.1
+DIRECTFB2_MEDIA_LICENSE_FILES = COPYING
+DIRECTFB2_MEDIA_DEPENDENCIES = directfb2
+DIRECTFB2_MEDIA_INSTALL_STAGING = YES
+
+$(eval $(meson-package))
diff --git a/package/directfb2-tools/Config.in
b/package/directfb2-tools/Config.in
new file mode 100644
index 0000000000..f4d16596bc
--- /dev/null
+++ b/package/directfb2-tools/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_DIRECTFB2_TOOLS
+ bool "directfb2-tools"
+ depends on BR2_PACKAGE_DIRECTFB2
+ help
+ DirectFB2-tools contains various DirectFB2 utilities.
diff --git a/package/directfb2-tools/directfb2-tools.mk
b/package/directfb2-tools/directfb2-tools.mk
new file mode 100644
index 0000000000..7930159f2b
--- /dev/null
+++ b/package/directfb2-tools/directfb2-tools.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# directfb2-tools
+#
+################################################################################
+
+DIRECTFB2_TOOLS_VERSION = 679838c281cbe7849011f7f6db1c815167c44fee
+DIRECTFB2_TOOLS_SITE = "https://github.com/directfb2/DirectFB2-tools"
+DIRECTFB2_TOOLS_SITE_METHOD = git
+DIRECTFB2_TOOLS_LICENSE = GPL-2.0
+DIRECTFB2_TOOLS_LICENSE_FILES = COPYING
+DIRECTFB2_TOOLS_DEPENDENCIES = directfb2
+
+$(eval $(meson-package))
diff --git a/package/directfb2/Config.in b/package/directfb2/Config.in
new file mode 100644
index 0000000000..6ef6e69a07
--- /dev/null
+++ b/package/directfb2/Config.in
@@ -0,0 +1,70 @@
+menuconfig BR2_PACKAGE_DIRECTFB2
+ bool "DirectFB2"
+ default n
+ help
+ DirectFB2 is a fork of DirectFB (Direct Frame Buffer) whose
+ purpose is to preserve and maintain the DirectFB graphics
+ backend, particularly for use on embedded systems.
+
+ The official DirectFB2 website can be visited via
+ https://directfb2.github.io/
+
+if BR2_PACKAGE_DIRECTFB2
+
+menu "DirectFB2 Options"
+
+config BR2_PACKAGE_DIRECTFB2_DRMKMS
+ bool "Enable Linux DRM/KMS support"
+
+config BR2_PACKAGE_DIRECTFB2_FBDEV
+ bool "Enable Linux Framebuffer support"
+
+config BR2_PACKAGE_DIRECTFB2_LINUX_INPUT
+ bool "Enable Linux input support"
+
+if BR2_X86_CPU_HAS_MMX
+config BR2_PACKAGE_DIRECTFB2_MMX
+ bool "Enable MMX assembly support"
+ default y
+endif # BR2_X86_CPU_HAS_MMX
+
+config BR2_PACKAGE_DIRECTFB2_MULTI
+ bool "Enable multi application support"
+
+config BR2_PACKAGE_DIRECTFB2_MULTI_KERNEL
+ bool "Enable Linux fusion device support for multi application"
+ select BR2_PACKAGE_DIRECTFB2_MULTI
+
+# if BR2_ARM_CPU_HAS_NEON
+# config BR2_PACKAGE_DIRECTFB2_NEON
+# bool "Enable NEON assembly support"
+# default y
+# endif # BR2_ARM_CPU_HAS_NEON
+#
+# DirectFB2 currently has issues enabling NEON. For more details, see:
+# https://github.com/directfb2/DirectFB2/issues/142
+
+config BR2_PACKAGE_DIRECTFB2_NETWORK
+ bool "Enable network support"
+
+config BR2_PACKAGE_DIRECTFB2_SENTINELS
+ bool "Enable surface sentinels at the end of chunks in video memory"
+
+config BR2_PACKAGE_DIRECTFB2_SMOOTH_SCALING
+ bool "Enable smooth scaling support"
+
+endmenu
+
+menu "DirectFB2 Applications"
+source "package/directfb2-examples/Config.in"
+source "package/dfbterm/Config.in"
+endmenu
+
+menu "DirectFB2 Utilities"
+source "package/directfb2-media/Config.in"
+source "package/directfb2-tools/Config.in"
+source "package/directfb2-csource/Config.in"
+source "package/directfb2-lite/Config.in"
+endmenu
+
+endif # BR2_PACKAGE_DIRECTFB2
diff --git a/package/directfb2/directfb2.mk b/package/directfb2/directfb2.mk
new file mode 100644
index 0000000000..197ff38632
--- /dev/null
+++ b/package/directfb2/directfb2.mk
@@ -0,0 +1,62 @@
+################################################################################
+#
+# directfb2
+#
+################################################################################
+
+DIRECTFB2_VERSION = 2952d1d16b546be09e1cbb5da5e0c718d8f5ee32
+DIRECTFB2_SITE = "https://github.com/directfb2/DirectFB2"
+DIRECTFB2_SITE_METHOD = git
+DIRECTFB2_LICENSE = LGPL-2.1
+DIRECTFB2_LICENSE_FILES = COPYING
+DIRECTFB2_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_DRMKMS),y)
+DIRECTFB2_CONF_OPTS += -Ddrmkms=true
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_FBDEV),y)
+DIRECTFB2_CONF_OPTS += -Dfbdev=true
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_LINUX_INPUT),y)
+DIRECTFB2_CONF_OPTS += -Dlinux_input=true
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_MMX),y)
+DIRECTFB2_CONF_OPTS += -Dmmx=true
+else ifeq ($(BR2_PACKAGE_DIRECTFB2_MMX),n)
+DIRECTFB2_CONF_OPTS += -Dmmx=false
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_MULTI),y)
+DIRECTFB2_CONF_OPTS += -Dmulti=true
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_MULTI_KERNEL),y)
+DIRECTFB2_CONF_OPTS += -Dmulti-kernel=true
+endif
+
+# ifeq ($(BR2_PACKAGE_DIRECTFB2_NEON),y)
+# DIRECTFB2_CONF_OPTS += -Dneon=true
+# else ifeq ($(BR2_PACKAGE_DIRECTFB2_NEON),y)
+# DIRECTFB2_CONF_OPTS += -Dneon=false
+# endif
+#
+# DirectFB2 currently has issues enabling NEON. For more details, see:
+# https://github.com/directfb2/DirectFB2/issues/142
+DIRECTFB2_CONF_OPTS += -Dneon=false
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_NETWORK),y)
+DIRECTFB2_CONF_OPTS += -Dnetwork=true
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_SENTINELS),y)
+DIRECTFB2_CONF_OPTS += -Dsentinels=true
+endif
+
+ifeq ($(BR2_PACKAGE_DIRECTFB2_SMOOTH_SCALING),y)
+DIRECTFB2_CONF_OPTS += -Dsmooth-scaling=true
+endif
+
+$(eval $(meson-package))
--
2.34.1
[-- Attachment #1.2: Type: text/html, Size: 28151 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/directfb2: add directfb2 packages
2024-07-05 13:25 [Buildroot] [PATCH 1/1] package/directfb2: add directfb2 packages Shengwen Cheng
2024-08-07 3:05 ` [Buildroot] Fwd: " Shengwen Cheng
@ 2024-08-07 9:48 ` Thomas Petazzoni via buildroot
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-08-07 9:48 UTC (permalink / raw)
To: Shengwen Cheng; +Cc: Eric Le Bihan, Jim Huang, buildroot
Hello!
First of all, thanks a lot for your contribution, and sorry for the
delay in getting back to you. See below a number of review comments: I
will reply point by point to your patch, so make sure to read the
entire e-mail below.
On Fri, 5 Jul 2024 21:25:44 +0800
Shengwen Cheng <shengwen1997.tw@gmail.com> wrote:
> This introduces DirectFB2, a fork of DirectFB to the Buildroot. The original
> DirectFB has not been maintained since 2016. Meanwhile, in 2022, DirectFB2 was
> announced at FOSDEM in Brussels, with the goal of maintaining DirectFB for use
> on embedded systems.
Could you comment on whether directfb2 is compatible with the original
directfb? Do we want to keep both package/directfb and add a separate
package/directfb2 ?
If they are compatible, then I believe we don't want to introduce a
separate package/directfb2 package, and instead we simply want to
update package/directfb to use version 2.x of DirectFB.
I think the main question is whether our current packages that depend
on DirectFB continue to build/work with DirectFB2. Namely:
- gst1-plugins-bad
- links
- lite
- DirectFB backend of Qt5
- sdl
- sdl2
- tekui
- vulkan-loader
- vulkan-tools
> New packages:
> 1. directfb2
> 2. directfb2-csource
> 3. directfb2-lite
> 4. directfb2-media
> 5. directfb2-tools
> 6. directfb2-examples
> 7. dfbterm
Each of those packages should be added by a separate patch, so for your
version 2 of this patch, we expect to receive a patch series containing
7 patches, each introducing one of those new packages (of course unless
we decide to upgrade package/directfb instead of introducing
package/directfb2).
>
> [1] https://archive.fosdem.org/2022/schedule/event/directfb/attachments/slides/
> 5077/export/events/attachments/directfb/slides/5077/fosdem_2022_directfb2.pdf
>
> Signed-off-by: Shengwen Cheng <shengwen1997.tw@gmail.com>
> ---
> package/Config.in | 1 +
> package/dfbterm/Config.in | 11 ++
> package/dfbterm/dfbterm.mk | 14 +++
> package/directfb2-csource/Config.in | 6 +
> .../directfb2-csource/directfb2-csource.mk | 15 +++
> package/directfb2-examples/Config.in | 104 ++++++++++++++++++
> .../directfb2-examples/directfb2-examples.mk | 61 ++++++++++
> package/directfb2-lite/Config.in | 7 ++
> package/directfb2-lite/directfb2-lite.mk | 15 +++
> package/directfb2-media/Config.in | 6 +
> package/directfb2-media/directfb2-media.mk | 15 +++
> package/directfb2-tools/Config.in | 5 +
> package/directfb2-tools/directfb2-tools.mk | 14 +++
> package/directfb2/Config.in | 70 ++++++++++++
> package/directfb2/directfb2.mk | 62 +++++++++++
> 15 files changed, 406 insertions(+)
For each new package, you need to add an entry in the DEVELOPERS file.
Make sure to do that in each patch adding each package.
Also please add a .hash file to each package, providing the hash for
the tarball, and the hash for the license files (see other packages to
have an idea of how it's done).
> diff --git a/package/Config.in b/package/Config.in
> index 550fdc1f41..d9b96201ff 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -346,6 +346,7 @@ comment "Graphic libraries"
> source "package/cegui/Config.in"
> source "package/directfb/Config.in"
> source "package/directfb-examples/Config.in"
> + source "package/directfb2/Config.in"
I think we will want all packages Config.in files sourced from
package/Config.in, rather than package/directfb2/Config.in sourcing the
other packages. Indeed, they are other packages that are not
DirectFB-specific that can also depend/use DirectFB2, and they will not
be included from package/directfb2/Config.in.
> source "package/efl/Config.in"
> source "package/fb-test-app/Config.in"
> source "package/fbdump/Config.in"
> diff --git a/package/dfbterm/Config.in b/package/dfbterm/Config.in
> new file mode 100644
> index 0000000000..4258a857b9
> --- /dev/null
> +++ b/package/dfbterm/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_DFBTERM
> + bool "DFBTerm"
> + depends on BR2_PACKAGE_DIRECTFB2
> + select BR2_PACKAGE_DIRECTFB2_LITE
> + help
> + DFBTerm is a terminal emulator runnning on DirectFB2 and
> + based on libzvt.
> +
> + libzvt (Zed's virtual terminal emulation library) is
> + included directly in the source code, although it is
> + possible to use the system's libzvt library.
Then please package libzvt and use it. We very much prefer to use
external libraries than bundled ones.
> diff --git a/package/dfbterm/dfbterm.mk b/package/dfbterm/dfbterm.mk
> new file mode 100644
> index 0000000000..8f53883dfc
> --- /dev/null
> +++ b/package/dfbterm/dfbterm.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# dfbterm
> +#
> +################################################################################
> +
> +DFBTERM_VERSION = 0e78750b5e58655d521da54540dc0a9bdca2f840
> +DFBTERM_SITE = "https://github.com/directfb2/DFBTerm"
Double quotes are not needed here.
> +DFBTERM_SITE_METHOD = git
Please use the $(call github,...) macro instead (see other packages).
Does the project provide tagged releases, instead of using an arbitrary
commit?
> +DFBTERM_LICENSE = GPL-2.0
License is GPL-2.0+
> +DFBTERM_LICENSE_FILES = COPYING
> +DFBTERM_DEPENDENCIES = directfb2 directfb2-lite
> +
> +$(eval $(meson-package))
> diff --git a/package/directfb2-csource/Config.in b/package/directfb2-csource/Config.in
> new file mode 100644
> index 0000000000..0419bcb839
> --- /dev/null
> +++ b/package/directfb2-csource/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_DIRECTFB2_CSOURCE
> + bool "directfb2-csource"
> + depends on BR2_PACKAGE_DIRECTFB2
> + help
> + directfb2-csource is a data header file generation utility for
> + DirectFB2 code.
Why would we need this tool on the target? I can understand why it
would be needed on the host machine at build time, but on the target?
Why would we want to generate data header files on the target?
> diff --git a/package/directfb2-csource/directfb2-csource.mk b/package/directfb2-csource/directfb2-csource.mk
> new file mode 100644
> index 0000000000..231c848442
> --- /dev/null
> +++ b/package/directfb2-csource/directfb2-csource.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# directfb2-csource
> +#
> +################################################################################
> +
> +DIRECTFB2_CSOURCE_VERSION = 2758dee7937e8850d6c8105bd6ef1db06c86064f
> +DIRECTFB2_CSOURCE_SITE = "https://github.com/directfb2/directfb-csource"
> +DIRECTFB2_CSOURCE_SITE_METHOD = git
Use github macro.
> +DIRECTFB2_CSOURCE_LICENSE = GPL-2.0
GPL-2.0+
> +DIRECTFB2_CSOURCE_LICENSE_FILES = COPYING
> +DIRECTFB2_CSOURCE_DEPENDENCIES = directfb2
> +DIRECTFB2_CSOURCE_INSTALL_STAGING = YES
> +
> +$(eval $(meson-package))
> diff --git a/package/directfb2-examples/Config.in b/package/directfb2-examples/Config.in
> new file mode 100644
> index 0000000000..05f34ee002
> --- /dev/null
> +++ b/package/directfb2-examples/Config.in
> @@ -0,0 +1,104 @@
> +menuconfig BR2_PACKAGE_DIRECTFB2_EXAMPLES
> + bool "DirectFB2 examples"
> + depends on BR2_PACKAGE_DIRECTFB2
> + select BR2_PACKAGE_DIRECTFB2_CSOURCE
> + help
> + The DirectFB2-examples package contains a set of simple
> + DirectFB2 applications that can be used to test and
> + demonstrate various DirectFB2 features. Note that DirectFB2
> + is a fork of DirectFB, as the original DirectFB stopped
> + being maintained in 2016.
> +
> + The official DirectFB2 website can be visited via
> + https://directfb2.github.io/
> +
> +if BR2_PACKAGE_DIRECTFB2_EXAMPLES
> +
> +choice
> + prompt "DirectFBGL interface version"
> + default BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_NULL
> +
> +config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_NULL
> + bool "-"
> +comment "Build without version flag specified"
> +
> +config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_1
> + bool "1"
> +comment "Pass -Ddirectfbgl=1 to the Meson build system"
> +
> +config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_2
> + bool "2"
> +comment "Pass -Ddirectfbgl=2 to the Meson build system"
Don't use comments here, but put this in the help text of each option,
or the help text of the choice.
What does this option really does in the end? I.e why is it important
to expose it to the user?
> +
> +endchoice
> +
> +config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL
> + string "PATH to OpenGL header"
> + default ""
Should not be needed.
> +config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_CFLAGS
> + string "CFLAGS of the OpenGL implementation"
> + default ""
Ditto.
> +
> +config BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_LDFLAGS
> + string "LDFLAGS of the OpenGL implementation"
> + default ""
Ditto.
> +# Disabled for now as directfb2-csource currently does not generate
> +# pkgconfig file
> +#
> +# choice
> +# prompt "Select font header for DirectFB2 examples"
> +# default BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_DISABLED
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_DISABLED
> +# bool "disabled"
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_DGIFF
> +# bool "dgiff"
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_FONT_HEADER_ttf
> +# bool "ttf"
> +#
> +#endchoice
> +
> +# Disabled for now as directfb2-csource currently does not generate
> +# pkgconfig file
> +#
> +# choice
> +# prompt "Select image header for DirectFB2 examples"
> +# default BR2_PACKAGE_DIRECTFB2_EXAMPLES_DISABLED
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_DISABLED
> +# bool "disabled"
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_DFIFF
> +# bool "dfiff"
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_PNG
> +# bool "png"
> +#
> +# endchoice
> +
> +# Disabled for now as directfb2-csource currently does not generate
> +# pkgconfig file
> +#
> +# choice
> +# prompt "Select video header for DirectFB2 examples"
> +# default BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_DISABLED
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_DISABLED
> +# bool "disabled"
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_DFVFF
> +# bool "dfvff"
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_M2V
> +# bool "m2v"
> +#
> +# config BR2_PACKAGE_DIRECTFB2_EXAMPLES_VIDEO_HEADERS_264
> +# bool "264"
> +#
> +# endchoice
Please drop commented code. However, what is the problem with
directfb-source exactly? As explained above: you packaged
directfb-source as a target package, which is most likely incorrect as
this tool is very likely needed on the host instead, to be executed
during the build process.
> +
> +endif # BR2_PACKAGE_DIRECTFB2_EXAMPLES
> diff --git a/package/directfb2-examples/directfb2-examples.mk b/package/directfb2-examples/directfb2-examples.mk
> new file mode 100644
> index 0000000000..b627ba6906
> --- /dev/null
> +++ b/package/directfb2-examples/directfb2-examples.mk
> @@ -0,0 +1,61 @@
> +################################################################################
> +#
> +# directfb2-examples
> +#
> +################################################################################
> +
> +DIRECTFB2_EXAMPLES_VERSION = d627550430407ce6f1e42a861985ec42c0f4ac19
> +DIRECTFB2_EXAMPLES_SITE = "https://github.com/directfb2/DirectFB-examples"
> +DIRECTFB2_EXAMPLES_SITE_METHOD = git
github macro.
> +DIRECTFB2_EXAMPLES_LICENSE = MIT
> +DIRECTFB2_EXAMPLES_LICENSE_FILES = COPYING
> +DIRECTFB2_EXAMPLES_DEPENDENCIES = directfb2 directfb2-csource
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_1),y)
> +DIRECTFB2_EXAMPLES_CONF_OPTS += -Ddirectfbgl=1
> +else ifeq ($(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_VERSION_2),y)
> +DIRECTFB2_EXAMPLES_CONF_OPTS += -Ddirectfbgl=2
> +endif
> +
> +ifneq ($(call qstrip, $(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL)),)
> +DIRECTFB2_EXAMPLES_CONF_OPTS += -Dgl=$(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL)
> +endif
> +
> +ifneq ($(call qstrip, $(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_CFLAGS)),)
> +DIRECTFB2_EXAMPLES_CONF_OPTS += -Dgl-cflags=$(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_CFLAGS)
> +endif
> +
> +ifneq ($(call qstrip, $(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_LDFLAGS)),)
> +DIRECTFB2_EXAMPLES_CONF_OPTS += -Dgl-ldflags=$(BR2_PACKAGE_DIRECTFB2_EXAMPLES_GL_LDFLAGS)
> +endif
I really don't think we want to GL related options. Could you explain
why they are needed?
> +# Disabled for now as directfb2-csource currently does not generate
> +# pkgconfig file
Please don't include commented out code.
> diff --git a/package/directfb2-lite/Config.in b/package/directfb2-lite/Config.in
> new file mode 100644
> index 0000000000..d76a2896e1
> --- /dev/null
> +++ b/package/directfb2-lite/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_DIRECTFB2_LITE
> + bool "directfb2-lite"
> + depends on BR2_PACKAGE_DIRECTFB2
> + help
> + LiTE stands for Lightweight Toolkit Enabler and is a simple
> + user interface library on top of DirectFB2. Widgets can be
> + used with a default theme, or with its own custom theme.
Ah forgot about it for the other packages: the help text must end with
an empty line, followed by the URL of the upstream project page. You
can run "make check-package" to validate the coding style of your
packages.
> diff --git a/package/directfb2-lite/directfb2-lite.mk b/package/directfb2-lite/directfb2-lite.mk
> new file mode 100644
> index 0000000000..56cb099e98
> --- /dev/null
> +++ b/package/directfb2-lite/directfb2-lite.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# directfb2-lite
> +#
> +################################################################################
> +
> +DIRECTFB2_LITE_VERSION = 164bb5eca507c3cee1be2adf3798745f305495d7
> +DIRECTFB2_LITE_SITE = "https://github.com/directfb2/LiTE"
> +DIRECTFB2_LITE_SITE_METHOD = git
github macro.
> +DIRECTFB2_LITE_LICENSE = LGPL-2.1
LGPL2.1+
> diff --git a/package/directfb2-media/Config.in b/package/directfb2-media/Config.in
> new file mode 100644
> index 0000000000..1a0e09d077
> --- /dev/null
> +++ b/package/directfb2-media/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_DIRECTFB2_MEDIA
> + bool "directfb2-media"
> + depends on BR2_PACKAGE_DIRECTFB2
> + help
> + DirectFB2-media contains additional font/image/music/video
> + providers for DirectFB2.
URL of the upstream project.
> diff --git a/package/directfb2-media/directfb2-media.mk b/package/directfb2-media/directfb2-media.mk
> new file mode 100644
> index 0000000000..50efa168d9
> --- /dev/null
> +++ b/package/directfb2-media/directfb2-media.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# directfb2-media
> +#
> +################################################################################
> +
> +DIRECTFB2_MEDIA_VERSION = 8f8cb02a3d67a3eb9726ca2927061e2697b7f2de
> +DIRECTFB2_MEDIA_SITE = "https://github.com/directfb2/DirectFB2-media"
> +DIRECTFB2_MEDIA_SITE_METHOD = git
github macro.
> +DIRECTFB2_MEDIA_LICENSE = LGPL-2.1
LGPL-2.1+
> diff --git a/package/directfb2-tools/Config.in b/package/directfb2-tools/Config.in
> new file mode 100644
> index 0000000000..f4d16596bc
> --- /dev/null
> +++ b/package/directfb2-tools/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_DIRECTFB2_TOOLS
> + bool "directfb2-tools"
> + depends on BR2_PACKAGE_DIRECTFB2
> + help
> + DirectFB2-tools contains various DirectFB2 utilities.
URL of the upstream project.
> diff --git a/package/directfb2-tools/directfb2-tools.mk b/package/directfb2-tools/directfb2-tools.mk
> new file mode 100644
> index 0000000000..7930159f2b
> --- /dev/null
> +++ b/package/directfb2-tools/directfb2-tools.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# directfb2-tools
> +#
> +################################################################################
> +
> +DIRECTFB2_TOOLS_VERSION = 679838c281cbe7849011f7f6db1c815167c44fee
> +DIRECTFB2_TOOLS_SITE = "https://github.com/directfb2/DirectFB2-tools"
> +DIRECTFB2_TOOLS_SITE_METHOD = git
github macro.
> +DIRECTFB2_TOOLS_LICENSE = GPL-2.0
GPL-2.0+
> diff --git a/package/directfb2/Config.in b/package/directfb2/Config.in
> new file mode 100644
> index 0000000000..6ef6e69a07
> --- /dev/null
> +++ b/package/directfb2/Config.in
> @@ -0,0 +1,70 @@
> +menuconfig BR2_PACKAGE_DIRECTFB2
> + bool "DirectFB2"
Just bool "directfb2"
And in fact, please do that for all packages: the bool string should be
exactly the name of the package.
> + default n
Not needed, "default n" is the default.
> + help
> + DirectFB2 is a fork of DirectFB (Direct Frame Buffer) whose
> + purpose is to preserve and maintain the DirectFB graphics
> + backend, particularly for use on embedded systems.
> +
> + The official DirectFB2 website can be visited via
> + https://directfb2.github.io/
> +
> +if BR2_PACKAGE_DIRECTFB2
> +
> +menu "DirectFB2 Options"
> +
> +config BR2_PACKAGE_DIRECTFB2_DRMKMS
> + bool "Enable Linux DRM/KMS support"
No dependency on any library?
I see:
#include <xf86drm.h>
#include <xf86drmMode.h>
so presumably it needs some libraries?
> +config BR2_PACKAGE_DIRECTFB2_FBDEV
> + bool "Enable Linux Framebuffer support"
> +
> +config BR2_PACKAGE_DIRECTFB2_LINUX_INPUT
> + bool "Enable Linux input support"
> +
> +if BR2_X86_CPU_HAS_MMX
> +config BR2_PACKAGE_DIRECTFB2_MMX
> + bool "Enable MMX assembly support"
> + default y
No need to have an option, just enable MMX support in the .mk file when
BR2_X86_CPU_HAS_MMX=y.
> +config BR2_PACKAGE_DIRECTFB2_MULTI
> + bool "Enable multi application support"
> +
> +config BR2_PACKAGE_DIRECTFB2_MULTI_KERNEL
> + bool "Enable Linux fusion device support for multi application"
> + select BR2_PACKAGE_DIRECTFB2_MULTI
This option BR2_PACKAGE_DIRECTFB2_MULTI does not exist in your submission.
> +# if BR2_ARM_CPU_HAS_NEON
> +# config BR2_PACKAGE_DIRECTFB2_NEON
> +# bool "Enable NEON assembly support"
> +# default y
> +# endif # BR2_ARM_CPU_HAS_NEON
> +#
> +# DirectFB2 currently has issues enabling NEON. For more details, see:
> +# https://github.com/directfb2/DirectFB2/issues/142
Then, please don't include any code related to that, and just disable
NEON support in the .mk file.
> +menu "DirectFB2 Applications"
> +source "package/directfb2-examples/Config.in"
> +source "package/dfbterm/Config.in"
> +endmenu
> +
> +menu "DirectFB2 Utilities"
> +source "package/directfb2-media/Config.in"
> +source "package/directfb2-tools/Config.in"
> +source "package/directfb2-csource/Config.in"
> +source "package/directfb2-lite/Config.in"
> +endmenu
As said previously, these includes should go in package/Config.in.
> diff --git a/package/directfb2/directfb2.mk b/package/directfb2/directfb2.mk
> new file mode 100644
> index 0000000000..197ff38632
> --- /dev/null
> +++ b/package/directfb2/directfb2.mk
> @@ -0,0 +1,62 @@
> +################################################################################
> +#
> +# directfb2
> +#
> +################################################################################
> +
> +DIRECTFB2_VERSION = 2952d1d16b546be09e1cbb5da5e0c718d8f5ee32
> +DIRECTFB2_SITE = "https://github.com/directfb2/DirectFB2"
> +DIRECTFB2_SITE_METHOD = git
github macro.
> +DIRECTFB2_LICENSE = LGPL-2.1
LGPL-2.1+
> +DIRECTFB2_LICENSE_FILES = COPYING
> +DIRECTFB2_INSTALL_STAGING = YES
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_DRMKMS),y)
> +DIRECTFB2_CONF_OPTS += -Ddrmkms=true
> +endif
Please disable explicitly:
else
DIRECTFB2_CONF_OPTS += -Ddrmkms=false
endif
Also as stated above, doesn't this require an external library?
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_FBDEV),y)
> +DIRECTFB2_CONF_OPTS += -Dfbdev=true
> +endif
Disable explicitly.
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_LINUX_INPUT),y)
> +DIRECTFB2_CONF_OPTS += -Dlinux_input=true
> +endif
Ditto.
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_MMX),y)
> +DIRECTFB2_CONF_OPTS += -Dmmx=true
> +else ifeq ($(BR2_PACKAGE_DIRECTFB2_MMX),n)
> +DIRECTFB2_CONF_OPTS += -Dmmx=false
> +endif
Directly use BR2_X86_CPU_HAS_MMX.
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_MULTI),y)
> +DIRECTFB2_CONF_OPTS += -Dmulti=true
> +endif
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_MULTI_KERNEL),y)
> +DIRECTFB2_CONF_OPTS += -Dmulti-kernel=true
> +endif
As explained above: this doesn't work, you didn't add the package that
was needed.
> +
> +# ifeq ($(BR2_PACKAGE_DIRECTFB2_NEON),y)
> +# DIRECTFB2_CONF_OPTS += -Dneon=true
> +# else ifeq ($(BR2_PACKAGE_DIRECTFB2_NEON),y)
> +# DIRECTFB2_CONF_OPTS += -Dneon=false
> +# endif
> +#
> +# DirectFB2 currently has issues enabling NEON. For more details, see:
> +# https://github.com/directfb2/DirectFB2/issues/142
> +DIRECTFB2_CONF_OPTS += -Dneon=false
Just keep this, and not the commented condition above.
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_NETWORK),y)
> +DIRECTFB2_CONF_OPTS += -Dnetwork=true
> +endif
Disable explicitly.
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_SENTINELS),y)
> +DIRECTFB2_CONF_OPTS += -Dsentinels=true
> +endif
Same.
> +
> +ifeq ($(BR2_PACKAGE_DIRECTFB2_SMOOTH_SCALING),y)
> +DIRECTFB2_CONF_OPTS += -Dsmooth-scaling=true
> +endif
Same.
Could you have a look at those review comments and send a new
iteraiton? Most of them are fairly trivial things. Really the only
important consideration is whether we want package/directfb2 as a new
separate package or if we want to upgrade package/directfb.
Thanks a lot for your contribution!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread