From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/unbound: allow TFO for uClibc-ng, add user
Date: Mon, 12 Aug 2024 21:20:45 +0200 [thread overview]
Message-ID: <20240812212045.46e44a9c@windsurf> (raw)
In-Reply-To: <ZrmalIJlys/dTgYy@waldemar-brodkorb.de>
On Mon, 12 Aug 2024 07:16:04 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> uClibc-ng toolchains have MSG_FASTOPEN since 2018 so no need
> to disable support for TCP fastopen.
>
> Add the missing unbound user, which prevents unbound daemon
> startup on boot.
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> package/unbound/unbound.mk | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
Thanks for this patch, but could you make it two patches? Indeed,
adding the unbound user is a fix, so we will want to backport it, while
the other one is really a "new" feature.
Also, could you change to "enable tfo-client", because TFO server was
already enabled, it's really TFO client that wasn't.
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-12 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 5:16 [Buildroot] [PATCH] package/unbound: allow TFO for uClibc-ng, add user Waldemar Brodkorb
2024-08-12 19:20 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812212045.46e44a9c@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox