[Buildroot] [PATCH] package/unbound: allow TFO for uClibc-ng, add user

[Buildroot] [PATCH] package/unbound: allow TFO for uClibc-ng, add user

[Waldemar Brodkorb]

uClibc-ng toolchains have MSG_FASTOPEN since 2018 so no need
to disable support for TCP fastopen.

Add the missing unbound user, which prevents unbound daemon
startup on boot.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/unbound/unbound.mk | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/package/unbound/unbound.mk b/package/unbound/unbound.mk
index ff0262bef1..d46317ed99 100644
--- a/package/unbound/unbound.mk
+++ b/package/unbound/unbound.mk
@@ -18,18 +18,11 @@ UNBOUND_CONF_OPTS = \
 	--with-pidfile=/var/run/unbound.pid \
 	--with-rootkey-file=/etc/unbound/root.key \
 	--enable-tfo-server \
+	--enable-tfo-client \
 	--with-libevent=$(STAGING_DIR)/usr \
 	--with-libexpat=$(STAGING_DIR)/usr \
 	--with-ssl=$(STAGING_DIR)/usr
 
-# uClibc-ng does not have MSG_FASTOPEN
-# so TCP Fast Open client mode disabled for it
-ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
-UNBOUND_CONF_OPTS += --disable-tfo-client
-else
-UNBOUND_CONF_OPTS += --enable-tfo-client
-endif
-
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),y)
 UNBOUND_CONF_OPTS += --with-pthreads
 else
@@ -54,4 +47,8 @@ define UNBOUND_INSTALL_INIT_SYSV
 		$(TARGET_DIR)/etc/init.d/S70unbound
 endef
 
+define UNBOUND_USERS
+	unbound -1 unbound -1 * /etc/unbound - - unbound daemon
+endef
+
 $(eval $(autotools-package))
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/unbound: allow TFO for uClibc-ng, add user

[Thomas Petazzoni via buildroot]

On Mon, 12 Aug 2024 07:16:04 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:

> uClibc-ng toolchains have MSG_FASTOPEN since 2018 so no need
> to disable support for TCP fastopen.
> 
> Add the missing unbound user, which prevents unbound daemon
> startup on boot.
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/unbound/unbound.mk | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)

Thanks for this patch, but could you make it two patches? Indeed,
adding the unbound user is a fix, so we will want to backport it, while
the other one is really a "new" feature.

Also, could you change to "enable tfo-client", because TFO server was
already enabled, it's really TFO client that wasn't.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot