* [Buildroot] [PATCH 1/1] package/libgpg-error: needs MMU
@ 2024-08-11 14:13 Julien Olivain
2024-08-12 20:30 ` Thomas Petazzoni via buildroot
2024-09-16 8:31 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Julien Olivain @ 2024-08-11 14:13 UTC (permalink / raw)
To: buildroot; +Cc: Julien Olivain, Marcus Folkesson
libgpg-error imported code using fork() in commit [1] and enabled it
soon after in [2]. Those commits were first included in libgpg-error
version 1.28.
For reference, the libgpg-error Buildroot package was updated to that
version in commit [3].
When Buildroot configuration has no MMU support (e.g. BR2_USE_MMU is
not set), libgpg-error fails to build with error:
/build/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: ./.libs/libgpg-error.a(libgpg_error_la-spawn-posix.o): in function '_gpgrt_process_spawn':
spawn-posix.c:(.text+0x630): undefined reference to 'fork'
This issue can be observed with the command:
utils/test-pkg -a -p libgpg-error
It will show few build failures:
...
bootlin-armv7m-uclibc [ 6/41]: FAILED
...
bootlin-m68k-5208-uclibc [ 8/41]: FAILED
...
This commit fixes the issue by adding the package dependency on
BR2_USE_MMU.
This commit also propagates this dependency on the libgcrypt and
libksba packages. They are requiring libgpg-error but had no
dependency on MMU.
Finally, for completeness, for all other packages requiring
libgpg-error which already had the dependency on BR2_USE_MMU, the
corresponding comment is updated to reflect that change. Namely: gcr,
gnupg2, libassuan, libgpgme, libostree, netatalk, pinentry, vpnc, and
wireshark. Note: for simplifity, few packages already depending on
BR2_USE_MMU but having libgpg-error as an optional dependency are not
updated (libjcat, mutt and opkg).
Fixes:
http://autobuild.buildroot.org/results/dbc82ba08e6a30c2f558c8c36ad7eeb0e3cab090/
http://autobuild.buildroot.org/results/074a803de0f48cd86b9135cca50f136cccf1bcea/
http://autobuild.buildroot.org/results/4c1966a71020af31c1dc1b0a13a3928c84e75874/
...and many others.
[1] https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgpg-error.git;a=commitdiff;h=8f41cc23b12485404203be5881aaaadb78696b4d
[2] https://git.gnupg.org/cgi-bin/gitweb.cgi?p=libgpg-error.git;a=commitdiff;h=1865c0ba1769b407a3c504f1ab0a4278704a9fc1
[3] https://gitlab.com/buildroot.org/buildroot/-/commit/692d191c8b0b3c86022e6a6ba3bd2d8f53b39f03
Signed-off-by: Julien Olivain <ju.o@free.fr>
---
package/gcr/Config.in | 2 +-
package/gnupg2/Config.in | 2 +-
package/libassuan/Config.in | 2 +-
package/libgcrypt/Config.in | 1 +
package/libgpg-error/Config.in | 1 +
package/libgpgme/Config.in | 2 +-
package/libksba/Config.in | 1 +
package/libostree/Config.in | 2 +-
package/netatalk/Config.in | 2 +-
package/pinentry/Config.in | 2 +-
package/vpnc/Config.in | 2 +-
package/wireshark/Config.in | 2 +-
12 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/package/gcr/Config.in b/package/gcr/Config.in
index dbc22cf478..e4a90a5550 100644
--- a/package/gcr/Config.in
+++ b/package/gcr/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_GCR
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt -> libgpg-error
depends on BR2_USE_WCHAR # libglib2
depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
- depends on BR2_USE_MMU # libglib2
+ depends on BR2_USE_MMU # libglib2, libgpg-error
depends on !BR2_STATIC_LIBS # p11-kit
select BR2_PACKAGE_GNUPG2 if BR2_PACKAGE_GNUPG2_DEPENDS && !BR2_PACKAGE_GNUPG # runtime
select BR2_PACKAGE_GNUPG if !BR2_PACKAGE_GNUPG2_DEPENDS # runtime
diff --git a/package/gnupg2/Config.in b/package/gnupg2/Config.in
index 043d53554c..b282520dd8 100644
--- a/package/gnupg2/Config.in
+++ b/package/gnupg2/Config.in
@@ -11,7 +11,7 @@ config BR2_PACKAGE_GNUPG2_DEPENDS
default y
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgpg-error
depends on BR2_TOOLCHAIN_HAS_THREADS # libnpth
- depends on BR2_USE_MMU # libassuan, libnpth
+ depends on BR2_USE_MMU # libassuan, libgpg-error, libnpth
depends on !BR2_STATIC_LIBS
config BR2_PACKAGE_GNUPG2
diff --git a/package/libassuan/Config.in b/package/libassuan/Config.in
index 012e65c4b6..8e860e86a1 100644
--- a/package/libassuan/Config.in
+++ b/package/libassuan/Config.in
@@ -1,7 +1,7 @@
config BR2_PACKAGE_LIBASSUAN
bool "libassuan"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgpg-error
- depends on BR2_USE_MMU # fork()
+ depends on BR2_USE_MMU # fork(), libgpg-error
select BR2_PACKAGE_LIBGPG_ERROR
help
Libassuan is a small library implementing the so-called
diff --git a/package/libgcrypt/Config.in b/package/libgcrypt/Config.in
index d3e5d4f7a2..a4df65a37c 100644
--- a/package/libgcrypt/Config.in
+++ b/package/libgcrypt/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_LIBGCRYPT
bool "libgcrypt"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgpg-error
+ depends on BR2_USE_MMU # libgpg-error
select BR2_PACKAGE_LIBGPG_ERROR
help
LibGCrypt is GNU's basic cryptographic library.
diff --git a/package/libgpg-error/Config.in b/package/libgpg-error/Config.in
index 5a2c14ead8..8e466e86e0 100644
--- a/package/libgpg-error/Config.in
+++ b/package/libgpg-error/Config.in
@@ -19,6 +19,7 @@ config BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
config BR2_PACKAGE_LIBGPG_ERROR
bool "libgpg-error"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
+ depends on BR2_USE_MMU # fork()
help
Libgpg-error is a small library with error codes and
descriptions shared by most GnuPG related software.
diff --git a/package/libgpgme/Config.in b/package/libgpgme/Config.in
index 16ce27d0ef..51c4f228e4 100644
--- a/package/libgpgme/Config.in
+++ b/package/libgpgme/Config.in
@@ -1,7 +1,7 @@
config BR2_PACKAGE_LIBGPGME
bool "libgpgme"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgpg-error
- depends on BR2_USE_MMU # libassuan
+ depends on BR2_USE_MMU # libassuan, libgpg-error
select BR2_PACKAGE_GNUPG2 if BR2_PACKAGE_GNUPG2_DEPENDS && !BR2_PACKAGE_GNUPG # runtime
select BR2_PACKAGE_GNUPG if !BR2_PACKAGE_GNUPG2_DEPENDS # runtime
select BR2_PACKAGE_LIBGPG_ERROR
diff --git a/package/libksba/Config.in b/package/libksba/Config.in
index 1f25d6dbe2..7d764c2461 100644
--- a/package/libksba/Config.in
+++ b/package/libksba/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_LIBKSBA
bool "libksba"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgpg-error
+ depends on BR2_USE_MMU # libgpg-error
select BR2_PACKAGE_LIBGPG_ERROR
help
CMS and X.509 library
diff --git a/package/libostree/Config.in b/package/libostree/Config.in
index 49eed6517e..847a9ed17b 100644
--- a/package/libostree/Config.in
+++ b/package/libostree/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_LIBOSTREE
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgpgme, libgpg-error
depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
depends on BR2_USE_WCHAR # libglib2
- depends on BR2_USE_MMU # e2fsprogs, libglib2, libgpgme
+ depends on BR2_USE_MMU # e2fsprogs, libglib2, libgpgme, libgpg-error
# doesn't build with musl due to lack of TEMP_FAILURE_RETRY()
depends on !BR2_TOOLCHAIN_USES_MUSL
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8 # loop_config
diff --git a/package/netatalk/Config.in b/package/netatalk/Config.in
index 225d5891c7..60189f320e 100644
--- a/package/netatalk/Config.in
+++ b/package/netatalk/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_NETATALK
bool "netatalk"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgpg-error
depends on BR2_TOOLCHAIN_HAS_THREADS
- depends on BR2_USE_MMU # fork()
+ depends on BR2_USE_MMU # fork(), libgpg-error
depends on !BR2_STATIC_LIBS
select BR2_PACKAGE_BERKELEYDB
select BR2_PACKAGE_OPENSSL
diff --git a/package/pinentry/Config.in b/package/pinentry/Config.in
index bd5e3af5a1..401c60323d 100644
--- a/package/pinentry/Config.in
+++ b/package/pinentry/Config.in
@@ -1,7 +1,7 @@
menuconfig BR2_PACKAGE_PINENTRY
bool "pinentry"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgpg-error
- depends on BR2_USE_MMU # libassuan
+ depends on BR2_USE_MMU # libassuan, libgpg-error
select BR2_PACKAGE_LIBASSUAN
select BR2_PACKAGE_LIBGPG_ERROR
# At least one backend is needed to avoid build breakage
diff --git a/package/vpnc/Config.in b/package/vpnc/Config.in
index 6455b0d87a..b71c0e613e 100644
--- a/package/vpnc/Config.in
+++ b/package/vpnc/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_VPNC
bool "vpnc"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
depends on !BR2_STATIC_LIBS # gnutls
- depends on BR2_USE_MMU # fork()
+ depends on BR2_USE_MMU # fork(), libgpg-error
depends on BR2_USE_WCHAR # gnutls
select BR2_PACKAGE_LIBGCRYPT
select BR2_PACKAGE_LIBGPG_ERROR
diff --git a/package/wireshark/Config.in b/package/wireshark/Config.in
index 8b05599ecb..ce9d41bf00 100644
--- a/package/wireshark/Config.in
+++ b/package/wireshark/Config.in
@@ -2,7 +2,7 @@ config BR2_PACKAGE_WIRESHARK
bool "wireshark"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt -> libgpg-error
depends on !BR2_STATIC_LIBS
- depends on BR2_USE_MMU # fork(), glib2
+ depends on BR2_USE_MMU # fork(), glib2, libgcrypt -> libgpg-error
depends on BR2_USE_WCHAR # glib2
depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
depends on BR2_INSTALL_LIBSTDCPP
--
2.46.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/libgpg-error: needs MMU
2024-08-11 14:13 [Buildroot] [PATCH 1/1] package/libgpg-error: needs MMU Julien Olivain
@ 2024-08-12 20:30 ` Thomas Petazzoni via buildroot
2024-09-16 8:31 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-08-12 20:30 UTC (permalink / raw)
To: Julien Olivain; +Cc: Marcus Folkesson, buildroot
On Sun, 11 Aug 2024 16:13:56 +0200
Julien Olivain <ju.o@free.fr> wrote:
> libgpg-error imported code using fork() in commit [1] and enabled it
> soon after in [2]. Those commits were first included in libgpg-error
> version 1.28.
>
> For reference, the libgpg-error Buildroot package was updated to that
> version in commit [3].
>
> When Buildroot configuration has no MMU support (e.g. BR2_USE_MMU is
> not set), libgpg-error fails to build with error:
>
> /build/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: ./.libs/libgpg-error.a(libgpg_error_la-spawn-posix.o): in function '_gpgrt_process_spawn':
> spawn-posix.c:(.text+0x630): undefined reference to 'fork'
>
> This issue can be observed with the command:
>
> utils/test-pkg -a -p libgpg-error
>
> It will show few build failures:
>
> ...
> bootlin-armv7m-uclibc [ 6/41]: FAILED
> ...
> bootlin-m68k-5208-uclibc [ 8/41]: FAILED
> ...
>
> This commit fixes the issue by adding the package dependency on
> BR2_USE_MMU.
>
> This commit also propagates this dependency on the libgcrypt and
> libksba packages. They are requiring libgpg-error but had no
> dependency on MMU.
>
> Finally, for completeness, for all other packages requiring
> libgpg-error which already had the dependency on BR2_USE_MMU, the
> corresponding comment is updated to reflect that change. Namely: gcr,
> gnupg2, libassuan, libgpgme, libostree, netatalk, pinentry, vpnc, and
> wireshark.
Thanks for doing this, but it seems to me that you forgot a number of
packages. Basically all packages that "select BR2_PACKAGE_LIBGPG_ERROR"
need to be fixed. And then once you have this list of packages, you
need check all packages that "select" those packages, and so on
recursively. For example, you forgot package/crda, or package/libbdplus.
But in fact. BR2_USE_MMU is an architecture dependency, so simply
update:
config BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
to add a "depends on BR2_USE_MMU". This will magically propagate it.
> Note: for simplifity, few packages already depending on
> BR2_USE_MMU but having libgpg-error as an optional dependency are not
> updated (libjcat, mutt and opkg).
Using "optional dependency" here confused me. When I hear "optional
dependency", I usually think about:
ifeq ($(BR2_PACKAGE_LIBGPG_ERROR),y)
FOOBAR_CONF_OPTS += --enable-bla
FOOBAR_DEPENDENCIES += libgpg-error
else
FOOBAR_CONF_OPTS += --disable-bla
endif
So indeed, for libjcat, it's an optional dependency and in such a case,
we really don't care as BR2_PACKAGE_LIBGPG_ERROR will only be "y" if it
can be enabled.
However, for opkg there's a suboption that selects
BR2_PACKAGE_LIBGPG_ERROR, but the main BR2_PACKAGE_OPKG option already
depends on BR2_USE_MMU. I think you should distinguish the two cases,
but the first one really isn't relevant at all in the discussion, while
the second case matters.
Could you rework your patch to simply put the dep into
BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS ?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/libgpg-error: needs MMU
2024-08-11 14:13 [Buildroot] [PATCH 1/1] package/libgpg-error: needs MMU Julien Olivain
2024-08-12 20:30 ` Thomas Petazzoni via buildroot
@ 2024-09-16 8:31 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-09-16 8:31 UTC (permalink / raw)
To: Julien Olivain; +Cc: Marcus Folkesson, buildroot
>>>>> "Julien" == Julien Olivain <ju.o@free.fr> writes:
> libgpg-error imported code using fork() in commit [1] and enabled it
> soon after in [2]. Those commits were first included in libgpg-error
> version 1.28.
> For reference, the libgpg-error Buildroot package was updated to that
> version in commit [3].
> When Buildroot configuration has no MMU support (e.g. BR2_USE_MMU is
> not set), libgpg-error fails to build with error:
> /build/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: ./.libs/libgpg-error.a(libgpg_error_la-spawn-posix.o): in function '_gpgrt_process_spawn':
> spawn-posix.c:(.text+0x630): undefined reference to 'fork'
> This issue can be observed with the command:
> utils/test-pkg -a -p libgpg-error
> It will show few build failures:
Committed to 2024.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-16 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-11 14:13 [Buildroot] [PATCH 1/1] package/libgpg-error: needs MMU Julien Olivain
2024-08-12 20:30 ` Thomas Petazzoni via buildroot
2024-09-16 8:31 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox