[Buildroot] [PATCH] package/libgtk4: missing dependencies

[Buildroot] [PATCH] package/libgtk4: missing dependencies

[Francois Perrad]

libgtk4 needs png & pdf support (like libgtk3)

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/libgtk4/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/libgtk4/Config.in b/package/libgtk4/Config.in
index af7f57b80..3a7836fe5 100644
--- a/package/libgtk4/Config.in
+++ b/package/libgtk4/Config.in
@@ -23,6 +23,8 @@ config BR2_PACKAGE_LIBGTK4
 	# https://gitlab.gnome.org/GNOME/gtk/-/issues/6866.
 	depends on BR2_PACKAGE_HAS_LIBEGL
 	select BR2_PACKAGE_CAIRO
+	select BR2_PACKAGE_CAIRO_PNG
+	select BR2_PACKAGE_CAIRO_ZLIB
 	select BR2_PACKAGE_GDK_PIXBUF
 	select BR2_PACKAGE_GRAPHENE
 	select BR2_PACKAGE_LIBEPOXY
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/libgtk4: missing dependencies

[Thomas Petazzoni via buildroot]

On Wed, 14 Aug 2024 08:39:31 +0200
Francois Perrad <francois.perrad@gadz.org> wrote:

> libgtk4 needs png & pdf support (like libgtk3)
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Could you provide a bit more details about the issues encountered?

First build issue I had is:

Found CMake: /home/thomas/buildroot/buildroot/output/host/bin/cmake (3.30.0)
Run-time dependency libpng found: NO (tried pkgconfig and cmake)
Run-time dependency png found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency libpng

which gets solved by enabling LIBPNG (not PNG support in Cairo). That
being said, Cairo's header file complain with a warning when no PNG
support is enabled:

/home/thomas/buildroot/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/cairo/cairo.h:2597:5: warning: "CAIRO_HAS_PNG_FUNCTIO
NS" is not defined, evaluates to 0 [-Wundef]

This is a bug that should be reported to upstream Cairo.

Then second build issue was an include of <cairo-pdf.h>, which means
PDF support in Cairo is needed, but that should have triggered an issue
at configure time, not at build time. This bug should be reported to
gtk4 upstream.

We try as much as possible to "go the extra mile" and not just paper
over the problem, but provide bug reports/fixes upstream where needed.

Could you have a look into this?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot