[Buildroot] [PATCH] configs/zynqmp_zcu10*_defconfig: fix parallel build of U-Boot

[Buildroot] [PATCH] configs/zynqmp_zcu10*_defconfig: fix parallel build of U-Boot

[Brandon Maier via buildroot]

When building these boards with BR2_PER_PACKAGE_DIRECTORIES enabled, the
following error occurs from U-Boot.

  tools/mkeficapsule.c:18:10: fatal error: uuid/uuid.h: No such file or directory
     18 | #include <uuid/uuid.h>
        |          ^~~~~~~~~~~~~

The U-Boot defconfig these boards use 'xilinx_zynqmp_virt' enables
CONFIG_MKEFICAPSULE, which requires util-linux.

This doesn't fail when BR2_PER_PACKAGE_DIRECTORIES is disabled. This is
because host-e2fsprogs requires host-util-linux, and host-util-linux
always builds before host-uboot when single-threaded.

Signed-off-by: Brandon Maier <brandon.maier@collins.com>
---
 configs/zynqmp_zcu102_defconfig | 1 +
 configs/zynqmp_zcu104_defconfig | 1 +
 configs/zynqmp_zcu106_defconfig | 1 +
 3 files changed, 3 insertions(+)

diff --git a/configs/zynqmp_zcu102_defconfig b/configs/zynqmp_zcu102_defconfig
index 3f1726a13f..df5eba7ca0 100644
--- a/configs/zynqmp_zcu102_defconfig
+++ b/configs/zynqmp_zcu102_defconfig
@@ -27,6 +27,7 @@ BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=zynqmp-zcu102-rev1.0"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin"
 BR2_TARGET_UBOOT_ZYNQMP=y
diff --git a/configs/zynqmp_zcu104_defconfig b/configs/zynqmp_zcu104_defconfig
index b6d943333f..793a677ab2 100644
--- a/configs/zynqmp_zcu104_defconfig
+++ b/configs/zynqmp_zcu104_defconfig
@@ -27,6 +27,7 @@ BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=zynqmp-zcu104-revC"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin"
 BR2_TARGET_UBOOT_ZYNQMP=y
diff --git a/configs/zynqmp_zcu106_defconfig b/configs/zynqmp_zcu106_defconfig
index 970ed40d2c..fdf5e80795 100644
--- a/configs/zynqmp_zcu106_defconfig
+++ b/configs/zynqmp_zcu106_defconfig
@@ -27,6 +27,7 @@ BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=zynqmp-zcu106-rev1.0"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin"
 BR2_TARGET_UBOOT_ZYNQMP=y

---
base-commit: 48e7affffa06bbe23a1cd190d0a765956cf179b0
change-id: 20240815-zynqmp-zcu10x-defconfig-fix-parallel-build-of-uboot-66c49269bcf0

Best regards,
-- 
Brandon Maier <brandon.maier@collins.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] configs/zynqmp_zcu10*_defconfig: fix parallel build of U-Boot

[Frager, Neal via buildroot]

[-- Attachment #1.1: Type: text/plain, Size: 880 bytes --]

Hi Brandon,

> When building these boards with BR2_PER_PACKAGE_DIRECTORIES enabled, the
following error occurs from U-Boot.

>  tools/mkeficapsule.c:18:10: fatal error: uuid/uuid.h: > No such file or directory
 >    18 | #include <uuid/uuid.h>
>        |          ^~~~~~~~~~~~~

> The U-Boot defconfig these boards use 'xilinx_zynqmp_virt' enables
> CONFIG_MKEFICAPSULE, which requires util-linux.

> This doesn't fail when BR2_PER_PACKAGE_DIRECTORIES is disabled. This is
> because host-e2fsprogs requires host-util-linux, and host-util-linux
> always builds before host-uboot when single-threaded.

> Signed-off-by: Brandon Maier > <brandon.maier@collins.com>

Thank you for this.

Could you also submit a patch for the kria defconfigs?

I am sure they need this too.

Reviewed-by: Neal Frager <neal.frager@amd.com>

Best regards,
Neal Frager
AMD


[-- Attachment #1.2: Type: text/html, Size: 2191 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] configs/zynqmp_zcu10*_defconfig: fix parallel build of U-Boot

[Brandon Maier via buildroot]

Hi Neal,

On Thu Aug 15, 2024 at 4:13 PM UTC, Frager, Neal via buildroot wrote:
> Hi Brandon,
>
> > When building these boards with BR2_PER_PACKAGE_DIRECTORIES enabled, the
> following error occurs from U-Boot.
>
> >  tools/mkeficapsule.c:18:10: fatal error: uuid/uuid.h: > No such file or directory
>  >    18 | #include <uuid/uuid.h>
> >        |          ^~~~~~~~~~~~~
>
> > The U-Boot defconfig these boards use 'xilinx_zynqmp_virt' enables
> > CONFIG_MKEFICAPSULE, which requires util-linux.
>
> > This doesn't fail when BR2_PER_PACKAGE_DIRECTORIES is disabled. This is
> > because host-e2fsprogs requires host-util-linux, and host-util-linux
> > always builds before host-uboot when single-threaded.
>
> > Signed-off-by: Brandon Maier > <brandon.maier@collins.com>
>
> Thank you for this.
>
> Could you also submit a patch for the kria defconfigs?
>
> I am sure they need this too.

You are correct, they don't enable CONFIG_MKEFICAPSULE directly, but
enable CONFIG_EFI_CAPSULE_ON_DISK which enables it.

Sent a second patch for the kria boards.

Thanks,
Brandon Maier

>
> Reviewed-by: Neal Frager <neal.frager@amd.com>
>
> Best regards,
> Neal Frager
> AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] configs/zynqmp_zcu10*_defconfig: fix parallel build of U-Boot

[Thomas Petazzoni via buildroot]

On Thu, 15 Aug 2024 14:18:02 +0000
Brandon Maier via buildroot <buildroot@buildroot.org> wrote:

> When building these boards with BR2_PER_PACKAGE_DIRECTORIES enabled, the
> following error occurs from U-Boot.
> 
>   tools/mkeficapsule.c:18:10: fatal error: uuid/uuid.h: No such file or directory
>      18 | #include <uuid/uuid.h>
>         |          ^~~~~~~~~~~~~
> 
> The U-Boot defconfig these boards use 'xilinx_zynqmp_virt' enables
> CONFIG_MKEFICAPSULE, which requires util-linux.
> 
> This doesn't fail when BR2_PER_PACKAGE_DIRECTORIES is disabled. This is
> because host-e2fsprogs requires host-util-linux, and host-util-linux
> always builds before host-uboot when single-threaded.
> 
> Signed-off-by: Brandon Maier <brandon.maier@collins.com>
> ---
>  configs/zynqmp_zcu102_defconfig | 1 +
>  configs/zynqmp_zcu104_defconfig | 1 +
>  configs/zynqmp_zcu106_defconfig | 1 +
>  3 files changed, 3 insertions(+)

I fixed up the commit title, because the issue is not about "fixing
parallel build of U-Boot", but making sure it has the correct
dependencies. And then I applied to master, of course!

Thanks for this contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot