[Buildroot] [PATCH 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS

[Buildroot] [PATCH 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS

[James Hilliard]

Flashrom requires --default-library=both for the cli when building
with BR2_SHARED_LIBS.

As such set --default-library=both instead of disabling it.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/flashrom/flashrom.mk | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/package/flashrom/flashrom.mk b/package/flashrom/flashrom.mk
index 1e7d332dae..030f6816a0 100644
--- a/package/flashrom/flashrom.mk
+++ b/package/flashrom/flashrom.mk
@@ -10,6 +10,7 @@ FLASHROM_LICENSE = GPL-2.0+
 FLASHROM_LICENSE_FILES = COPYING
 FLASHROM_INSTALL_STAGING = YES
 FLASHROM_CONF_OPTS = \
+	-Dclassic_cli=enabled \
 	-Dclassic_cli_print_wiki=disabled \
 	-Dich_descriptors_tool=enabled \
 	-Dtests=disabled \
@@ -78,10 +79,8 @@ endif
 
 FLASHROM_CONF_OPTS += -Dprogrammer=$(subst $(space),$(comma),$(strip $(FLASHROM_PROGRAMMERS)))
 
-ifeq ($(BR2_SHARED_LIBS),)
-FLASHROM_CONF_OPTS += -Dclassic_cli=enabled
-else
-FLASHROM_CONF_OPTS += -Dclassic_cli=disabled
+ifeq ($(BR2_SHARED_LIBS),y)
+FLASHROM_CONF_OPTS += --default-library=both
 endif
 
 $(eval $(meson-package))
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS

[Thomas Petazzoni via buildroot]

Hello,

On Sun, 18 Aug 2024 22:02:13 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Flashrom requires --default-library=both for the cli when building
> with BR2_SHARED_LIBS.
> 
> As such set --default-library=both instead of disabling it.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Thanks for the patch!

Is this fixing a build issue? If so, which one, which defconfig? Or
perhaps an autobuilder failure reference?

When was this problem introduced?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS

[James Hilliard]

[-- Attachment #1.1: Type: text/plain, Size: 1057 bytes --]

On Mon, Aug 19, 2024 at 2:27 AM Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:

> Hello,
>
> On Sun, 18 Aug 2024 22:02:13 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > Flashrom requires --default-library=both for the cli when building
> > with BR2_SHARED_LIBS.
> >
> > As such set --default-library=both instead of disabling it.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
> Thanks for the patch!
>
> Is this fixing a build issue? If so, which one, which defconfig? Or
> perhaps an autobuilder failure reference?
>

It fixes an issue where the flashlib cli was not being built at all,
only the library was for BR2_SHARED_LIBS systems.


>
> When was this problem introduced?
>

When bumping flashrom to version 1.4.0-rc2:
https://github.com/buildroot/buildroot/commit/8637884057ddc3c1aeb9f0dd285fc6fcf378c26b


>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 2045 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS

[Thomas Petazzoni via buildroot]

Hello James,

On Mon, 19 Aug 2024 02:31:02 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> > Is this fixing a build issue? If so, which one, which defconfig? Or
> > perhaps an autobuilder failure reference?
> 
> It fixes an issue where the flashlib cli was not being built at all,
> only the library was for BR2_SHARED_LIBS systems.

So there is no build issue, but parts that are expect to be built are
not built?

> > When was this problem introduced?
> 
> When bumping flashrom to version 1.4.0-rc2:
> https://github.com/buildroot/buildroot/commit/8637884057ddc3c1aeb9f0dd285fc6fcf378c26b

Thanks. Could you clarify both aspects in the commit log?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS

[James Hilliard]

[-- Attachment #1.1: Type: text/plain, Size: 1201 bytes --]

On Mon, Aug 19, 2024 at 2:39 AM Thomas Petazzoni <
thomas.petazzoni@bootlin.com> wrote:

> Hello James,
>
> On Mon, 19 Aug 2024 02:31:02 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > > Is this fixing a build issue? If so, which one, which defconfig? Or
> > > perhaps an autobuilder failure reference?
> >
> > It fixes an issue where the flashlib cli was not being built at all,
> > only the library was for BR2_SHARED_LIBS systems.
>
> So there is no build issue, but parts that are expect to be built are
> not built?
>

This fixes the bug which was the reason the cli was originally disabled.


>
> > > When was this problem introduced?
> >
> > When bumping flashrom to version 1.4.0-rc2:
> >
> https://github.com/buildroot/buildroot/commit/8637884057ddc3c1aeb9f0dd285fc6fcf378c26b
>
> Thanks. Could you clarify both aspects in the commit log?
>

Added some more details in v2:
https://patchwork.ozlabs.org/project/buildroot/patch/20240819084352.905082-1-james.hilliard1@gmail.com/


>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 2281 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot