* Re: [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig
2024-08-12 5:21 [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig Neal Frager via buildroot
@ 2024-08-12 13:02 ` Brandon Maier via buildroot
2024-08-19 8:39 ` Luca Ceresoli via buildroot
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Brandon Maier via buildroot @ 2024-08-12 13:02 UTC (permalink / raw)
To: Neal Frager, buildroot
Cc: michal.simek, romain.naour, luca.ceresoli, yann.morin.1998,
thomas.petazzoni
On Mon Aug 12, 2024 at 5:21 AM UTC, Neal Frager via buildroot wrote:
> This patch adds support for Xilinx Versal VEK280 Evaluation Kit.
>
> VEK280 features can be found here:
> https://www.xilinx.com/products/boards-and-kits/vek280.html
>
> The VEK280 requires a patch for the memory node in the dts file because it is
> not currently correct. This patch has been applied to the linux-xlnx repo and
> will be included in the 2024.2 release.
>
> Upstream: https://github.com/Xilinx/linux-xlnx/commit/3c7a97d99bdb3dd6b1f36d7d87d3a3c113dfe2ea
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
Reviewed-by: Brandon Maier <brandon.maier@collins.com>
> ---
> V1->V2:
> - Fixed memory range in dts files for vek280 evaluation board.
> V2->V3:
> - Added Upstream link to vek280 patch.
> V3->V4:
> - Bumped to Linux 6.6.40
> ---
> DEVELOPERS | 1 +
> board/versal/readme.txt | 4 ++
> ...rsal-Fix-vek280-memory-configuration.patch | 47 +++++++++++++++++++
> configs/versal_vek280_defconfig | 44 +++++++++++++++++
> 4 files changed, 96 insertions(+)
> create mode 100644 board/versal/vek280/patches/linux/0001-arm64-versal-Fix-vek280-memory-configuration.patch
> create mode 100644 configs/versal_vek280_defconfig
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 76f7fc5ed6..d07f41fe91 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2403,6 +2403,7 @@ F: board/zynq/
> F: board/zynqmp/
> F: boot/xilinx-prebuilt/
> F: configs/versal_vck190_defconfig
> +F: configs/versal_vek280_defconfig
> F: configs/versal_vpk180_defconfig
> F: configs/zynq_zc702_defconfig
> F: configs/zynq_zc706_defconfig
> diff --git a/board/versal/readme.txt b/board/versal/readme.txt
> index 9cf499b35b..4d8406fb1f 100644
> --- a/board/versal/readme.txt
> +++ b/board/versal/readme.txt
> @@ -4,6 +4,7 @@ Xilinx Versal boards:
> ******************************************
> Supported Versal Boards:
> Xilinx VCK190 board
> +Xilinx VEK280 board
> Xilinx VPK180 board
> ******************************************
>
> @@ -12,6 +13,9 @@ Evaluation board features can be found here with the links below.
> VCK190:
> https://www.xilinx.com/products/boards-and-kits/vck190.html
>
> +VEK280:
> +https://www.xilinx.com/products/boards-and-kits/vek280.html
> +
> VPK180:
> https://www.xilinx.com/products/boards-and-kits/vpk180.html
>
> diff --git a/board/versal/vek280/patches/linux/0001-arm64-versal-Fix-vek280-memory-configuration.patch b/board/versal/vek280/patches/linux/0001-arm64-versal-Fix-vek280-memory-configuration.patch
> new file mode 100644
> index 0000000000..d894ad35d1
> --- /dev/null
> +++ b/board/versal/vek280/patches/linux/0001-arm64-versal-Fix-vek280-memory-configuration.patch
> @@ -0,0 +1,47 @@
> +From: Michal Simek <michal.simek@amd.com>
> +Date: Mon, 15 Jul 2024 08:24:57 +0200
> +Subject: [PATCH] arm64: versal: Fix vek280 memory configuration
> +
> +Board has 12GB total but Vivado wizard supports one channel LPDDR4 4GB
> +configuration (2GB low + 2GB high) or two channel LPDDR 8GB configuration
> +(2GB low + 6GB high). Wiring the remaining 4GB LPDDR can be done via board
> +tab but not available as option in wizard. That's why only describe 8GB by
> +default.
> +
> +Signed-off-by: Michal Simek <michal.simek@amd.com>
> +Signed-off-by: Neal Frager <neal.frager@amd.com>
> +Upstream: https://github.com/Xilinx/linux-xlnx/commit/3c7a97d99bdb3dd6b1f36d7d87d3a3c113dfe2ea
> +---
> + arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts | 2 +-
> + arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts | 2 +-
> + 2 files changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts b/arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts
> +index 1641dc0b5141..ad5d590318e6 100644
> +--- a/arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts
> ++++ b/arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts
> +@@ -19,7 +19,7 @@ / {
> +
> + memory: memory@0 {
> + device_type = "memory";
> +- reg = <0 0 0 0x80000000>, <0x8 0x0 0x7 0x80000000>; /* 32GB */
> ++ reg = <0 0 0 0x80000000>, <0x8 0x80000000 0x1 0x80000000>; /* 2GB + 6GB */
> + };
> +
> + chosen {
> +diff --git a/arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts b/arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts
> +index fda47cd87b3a..80aae8fa4b11 100644
> +--- a/arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts
> ++++ b/arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts
> +@@ -19,7 +19,7 @@ / {
> +
> + memory: memory@0 {
> + device_type = "memory";
> +- reg = <0 0 0 0x80000000>, <0x8 0x0 0x7 0x80000000>; /* 32GB */
> ++ reg = <0 0 0 0x80000000>, <0x8 0x80000000 0x1 0x80000000>; /* 2GB + 6GB */
> + };
> +
> + chosen {
> +--
> +2.43.0
> +
> diff --git a/configs/versal_vek280_defconfig b/configs/versal_vek280_defconfig
> new file mode 100644
> index 0000000000..5831d4d159
> --- /dev/null
> +++ b/configs/versal_vek280_defconfig
> @@ -0,0 +1,44 @@
> +BR2_aarch64=y
> +BR2_cortex_a72=y
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/versal/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/versal/post-image.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="ttyAMA0,115200 mmcblk0p2"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call github,Xilinx,linux-xlnx,xlnx_rebase_v6.6_LTS_merge_6.6.40)/xlnx_rebase_v6.6_LTS_merge_6.6.40.tar.gz"
> +BR2_LINUX_KERNEL_DEFCONFIG="xilinx"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/versal-vek280-revB"
> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +# BR2_TARGET_ROOTFS_TAR is not set
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION="$(call github,Xilinx,arm-trusted-firmware,xlnx_rebase_v2.10_2024.1)/xlnx_rebase_v2.10_2024.1.tar.gz"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="versal"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT=y
> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
> +BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,Xilinx,u-boot-xlnx,xlnx_rebase_v2024.01_2024.1)/xlnx_rebase_v2024.01_2024.1.tar.gz"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="xilinx_versal_virt"
> +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=versal-vek280-revB"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
> +BR2_TARGET_UBOOT_FORMAT_REMAKE_ELF=y
> +BR2_TARGET_UBOOT_FORMAT_DTB=y
> +BR2_TARGET_XILINX_PREBUILT=y
> +BR2_TARGET_XILINX_PREBUILT_VERSION="xilinx_v2024.1"
> +BR2_TARGET_XILINX_PREBUILT_BOARD="vek280"
> +BR2_TARGET_XILINX_PREBUILT_VERSAL=y
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_PACKAGE_HOST_BOOTGEN=y
> +BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
> +BR2_GLOBAL_PATCH_DIR="board/versal/vek280/patches board/xilinx/patches"
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig
2024-08-12 5:21 [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig Neal Frager via buildroot
2024-08-12 13:02 ` Brandon Maier via buildroot
@ 2024-08-19 8:39 ` Luca Ceresoli via buildroot
2024-09-09 8:32 ` Frager, Neal via buildroot
2024-11-03 22:09 ` Julien Olivain
2024-11-04 19:31 ` Arnout Vandecappelle via buildroot
3 siblings, 1 reply; 8+ messages in thread
From: Luca Ceresoli via buildroot @ 2024-08-19 8:39 UTC (permalink / raw)
To: Neal Frager
Cc: brandon.maier, thomas.petazzoni, buildroot, romain.naour,
michal.simek, yann.morin.1998
On Mon, 12 Aug 2024 06:21:01 +0100
Neal Frager <neal.frager@amd.com> wrote:
> This patch adds support for Xilinx Versal VEK280 Evaluation Kit.
>
> VEK280 features can be found here:
> https://www.xilinx.com/products/boards-and-kits/vek280.html
>
> The VEK280 requires a patch for the memory node in the dts file because it is
> not currently correct. This patch has been applied to the linux-xlnx repo and
> will be included in the 2024.2 release.
>
> Upstream: https://github.com/Xilinx/linux-xlnx/commit/3c7a97d99bdb3dd6b1f36d7d87d3a3c113dfe2ea
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig
2024-08-19 8:39 ` Luca Ceresoli via buildroot
@ 2024-09-09 8:32 ` Frager, Neal via buildroot
0 siblings, 0 replies; 8+ messages in thread
From: Frager, Neal via buildroot @ 2024-09-09 8:32 UTC (permalink / raw)
To: Luca Ceresoli
Cc: brandon.maier@collins.com, thomas.petazzoni@bootlin.com,
buildroot@buildroot.org, romain.naour@smile.fr, Simek, Michal,
yann.morin.1998@free.fr
Hello everyone,
> This patch adds support for Xilinx Versal VEK280 Evaluation Kit.
>
> VEK280 features can be found here:
> https://www.xilinx.com/products/boards-and-kits/vek280.html
>
> The VEK280 requires a patch for the memory node in the dts file because it is
> not currently correct. This patch has been applied to the linux-xlnx repo and
> will be included in the 2024.2 release.
>
> Upstream: https://github.com/Xilinx/linux-xlnx/commit/3c7a97d99bdb3dd6b1f36d7d87d3a3c113dfe2ea
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Just a friendly reminder. Thanks!
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig
2024-08-12 5:21 [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig Neal Frager via buildroot
2024-08-12 13:02 ` Brandon Maier via buildroot
2024-08-19 8:39 ` Luca Ceresoli via buildroot
@ 2024-11-03 22:09 ` Julien Olivain
2024-11-04 19:31 ` Arnout Vandecappelle via buildroot
3 siblings, 0 replies; 8+ messages in thread
From: Julien Olivain @ 2024-11-03 22:09 UTC (permalink / raw)
To: Neal Frager
Cc: buildroot, luca.ceresoli, brandon.maier, thomas.petazzoni,
romain.naour, michal.simek, yann.morin.1998
Hi Neal, all,
On 12/08/2024 07:21, Neal Frager via buildroot wrote:
> This patch adds support for Xilinx Versal VEK280 Evaluation Kit.
>
> VEK280 features can be found here:
> https://www.xilinx.com/products/boards-and-kits/vek280.html
>
> The VEK280 requires a patch for the memory node in the dts file because
> it is
> not currently correct. This patch has been applied to the linux-xlnx
> repo and
> will be included in the 2024.2 release.
>
> Upstream:
> https://github.com/Xilinx/linux-xlnx/commit/3c7a97d99bdb3dd6b1f36d7d87d3a3c113dfe2ea
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
Applied to master. Thanks!
I regenerated the defconfig with "make savedefconfig" to have the
default
config ordering. I also kept BR2_TARGET_XILINX_PREBUILT_VERSION in the
defconfig, in case the default version is updated in the package.
Best regards,
Julien.
> ---
> V1->V2:
> - Fixed memory range in dts files for vek280 evaluation board.
> V2->V3:
> - Added Upstream link to vek280 patch.
> V3->V4:
> - Bumped to Linux 6.6.40
> ---
> DEVELOPERS | 1 +
> board/versal/readme.txt | 4 ++
> ...rsal-Fix-vek280-memory-configuration.patch | 47 +++++++++++++++++++
> configs/versal_vek280_defconfig | 44 +++++++++++++++++
> 4 files changed, 96 insertions(+)
> create mode 100644
> board/versal/vek280/patches/linux/0001-arm64-versal-Fix-vek280-memory-configuration.patch
> create mode 100644 configs/versal_vek280_defconfig
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 76f7fc5ed6..d07f41fe91 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2403,6 +2403,7 @@ F: board/zynq/
> F: board/zynqmp/
> F: boot/xilinx-prebuilt/
> F: configs/versal_vck190_defconfig
> +F: configs/versal_vek280_defconfig
> F: configs/versal_vpk180_defconfig
> F: configs/zynq_zc702_defconfig
> F: configs/zynq_zc706_defconfig
> diff --git a/board/versal/readme.txt b/board/versal/readme.txt
> index 9cf499b35b..4d8406fb1f 100644
> --- a/board/versal/readme.txt
> +++ b/board/versal/readme.txt
> @@ -4,6 +4,7 @@ Xilinx Versal boards:
> ******************************************
> Supported Versal Boards:
> Xilinx VCK190 board
> +Xilinx VEK280 board
> Xilinx VPK180 board
> ******************************************
>
> @@ -12,6 +13,9 @@ Evaluation board features can be found here with the
> links below.
> VCK190:
> https://www.xilinx.com/products/boards-and-kits/vck190.html
>
> +VEK280:
> +https://www.xilinx.com/products/boards-and-kits/vek280.html
> +
> VPK180:
> https://www.xilinx.com/products/boards-and-kits/vpk180.html
>
> diff --git
> a/board/versal/vek280/patches/linux/0001-arm64-versal-Fix-vek280-memory-configuration.patch
> b/board/versal/vek280/patches/linux/0001-arm64-versal-Fix-vek280-memory-configuration.patch
> new file mode 100644
> index 0000000000..d894ad35d1
> --- /dev/null
> +++
> b/board/versal/vek280/patches/linux/0001-arm64-versal-Fix-vek280-memory-configuration.patch
> @@ -0,0 +1,47 @@
> +From: Michal Simek <michal.simek@amd.com>
> +Date: Mon, 15 Jul 2024 08:24:57 +0200
> +Subject: [PATCH] arm64: versal: Fix vek280 memory configuration
> +
> +Board has 12GB total but Vivado wizard supports one channel LPDDR4 4GB
> +configuration (2GB low + 2GB high) or two channel LPDDR 8GB
> configuration
> +(2GB low + 6GB high). Wiring the remaining 4GB LPDDR can be done via
> board
> +tab but not available as option in wizard. That's why only describe
> 8GB by
> +default.
> +
> +Signed-off-by: Michal Simek <michal.simek@amd.com>
> +Signed-off-by: Neal Frager <neal.frager@amd.com>
> +Upstream:
> https://github.com/Xilinx/linux-xlnx/commit/3c7a97d99bdb3dd6b1f36d7d87d3a3c113dfe2ea
> +---
> + arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts | 2 +-
> + arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts | 2 +-
> + 2 files changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts
> b/arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts
> +index 1641dc0b5141..ad5d590318e6 100644
> +--- a/arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts
> ++++ b/arch/arm64/boot/dts/xilinx/versal-vek280-revA.dts
> +@@ -19,7 +19,7 @@ / {
> +
> + memory: memory@0 {
> + device_type = "memory";
> +- reg = <0 0 0 0x80000000>, <0x8 0x0 0x7 0x80000000>; /* 32GB */
> ++ reg = <0 0 0 0x80000000>, <0x8 0x80000000 0x1 0x80000000>; /* 2GB +
> 6GB */
> + };
> +
> + chosen {
> +diff --git a/arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts
> b/arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts
> +index fda47cd87b3a..80aae8fa4b11 100644
> +--- a/arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts
> ++++ b/arch/arm64/boot/dts/xilinx/versal-vek280-revB.dts
> +@@ -19,7 +19,7 @@ / {
> +
> + memory: memory@0 {
> + device_type = "memory";
> +- reg = <0 0 0 0x80000000>, <0x8 0x0 0x7 0x80000000>; /* 32GB */
> ++ reg = <0 0 0 0x80000000>, <0x8 0x80000000 0x1 0x80000000>; /* 2GB +
> 6GB */
> + };
> +
> + chosen {
> +--
> +2.43.0
> +
> diff --git a/configs/versal_vek280_defconfig
> b/configs/versal_vek280_defconfig
> new file mode 100644
> index 0000000000..5831d4d159
> --- /dev/null
> +++ b/configs/versal_vek280_defconfig
> @@ -0,0 +1,44 @@
> +BR2_aarch64=y
> +BR2_cortex_a72=y
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_6_6=y
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/versal/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/versal/post-image.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="ttyAMA0,115200 mmcblk0p2"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL=y
> +BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION="$(call
> github,Xilinx,linux-xlnx,xlnx_rebase_v6.6_LTS_merge_6.6.40)/xlnx_rebase_v6.6_LTS_merge_6.6.40.tar.gz"
> +BR2_LINUX_KERNEL_DEFCONFIG="xilinx"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="xilinx/versal-vek280-revB"
> +BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +# BR2_TARGET_ROOTFS_TAR is not set
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL=y
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_CUSTOM_TARBALL_LOCATION="$(call
> github,Xilinx,arm-trusted-firmware,xlnx_rebase_v2.10_2024.1)/xlnx_rebase_v2.10_2024.1.tar.gz"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="versal"
> +BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL31_UBOOT=y
> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31=y
> +BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF=y
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
> +BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call
> github,Xilinx,u-boot-xlnx,xlnx_rebase_v2024.01_2024.1)/xlnx_rebase_v2024.01_2024.1.tar.gz"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="xilinx_versal_virt"
> +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=versal-vek280-revB"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
> +BR2_TARGET_UBOOT_FORMAT_REMAKE_ELF=y
> +BR2_TARGET_UBOOT_FORMAT_DTB=y
> +BR2_TARGET_XILINX_PREBUILT=y
> +BR2_TARGET_XILINX_PREBUILT_VERSION="xilinx_v2024.1"
> +BR2_TARGET_XILINX_PREBUILT_BOARD="vek280"
> +BR2_TARGET_XILINX_PREBUILT_VERSAL=y
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_PACKAGE_HOST_BOOTGEN=y
> +BR2_DOWNLOAD_FORCE_CHECK_HASHES=y
> +BR2_GLOBAL_PATCH_DIR="board/versal/vek280/patches
> board/xilinx/patches"
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig
2024-08-12 5:21 [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig Neal Frager via buildroot
` (2 preceding siblings ...)
2024-11-03 22:09 ` Julien Olivain
@ 2024-11-04 19:31 ` Arnout Vandecappelle via buildroot
2024-11-04 22:40 ` Thomas Petazzoni via buildroot
3 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle via buildroot @ 2024-11-04 19:31 UTC (permalink / raw)
To: Neal Frager, buildroot
Cc: luca.ceresoli, brandon.maier, thomas.petazzoni, romain.naour,
michal.simek, yann.morin.1998
Hi Neal, all,
Not a review this time but an open question!
On 12/08/2024 07:21, Neal Frager via buildroot wrote:
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_TARBALL=y
> +BR2_TARGET_UBOOT_CUSTOM_TARBALL_LOCATION="$(call github,Xilinx,u-boot-
> xlnx,xlnx_rebase_v2024.01_2024.1)/xlnx_rebase_v2024.01_2024.1.tar.gz"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="xilinx_versal_virt"
> +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=versal-vek280-revB"
This DEVICE_TREE= option is already used in 21 defconfigs (and 13 of those are
Xilinx defconfigs ;-) Perhaps it is time to create an explicit uboot/Config.in
option for it? Ideally the config interface would be similar to the options we
have for Linux.
Regards,
Arnout
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
> +BR2_TARGET_UBOOT_FORMAT_REMAKE_ELF=y
> +BR2_TARGET_UBOOT_FORMAT_DTB=y
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig
2024-11-04 19:31 ` Arnout Vandecappelle via buildroot
@ 2024-11-04 22:40 ` Thomas Petazzoni via buildroot
2024-11-05 6:19 ` Frager, Neal via buildroot
0 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-11-04 22:40 UTC (permalink / raw)
To: Arnout Vandecappelle
Cc: Neal Frager, buildroot, luca.ceresoli, brandon.maier,
romain.naour, michal.simek, yann.morin.1998
On Mon, 4 Nov 2024 20:31:35 +0100
Arnout Vandecappelle <arnout@mind.be> wrote:
> This DEVICE_TREE= option is already used in 21 defconfigs (and 13 of those are
> Xilinx defconfigs ;-) Perhaps it is time to create an explicit uboot/Config.in
> option for it? Ideally the config interface would be similar to the options we
> have for Linux.
It's indeed an option that almost always *must* be passed these days,
unless by luck there is a board-specific U-Boot defconfig that
references the correct Device Tree.
So I would tend to agree with you on this one.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Buildroot] [PATCH v4 1/1] configs/versal_vek280_defconfig: new defconfig
2024-11-04 22:40 ` Thomas Petazzoni via buildroot
@ 2024-11-05 6:19 ` Frager, Neal via buildroot
0 siblings, 0 replies; 8+ messages in thread
From: Frager, Neal via buildroot @ 2024-11-05 6:19 UTC (permalink / raw)
To: Thomas Petazzoni, Arnout Vandecappelle
Cc: buildroot@buildroot.org, luca.ceresoli@bootlin.com,
brandon.maier@collins.com, romain.naour@smile.fr, Simek, Michal,
yann.morin.1998@free.fr
Hi Arnaud, Thomas, all,
> This DEVICE_TREE= option is already used in 21 defconfigs (and 13 of those are
> Xilinx defconfigs ;-) Perhaps it is time to create an explicit uboot/Config.in
> option for it? Ideally the config interface would be similar to the options we
> have for Linux.
> It's indeed an option that almost always *must* be passed these days,
> unless by luck there is a board-specific U-Boot defconfig that
> references the correct Device Tree.
> So I would tend to agree with you on this one.
Yes, I agree with this as well. I am sure Xilinx (AMD) is not the only
company who has elected to use a single u-boot defconfig per family, which
is why board specific device trees are not in the u-boot defconfig.
That said, my approach would be to match the Linux naming convention:
BR2_LINUX_KERNEL_INTREE_DTS_NAME
or
BR2_TARGET_UBOOT_INTREE_DTS_NAME
@Arnaud, will you take the lead in implementing this?
Best regards,
Neal Frager
AMD
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 8+ messages in thread