Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] configs/zynqmp_kria_*_defconfig: add missing U-Boot build dependency
@ 2024-08-16 16:37 Brandon Maier via buildroot
  2024-08-19  5:31 ` Frager, Neal via buildroot
  2024-08-19 11:18 ` Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 3+ messages in thread
From: Brandon Maier via buildroot @ 2024-08-16 16:37 UTC (permalink / raw)
  To: buildroot; +Cc: Brandon Maier, Thomas Petazzoni, Neal Frager

From: Brandon Maier <Brandon.Maier@collins.com>

When building these boards with BR2_PER_PACKAGE_DIRECTORIES enabled,
the following error occurs from U-Boot.

  tools/mkeficapsule.c:18:10: fatal error: uuid/uuid.h: No such file or directory
     18 | #include <uuid/uuid.h>
        |          ^~~~~~~~~~~~~

The U-Boot defconfig these boards use 'xilinx_zynqmp_kria' enables
CONFIG_EFI_CAPSULE_ON_DISK, which requires util-linux.

This doesn't fail when BR2_PER_PACKAGE_DIRECTORIES is disabled. This
is because host-e2fsprogs requires host-util-linux, and
host-util-linux always builds before host-uboot when single-threaded.

Signed-off-by: Brandon Maier <brandon.maier@collins.com>
---
 configs/zynqmp_kria_kd240_defconfig | 1 +
 configs/zynqmp_kria_kr260_defconfig | 1 +
 configs/zynqmp_kria_kv260_defconfig | 1 +
 3 files changed, 3 insertions(+)

diff --git a/configs/zynqmp_kria_kd240_defconfig b/configs/zynqmp_kria_kd240_defconfig
index dff49b9837..ce76805638 100644
--- a/configs/zynqmp_kria_kd240_defconfig
+++ b/configs/zynqmp_kria_kd240_defconfig
@@ -28,6 +28,7 @@ BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=zynqmp-smk-k24-revA"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin"
 BR2_TARGET_UBOOT_ZYNQMP=y
diff --git a/configs/zynqmp_kria_kr260_defconfig b/configs/zynqmp_kria_kr260_defconfig
index 24fdea9c30..21d01e5f2a 100644
--- a/configs/zynqmp_kria_kr260_defconfig
+++ b/configs/zynqmp_kria_kr260_defconfig
@@ -28,6 +28,7 @@ BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=zynqmp-smk-k26-revA"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin"
 BR2_TARGET_UBOOT_ZYNQMP=y
diff --git a/configs/zynqmp_kria_kv260_defconfig b/configs/zynqmp_kria_kv260_defconfig
index a16da66e38..f83ef35be3 100644
--- a/configs/zynqmp_kria_kv260_defconfig
+++ b/configs/zynqmp_kria_kv260_defconfig
@@ -28,6 +28,7 @@ BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=zynqmp-smk-k26-revA"
 BR2_TARGET_UBOOT_NEEDS_DTC=y
 BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
 BR2_TARGET_UBOOT_NEEDS_GNUTLS=y
+BR2_TARGET_UBOOT_NEEDS_UTIL_LINUX=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="spl/boot.bin"
 BR2_TARGET_UBOOT_ZYNQMP=y

---
base-commit: c025a655c6adba41df0d8cba0009bbfd5a95ac24
change-id: 20240816-zynqmp-kria-defconfig-add-missing-uboot-build-dep-ab7ae72142d5

Best regards,
-- 
Brandon Maier <brandon.maier@collins.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] configs/zynqmp_kria_*_defconfig: add missing U-Boot build dependency
  2024-08-16 16:37 [Buildroot] [PATCH] configs/zynqmp_kria_*_defconfig: add missing U-Boot build dependency Brandon Maier via buildroot
@ 2024-08-19  5:31 ` Frager, Neal via buildroot
  2024-08-19 11:18 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Frager, Neal via buildroot @ 2024-08-19  5:31 UTC (permalink / raw)
  To: Brandon Maier, buildroot@buildroot.org; +Cc: Thomas Petazzoni

> When building these boards with BR2_PER_PACKAGE_DIRECTORIES enabled,
> the following error occurs from U-Boot.

>  tools/mkeficapsule.c:18:10: fatal error: uuid/uuid.h: No such file or directory
>     18 | #include <uuid/uuid.h>
>        |          ^~~~~~~~~~~~~

> The U-Boot defconfig these boards use 'xilinx_zynqmp_kria' enables
> CONFIG_EFI_CAPSULE_ON_DISK, which requires util-linux.

> This doesn't fail when BR2_PER_PACKAGE_DIRECTORIES is disabled. This
> is because host-e2fsprogs requires host-util-linux, and
> host-util-linux always builds before host-uboot when single-threaded.

> Signed-off-by: Brandon Maier <brandon.maier@collins.com>

Reviewed-by: Neal Frager <neal.frager@amd.com>

> ---
> configs/zynqmp_kria_kd240_defconfig | 1 +
> configs/zynqmp_kria_kr260_defconfig | 1 +
> configs/zynqmp_kria_kv260_defconfig | 1 +
> 3 files changed, 3 insertions(+)

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] configs/zynqmp_kria_*_defconfig: add missing U-Boot build dependency
  2024-08-16 16:37 [Buildroot] [PATCH] configs/zynqmp_kria_*_defconfig: add missing U-Boot build dependency Brandon Maier via buildroot
  2024-08-19  5:31 ` Frager, Neal via buildroot
@ 2024-08-19 11:18 ` Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-08-19 11:18 UTC (permalink / raw)
  To: Brandon Maier via buildroot; +Cc: Brandon Maier, Neal Frager

On Fri, 16 Aug 2024 16:37:30 +0000
Brandon Maier via buildroot <buildroot@buildroot.org> wrote:

> From: Brandon Maier <Brandon.Maier@collins.com>
> 
> When building these boards with BR2_PER_PACKAGE_DIRECTORIES enabled,
> the following error occurs from U-Boot.
> 
>   tools/mkeficapsule.c:18:10: fatal error: uuid/uuid.h: No such file or directory
>      18 | #include <uuid/uuid.h>
>         |          ^~~~~~~~~~~~~
> 
> The U-Boot defconfig these boards use 'xilinx_zynqmp_kria' enables
> CONFIG_EFI_CAPSULE_ON_DISK, which requires util-linux.
> 
> This doesn't fail when BR2_PER_PACKAGE_DIRECTORIES is disabled. This
> is because host-e2fsprogs requires host-util-linux, and
> host-util-linux always builds before host-uboot when single-threaded.
> 
> Signed-off-by: Brandon Maier <brandon.maier@collins.com>
> ---
>  configs/zynqmp_kria_kd240_defconfig | 1 +
>  configs/zynqmp_kria_kr260_defconfig | 1 +
>  configs/zynqmp_kria_kv260_defconfig | 1 +
>  3 files changed, 3 insertions(+)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-19 11:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-16 16:37 [Buildroot] [PATCH] configs/zynqmp_kria_*_defconfig: add missing U-Boot build dependency Brandon Maier via buildroot
2024-08-19  5:31 ` Frager, Neal via buildroot
2024-08-19 11:18 ` Thomas Petazzoni via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox