[Buildroot] [PATCH] package/botan: avoid compile error with gcc 10.x

[Buildroot] [PATCH] package/botan: avoid compile error with gcc 10.x

[Waldemar Brodkorb]

The "using enum" was added in gcc 11.x, see here for a info about it:
https://stackoverflow.com/questions/75018634/how-to-use-the-using-keyword-in-gcc-10-4

Compile successfully tested with internal Buildroot toolchain for
sparc with gcc 12.x as gcc 11.x is not available anymore.

The autobuild failure will be avoided now and fixed with newer external
bootlin toolchains.

Fixes:
 - http://autobuild.buildroot.org/results/ab8/ab83b920156f5a1e51ef960e4007769b5c27d0a1

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/botan/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/botan/Config.in b/package/botan/Config.in
index c61b368801..305cc2fe8c 100644
--- a/package/botan/Config.in
+++ b/package/botan/Config.in
@@ -14,7 +14,7 @@ config BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
 config BR2_PACKAGE_BOTAN
 	bool "botan"
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10 # C++20
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_11 # C++20
 	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_BOOST_FILESYSTEM if BR2_PACKAGE_BOOST && BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
@@ -24,8 +24,8 @@ config BR2_PACKAGE_BOTAN
 
 	  http://botan.randombit.net
 
-comment "botan needs a toolchain w/ threads, C++, gcc >= 10"
+comment "botan needs a toolchain w/ threads, C++, gcc >= 11"
 	depends on !BR2_INSTALL_LIBSTDCPP \
-		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_10 \
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_11 \
 		|| !BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
-- 
2.30.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/botan: avoid compile error with gcc 10.x

[Yann E. MORIN]

Waldemar, All,


You initial title is a misleading. Yes, it does "avoid compile error
with gcc 10.x", but "avoid" is a bit too evasive, so I changed it to the
more assertive:

    package/botan: needs gcc >= 11

On 2024-08-19 22:53 +0200, Waldemar Brodkorb spake thusly:
> The "using enum" was added in gcc 11.x, see here for a info about it:
> https://stackoverflow.com/questions/75018634/how-to-use-the-using-keyword-in-gcc-10-4

I changed that to refer to the official gcc C++ support status;
    https://gcc.gnu.org/projects/cxx-status.html#cxx20

(but I kept the S.O. thread for reference, because it is about
Buildroot, so is still interesting).

> Compile successfully tested with internal Buildroot toolchain for
> sparc with gcc 12.x as gcc 11.x is not available anymore.
> 
> The autobuild failure will be avoided now and fixed with newer external
> bootlin toolchains.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/ab8/ab83b920156f5a1e51ef960e4007769b5c27d0a1
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/botan/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/botan/Config.in b/package/botan/Config.in
> index c61b368801..305cc2fe8c 100644
> --- a/package/botan/Config.in
> +++ b/package/botan/Config.in
> @@ -14,7 +14,7 @@ config BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
>  config BR2_PACKAGE_BOTAN
>  	bool "botan"
>  	depends on BR2_INSTALL_LIBSTDCPP
> -	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10 # C++20
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_11 # C++20
>  	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_BOOST_FILESYSTEM if BR2_PACKAGE_BOOST && BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS
> @@ -24,8 +24,8 @@ config BR2_PACKAGE_BOTAN
>  
>  	  http://botan.randombit.net
>  
> -comment "botan needs a toolchain w/ threads, C++, gcc >= 10"
> +comment "botan needs a toolchain w/ threads, C++, gcc >= 11"
>  	depends on !BR2_INSTALL_LIBSTDCPP \
> -		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_10 \
> +		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_11 \
>  		|| !BR2_TOOLCHAIN_HAS_THREADS
>  	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/botan: avoid compile error with gcc 10.x

[Thomas Petazzoni via buildroot]

Hello Waldemar, Hello Yann,

On Mon, 19 Aug 2024 23:12:49 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > Compile successfully tested with internal Buildroot toolchain for
> > sparc with gcc 12.x as gcc 11.x is not available anymore.
> > 
> > The autobuild failure will be avoided now and fixed with newer external
> > bootlin toolchains.
> > 
> > Fixes:
> >  - http://autobuild.buildroot.org/results/ab8/ab83b920156f5a1e51ef960e4007769b5c27d0a1
> > 
> > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>  
> 
> Applied to master, thanks.

If I may chime in, one critical thing that is missing from this commit
message is since when this problem is occurring. Is it since the update
of the package in 3ba9ac62052c99d7557adf2bbad1bab0c5577a81 ? Or since
2fcc74594c457bed7f0f2a4826ada265861be6bf ?

Indeed 11a577c19e23d0b774f357b2d62ac3c41b7f201f already added a
dependency on gcc 10, so I guess it's something after that?

Again, this is important to understand if the patch needs to be
backported to LTS or not, as usual.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/botan: avoid compile error with gcc 10.x

[Yann E. MORIN]

Thomas, All,

On 2024-08-20 10:58 +0200, Thomas Petazzoni spake thusly:
> On Mon, 19 Aug 2024 23:12:49 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > > Compile successfully tested with internal Buildroot toolchain for
> > > sparc with gcc 12.x as gcc 11.x is not available anymore.
[--SNIP--]
> > Applied to master, thanks.
> If I may chime in, one critical thing that is missing from this commit
> message is since when this problem is occurring. Is it since the update
> of the package in 3ba9ac62052c99d7557adf2bbad1bab0c5577a81 ? Or since
> 2fcc74594c457bed7f0f2a4826ada265861be6bf ?
> 
> Indeed 11a577c19e23d0b774f357b2d62ac3c41b7f201f already added a
> dependency on gcc 10, so I guess it's something after that?
> 
> Again, this is important to understand if the patch needs to be
> backported to LTS or not, as usual.

Indeed, I forgot to do so, my bad...

Regards,
Yann E. MORIN.

> Thanks!
> 
> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/botan: avoid compile error with gcc 10.x

[Peter Korsgaard]

>>>>> "Waldemar" == Waldemar Brodkorb <wbx@openadk.org> writes:

 > The "using enum" was added in gcc 11.x, see here for a info about it:
 > https://stackoverflow.com/questions/75018634/how-to-use-the-using-keyword-in-gcc-10-4

 > Compile successfully tested with internal Buildroot toolchain for
 > sparc with gcc 12.x as gcc 11.x is not available anymore.

 > The autobuild failure will be avoided now and fixed with newer external
 > bootlin toolchains.

 > Fixes:
 >  - http://autobuild.buildroot.org/results/ab8/ab83b920156f5a1e51ef960e4007769b5c27d0a1

 > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Committed to 2024.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot