Re: [Buildroot] [PATCH next] package/fbv: update package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH next] package/fbv: update package
Date: Fri, 23 Aug 2024 09:58:09 +0200	[thread overview]
Message-ID: <20240823095809.70b3bfec@windsurf> (raw)
In-Reply-To: <ZsgdgdqUcwJzrrna@waldemar-brodkorb.de>

Hello Waldemar,

Thanks a lot, looks good. Just a few nits below.

On Fri, 23 Aug 2024 07:26:25 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:

> diff --git a/package/fbv/Config.in b/package/fbv/Config.in
> index 2206276334..1d11bfb3ef 100644
> --- a/package/fbv/Config.in
> +++ b/package/fbv/Config.in
> @@ -2,10 +2,10 @@ config BR2_PACKAGE_FBV
>  	bool "fbv"
>  	help
>  	  fbv is a very simple graphic file viewer for the framebuffer
> -	  console, capable of displaying GIF, JPEG, PNG and BMP files
> -	  using libungif, libjpeg and libpng.
> +	  console, capable of displaying JPEG, PNG and BMP files
> +	  using libjpeg and libpng.
>  
> -	  http://freshmeat.net/projects/fbv/
> +	  https://github.com/amadvance/fbv
>  
>  if BR2_PACKAGE_FBV
>  
> @@ -23,11 +23,4 @@ config BR2_PACKAGE_FBV_JPEG
>  	help
>  	  Enable support for JPEG using IJG's libjpeg.
>  
> -config BR2_PACKAGE_FBV_GIF
> -	bool "GIF support"
> -	default y
> -	select BR2_PACKAGE_GIFLIB
> -	help
> -	  Enable support for GIF using giflib.

When you remove an option, you should add an entry in Config.in.legacy.

> diff --git a/package/fbv/fbv.hash b/package/fbv/fbv.hash
> index 3f25465ba1..7cd9bb597f 100644
> --- a/package/fbv/fbv.hash
> +++ b/package/fbv/fbv.hash
> @@ -1,3 +1,3 @@
>  # Locally calculated
> -sha256  9b55b9dafd5eb01562060d860e267e309a1876e8ba5ce4d3303484b94129ab3c  fbv-1.0b.tar.gz
> +sha256  233b387bf110eaab94221e91bebc16365c70bf6ede01280164a875a7f460d0e0  fbv-7c2000804226ca860ca80f3baa993582e29aa1a2-git4.tar.gz
>  sha256  bf21d97bafcaacb5d6bc3d5502030c340f0e0593614078ab017af91e950083af  COPYING

Did you verify that legal-info was still working?

> diff --git a/package/fbv/fbv.mk b/package/fbv/fbv.mk
> index a69e4ad518..9c7d74b671 100644
> --- a/package/fbv/fbv.mk
> +++ b/package/fbv/fbv.mk
> @@ -4,12 +4,14 @@
>  #
>  ################################################################################
>  
> -FBV_VERSION = 1.0b
> -FBV_SITE = http://s-tech.elsat.net.pl/fbv
> -
> +FBV_VERSION = 7c2000804226ca860ca80f3baa993582e29aa1a2
> +FBV_SITE = https://github.com/amadvance/fbv
> +FBV_SITE_METHOD = git

Please use:

FBV_SITE = $(call github,amadvance,fbv,$(FBV_VERSION))

and drop FBV_SITE_METHOD

Also, with this commit, you are kind of "adopting" this package, so
perhaps add yourself in the DEVELOPERS file for this package?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot