From: Waldemar Brodkorb <wbx@openadk.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH next] package/fbv: update package
Date: Fri, 23 Aug 2024 17:17:23 +0200 [thread overview]
Message-ID: <ZsioAzIzj7+DdKwe@waldemar-brodkorb.de> (raw)
In-Reply-To: <20240823095809.70b3bfec@windsurf>
Hi Thomas,
Thomas Petazzoni wrote,
> Hello Waldemar,
>
> Thanks a lot, looks good. Just a few nits below.
>
> On Fri, 23 Aug 2024 07:26:25 +0200
> Waldemar Brodkorb <wbx@openadk.org> wrote:
>
> > diff --git a/package/fbv/Config.in b/package/fbv/Config.in
> > index 2206276334..1d11bfb3ef 100644
> > --- a/package/fbv/Config.in
> > +++ b/package/fbv/Config.in
> > @@ -2,10 +2,10 @@ config BR2_PACKAGE_FBV
> > bool "fbv"
> > help
> > fbv is a very simple graphic file viewer for the framebuffer
> > - console, capable of displaying GIF, JPEG, PNG and BMP files
> > - using libungif, libjpeg and libpng.
> > + console, capable of displaying JPEG, PNG and BMP files
> > + using libjpeg and libpng.
> >
> > - http://freshmeat.net/projects/fbv/
> > + https://github.com/amadvance/fbv
> >
> > if BR2_PACKAGE_FBV
> >
> > @@ -23,11 +23,4 @@ config BR2_PACKAGE_FBV_JPEG
> > help
> > Enable support for JPEG using IJG's libjpeg.
> >
> > -config BR2_PACKAGE_FBV_GIF
> > - bool "GIF support"
> > - default y
> > - select BR2_PACKAGE_GIFLIB
> > - help
> > - Enable support for GIF using giflib.
>
> When you remove an option, you should add an entry in Config.in.legacy.
>
>
> > diff --git a/package/fbv/fbv.hash b/package/fbv/fbv.hash
> > index 3f25465ba1..7cd9bb597f 100644
> > --- a/package/fbv/fbv.hash
> > +++ b/package/fbv/fbv.hash
> > @@ -1,3 +1,3 @@
> > # Locally calculated
> > -sha256 9b55b9dafd5eb01562060d860e267e309a1876e8ba5ce4d3303484b94129ab3c fbv-1.0b.tar.gz
> > +sha256 233b387bf110eaab94221e91bebc16365c70bf6ede01280164a875a7f460d0e0 fbv-7c2000804226ca860ca80f3baa993582e29aa1a2-git4.tar.gz
> > sha256 bf21d97bafcaacb5d6bc3d5502030c340f0e0593614078ab017af91e950083af COPYING
>
> Did you verify that legal-info was still working?
>
> > diff --git a/package/fbv/fbv.mk b/package/fbv/fbv.mk
> > index a69e4ad518..9c7d74b671 100644
> > --- a/package/fbv/fbv.mk
> > +++ b/package/fbv/fbv.mk
> > @@ -4,12 +4,14 @@
> > #
> > ################################################################################
> >
> > -FBV_VERSION = 1.0b
> > -FBV_SITE = http://s-tech.elsat.net.pl/fbv
> > -
> > +FBV_VERSION = 7c2000804226ca860ca80f3baa993582e29aa1a2
> > +FBV_SITE = https://github.com/amadvance/fbv
> > +FBV_SITE_METHOD = git
>
> Please use:
>
> FBV_SITE = $(call github,amadvance,fbv,$(FBV_VERSION))
>
> and drop FBV_SITE_METHOD
>
> Also, with this commit, you are kind of "adopting" this package, so
> perhaps add yourself in the DEVELOPERS file for this package?
>
> Thanks!
As always, thanks for the review. I have sent a v2.
best regards
Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-23 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 5:26 [Buildroot] [PATCH next] package/fbv: update package Waldemar Brodkorb
2024-08-23 7:58 ` Thomas Petazzoni via buildroot
2024-08-23 15:17 ` Waldemar Brodkorb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZsioAzIzj7+DdKwe@waldemar-brodkorb.de \
--to=wbx@openadk.org \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox