* [Buildroot] [PATCH 1/1] docs/manual: fix description of how to reply to <message-id>
@ 2024-08-30 13:55 Roy Kollen Svendsen
2024-08-30 17:00 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Roy Kollen Svendsen @ 2024-08-30 13:55 UTC (permalink / raw)
To: buildroot; +Cc: Roy Kollen Svendsen
Patch v1 not set to 'superseded' when replying to <message-id> with v2.
I'm using git version 2.46.0. The manual says the following is the
correct way to use the '--in-reply-to' option:
git send-email --in-reply-to=<message-id>
Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
docs/manual/contribute.adoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/manual/contribute.adoc b/docs/manual/contribute.adoc
index fe3ae963a5..ffaff6f857 100644
--- a/docs/manual/contribute.adoc
+++ b/docs/manual/contribute.adoc
@@ -517,7 +517,7 @@ address you register in
https://patchwork.ozlabs.org/project/buildroot/list/[patchwork] should
match the one you use for sending patches to the mailing list.
-You can also add the +--in-reply-to <message-id>+ option when
+You can also add the +--in-reply-to=<message-id>+ option when
submitting a patch to the mailing list. The id of the mail to reply to
can be found under the "Message Id" tag on
https://patchwork.ozlabs.org/project/buildroot/list/[patchwork]. The
--
2.46.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] docs/manual: fix description of how to reply to <message-id>
2024-08-30 13:55 [Buildroot] [PATCH 1/1] docs/manual: fix description of how to reply to <message-id> Roy Kollen Svendsen
@ 2024-08-30 17:00 ` Thomas Petazzoni via buildroot
2024-08-30 17:45 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-08-30 17:00 UTC (permalink / raw)
To: Roy Kollen Svendsen; +Cc: Yann E. MORIN, Romain Naour, buildroot
Hello,
+BR maintainers in Cc.
On Fri, 30 Aug 2024 15:55:45 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
> Patch v1 not set to 'superseded' when replying to <message-id> with v2.
>
> I'm using git version 2.46.0. The manual says the following is the
> correct way to use the '--in-reply-to' option:
>
> git send-email --in-reply-to=<message-id>
>
> Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
> ---
> docs/manual/contribute.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I have applied to master, because it fixes a bug in the doc. But on my
side, I am not a big fan of subsequent iterations being sent as a reply
to the previous iteration. I know it has the advantage that patchwork
marks the previous iteration as Superseded, but I find it a bit
annoying on the mailing list.
What do other BR maintainers think?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] docs/manual: fix description of how to reply to <message-id>
2024-08-30 17:00 ` Thomas Petazzoni via buildroot
@ 2024-08-30 17:45 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2024-08-30 17:45 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Roy Kollen Svendsen, Romain Naour, buildroot
Thomas, All,
On 2024-08-30 19:00 +0200, Thomas Petazzoni spake thusly:
> On Fri, 30 Aug 2024 15:55:45 +0200
> Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
> > Patch v1 not set to 'superseded' when replying to <message-id> with v2.
[--SNIP--]
> I have applied to master, because it fixes a bug in the doc. But on my
> side, I am not a big fan of subsequent iterations being sent as a reply
> to the previous iteration. I know it has the advantage that patchwork
> marks the previous iteration as Superseded, but I find it a bit
> annoying on the mailing list.
>
> What do other BR maintainers think?
I too am not fond of threaded iterations, and I prefer a new thread be
opened for each iteration.
If submitters are going as far as to use --in-reply-to, then can as well
reference the original thread in the post-commit changelog, or in a
cover-letter.
I also like to have such a reference, as I can go and skim over the
previous reviews to assess the changes. So, an automatically-superseded
patch(set) in patchwork is rather detrimental to my workflow, in fact.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-30 17:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-30 13:55 [Buildroot] [PATCH 1/1] docs/manual: fix description of how to reply to <message-id> Roy Kollen Svendsen
2024-08-30 17:00 ` Thomas Petazzoni via buildroot
2024-08-30 17:45 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox