[Buildroot] [PATCH v2] configs: riscv: qemu: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION

[Buildroot] [PATCH v2] configs: riscv: qemu: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION

[Bin Meng]

From: Bin Meng <bmeng@tinylab.org>

Update qemu_riscv32_virt_defconfig and qemu_riscv64_virt_defconfig
to use the latest OpenSBI due to the reason that:

1. they are the main platforms to develop and test OpenSBI
2. latest OpenSBI binaries are always integrated into QEMU as
   the default bios

Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
See v1 @ https://patchwork.ozlabs.org/project/buildroot/patch/20230626160030.93063-7-bmeng.cn@gmail.com/

Changes in v2:
- Only update QEMU defconfig files

 configs/qemu_riscv32_virt_defconfig | 2 --
 configs/qemu_riscv64_virt_defconfig | 2 --
 2 files changed, 4 deletions(-)

diff --git a/configs/qemu_riscv32_virt_defconfig b/configs/qemu_riscv32_virt_defconfig
index 631526b695..28bb2b0cd6 100644
--- a/configs/qemu_riscv32_virt_defconfig
+++ b/configs/qemu_riscv32_virt_defconfig
@@ -29,8 +29,6 @@ BR2_LINUX_KERNEL_IMAGE=y
 
 # Bootloader
 BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
 BR2_TARGET_OPENSBI_PLAT="generic"
 
 # host-qemu for gitlab testing
diff --git a/configs/qemu_riscv64_virt_defconfig b/configs/qemu_riscv64_virt_defconfig
index 31ac1d1ed9..54999cfee7 100644
--- a/configs/qemu_riscv64_virt_defconfig
+++ b/configs/qemu_riscv64_virt_defconfig
@@ -29,8 +29,6 @@ BR2_LINUX_KERNEL_IMAGE=y
 
 # Bootloader
 BR2_TARGET_OPENSBI=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
-BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
 BR2_TARGET_OPENSBI_PLAT="generic"
 
 # host-qemu for gitlab testing
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] configs: riscv: qemu: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION

[Alistair Francis]

On Fri, Aug 30, 2024 at 1:42 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bmeng@tinylab.org>
>
> Update qemu_riscv32_virt_defconfig and qemu_riscv64_virt_defconfig
> to use the latest OpenSBI due to the reason that:
>
> 1. they are the main platforms to develop and test OpenSBI
> 2. latest OpenSBI binaries are always integrated into QEMU as
>    the default bios
>
> Signed-off-by: Bin Meng <bmeng@tinylab.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
> See v1 @ https://patchwork.ozlabs.org/project/buildroot/patch/20230626160030.93063-7-bmeng.cn@gmail.com/
>
> Changes in v2:
> - Only update QEMU defconfig files
>
>  configs/qemu_riscv32_virt_defconfig | 2 --
>  configs/qemu_riscv64_virt_defconfig | 2 --
>  2 files changed, 4 deletions(-)
>
> diff --git a/configs/qemu_riscv32_virt_defconfig b/configs/qemu_riscv32_virt_defconfig
> index 631526b695..28bb2b0cd6 100644
> --- a/configs/qemu_riscv32_virt_defconfig
> +++ b/configs/qemu_riscv32_virt_defconfig
> @@ -29,8 +29,6 @@ BR2_LINUX_KERNEL_IMAGE=y
>
>  # Bootloader
>  BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
>  BR2_TARGET_OPENSBI_PLAT="generic"
>
>  # host-qemu for gitlab testing
> diff --git a/configs/qemu_riscv64_virt_defconfig b/configs/qemu_riscv64_virt_defconfig
> index 31ac1d1ed9..54999cfee7 100644
> --- a/configs/qemu_riscv64_virt_defconfig
> +++ b/configs/qemu_riscv64_virt_defconfig
> @@ -29,8 +29,6 @@ BR2_LINUX_KERNEL_IMAGE=y
>
>  # Bootloader
>  BR2_TARGET_OPENSBI=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION=y
> -BR2_TARGET_OPENSBI_CUSTOM_VERSION_VALUE="1.2"
>  BR2_TARGET_OPENSBI_PLAT="generic"
>
>  # host-qemu for gitlab testing
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] configs: riscv: qemu: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION

[Thomas Petazzoni via buildroot]

Hello Bin,

On Thu, 29 Aug 2024 23:41:50 +0800
Bin Meng <bmeng.cn@gmail.com> wrote:

> From: Bin Meng <bmeng@tinylab.org>
> 
> Update qemu_riscv32_virt_defconfig and qemu_riscv64_virt_defconfig
> to use the latest OpenSBI due to the reason that:
> 
> 1. they are the main platforms to develop and test OpenSBI
> 2. latest OpenSBI binaries are always integrated into QEMU as
>    the default bios
> 
> Signed-off-by: Bin Meng <bmeng@tinylab.org>
> ---
> See v1 @ https://patchwork.ozlabs.org/project/buildroot/patch/20230626160030.93063-7-bmeng.cn@gmail.com/

Sorry but no. We _do_ want our defconfigs to specify a custom and fixed
version of Linux, U-Boot, OpenSBI, TF-A, etc.
See https://buildroot.org/downloads/manual/manual.html#adding-board-support:

"""
Always use fixed versions or commit hashes for the different
components, not the "latest" version. For example, set
BR2_LINUX_KERNEL_CUSTOM_VERSION=y and
BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE to the kernel version you tested
with.
"""

Do not hesitate to send patches to update the OpenSBI version used in
those defconfigs, after testing that this update works fine for those
particular platforms.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] configs: riscv: qemu: Drop BR2_TARGET_OPENSBI_CUSTOM_VERSION

[Bin Meng]

Hi Thomas,

On Sat, Aug 31, 2024 at 1:02 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Bin,
>
> On Thu, 29 Aug 2024 23:41:50 +0800
> Bin Meng <bmeng.cn@gmail.com> wrote:
>
> > From: Bin Meng <bmeng@tinylab.org>
> >
> > Update qemu_riscv32_virt_defconfig and qemu_riscv64_virt_defconfig
> > to use the latest OpenSBI due to the reason that:
> >
> > 1. they are the main platforms to develop and test OpenSBI
> > 2. latest OpenSBI binaries are always integrated into QEMU as
> >    the default bios
> >
> > Signed-off-by: Bin Meng <bmeng@tinylab.org>
> > ---
> > See v1 @ https://patchwork.ozlabs.org/project/buildroot/patch/20230626160030.93063-7-bmeng.cn@gmail.com/
>
> Sorry but no. We _do_ want our defconfigs to specify a custom and fixed
> version of Linux, U-Boot, OpenSBI, TF-A, etc.
> See https://buildroot.org/downloads/manual/manual.html#adding-board-support:
>
> """
> Always use fixed versions or commit hashes for the different
> components, not the "latest" version. For example, set
> BR2_LINUX_KERNEL_CUSTOM_VERSION=y and
> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE to the kernel version you tested
> with.
> """

QEMU is the special case as I wrote in the commit message, that:

1. they are the main platforms to develop and test OpenSBI
2. latest OpenSBI binaries are always integrated into QEMU as the default bios

So OpenSBI latest version is always tested by the OpenSBI and QEMU
community. IMO keeping updating the defconfig for these 2 boards does
not make a lot of sense.

>
> Do not hesitate to send patches to update the OpenSBI version used in
> those defconfigs, after testing that this update works fine for those
> particular platforms.

If you still think we should do this, I would argue we completely drop
the BR2_TARGET_OPENSBI_LATEST_VERSION config option so that all boards
shall explicitely specify the OpenSBI version in their defconfig
files.

Regards,
Bin
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot