From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] support/scripts/genimage.sh: drop gzip compression
Date: Fri, 30 Aug 2024 19:09:29 +0200 [thread overview]
Message-ID: <20240830190929.026208bc@windsurf> (raw)
In-Reply-To: <20240830082650.1895430-1-peter@korsgaard.com>
On Fri, 30 Aug 2024 10:26:49 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:
> Commit 6889056f1eb4 (support/scripts/genimage.sh: support creating a bmap
> image) added unconditional gzip compression of the genimage outputs if
> bmap-tools is enabled, which is problematic for a number of reasons:
>
> - The gzip invocation is not reproducable (E.G. does not use -n)
>
> - The original file is removed, dropping the sparse info
>
> - It hardcodes policy, E.G. bmap supports a number of different compression
> algorithms / compression may not be desired for all images / different
> compression levels may be desired
>
> So drop the compression step. If desired, compression can be done with a
> post-image script.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> support/scripts/genimage.sh | 1 -
> 1 file changed, 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-08-30 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 8:26 [Buildroot] [PATCH] support/scripts/genimage.sh: drop gzip compression Peter Korsgaard
2024-08-30 9:14 ` TIAN Yuanhao
2024-08-30 17:09 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830190929.026208bc@windsurf \
--to=buildroot@buildroot.org \
--cc=peter@korsgaard.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox