[Buildroot] [PATCH] support/scripts/genimage.sh: drop gzip compression

[Buildroot] [PATCH] support/scripts/genimage.sh: drop gzip compression

[Peter Korsgaard]

Commit 6889056f1eb4 (support/scripts/genimage.sh: support creating a bmap
image) added unconditional gzip compression of the genimage outputs if
bmap-tools is enabled, which is problematic for a number of reasons:

- The gzip invocation is not reproducable (E.G. does not use -n)

- The original file is removed, dropping the sparse info

- It hardcodes policy, E.G.  bmap supports a number of different compression
  algorithms / compression may not be desired for all images / different
  compression levels may be desired

So drop the compression step.  If desired, compression can be done with a
post-image script.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 support/scripts/genimage.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/support/scripts/genimage.sh b/support/scripts/genimage.sh
index b479ec9e0b..df224241ab 100755
--- a/support/scripts/genimage.sh
+++ b/support/scripts/genimage.sh
@@ -54,6 +54,5 @@ if grep -Eq "^BR2_PACKAGE_HOST_BMAP_TOOLS=y$" "${BR2_CONFIG}"; then
 			continue
 		fi
 		bmaptool create "${image_path}" -o "${image_path}.bmap"
-		gzip -c "${image_path}" > "${image_path}.gz"
 	done < <(grep '^image ' "${GENIMAGE_CFG}" | cut -d ' ' -f 2)
 fi
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] support/scripts/genimage.sh: drop gzip compression

[TIAN Yuanhao]

At 2024-08-30 16:26:49, "Peter Korsgaard" <peter@korsgaard.com> wrote:
>Commit 6889056f1eb4 (support/scripts/genimage.sh: support creating a bmap
>image) added unconditional gzip compression of the genimage outputs if
>bmap-tools is enabled, which is problematic for a number of reasons:
>
>- The gzip invocation is not reproducable (E.G. does not use -n)
>
>- The original file is removed, dropping the sparse info
>
>- It hardcodes policy, E.G.  bmap supports a number of different compression
>  algorithms / compression may not be desired for all images / different
>  compression levels may be desired
>
>So drop the compression step.  If desired, compression can be done with a
>post-image script.
>
>Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>---
> support/scripts/genimage.sh | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/support/scripts/genimage.sh b/support/scripts/genimage.sh
>index b479ec9e0b..df224241ab 100755
>--- a/support/scripts/genimage.sh
>+++ b/support/scripts/genimage.sh
>@@ -54,6 +54,5 @@ if grep -Eq "^BR2_PACKAGE_HOST_BMAP_TOOLS=y$" "${BR2_CONFIG}"; then
> 			continue
> 		fi
> 		bmaptool create "${image_path}" -o "${image_path}.bmap"
>-		gzip -c "${image_path}" > "${image_path}.gz"
> 	done < <(grep '^image ' "${GENIMAGE_CFG}" | cut -d ' ' -f 2)
> fi
>-- 
>2.39.2
>
>_______________________________________________
>buildroot mailing list
>buildroot@buildroot.org
>https://lists.buildroot.org/mailman/listinfo/buildroot

Acked-by: TIAN Yuanhao <tianyuanhao3@163.com>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] support/scripts/genimage.sh: drop gzip compression

[Thomas Petazzoni via buildroot]

On Fri, 30 Aug 2024 10:26:49 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:

> Commit 6889056f1eb4 (support/scripts/genimage.sh: support creating a bmap
> image) added unconditional gzip compression of the genimage outputs if
> bmap-tools is enabled, which is problematic for a number of reasons:
> 
> - The gzip invocation is not reproducable (E.G. does not use -n)
> 
> - The original file is removed, dropping the sparse info
> 
> - It hardcodes policy, E.G.  bmap supports a number of different compression
>   algorithms / compression may not be desired for all images / different
>   compression levels may be desired
> 
> So drop the compression step.  If desired, compression can be done with a
> post-image script.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  support/scripts/genimage.sh | 1 -
>  1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot