[Buildroot] [PATCH 1/2] package/qt6/qt6tools: allow building host Qt Linguist Tools

[Buildroot] [PATCH 1/2] package/qt6/qt6tools: allow building host Qt Linguist Tools

[Roy Kollen Svendsen]

According to src/linguist/CMakeLists.txt we need to enable the
linguist feature:

...
if(NOT QT_FEATURE_linguist)
    return()
endif()
add_subdirectory(lconvert)
add_subdirectory(lprodump)
add_subdirectory(lrelease)
add_subdirectory(lrelease-pro)
add_subdirectory(lupdate)
add_subdirectory(lupdate-pro)
if(QT_FEATURE_process AND QT_FEATURE_pushbutton AND QT_FEATURE_toolbutton AND TARGET Qt::Widgets AND NOT no-png)
    add_subdirectory(linguist)
endif()
...

And according to configure.cmake we need to select print support:
...
qt_feature("linguist" PRIVATE
    LABEL "Qt Linguist"
    PURPOSE "Qt Linguist can be used by translator to translate text in Qt applications."
    CONDITION TARGET Qt::PrintSupport
)
...

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
 package/qt6/qt6tools/Config.in   | 11 +++++++++++
 package/qt6/qt6tools/qt6tools.mk | 10 ++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/package/qt6/qt6tools/Config.in b/package/qt6/qt6tools/Config.in
index 5f52c5644f..eea461a2a9 100644
--- a/package/qt6/qt6tools/Config.in
+++ b/package/qt6/qt6tools/Config.in
@@ -15,3 +15,14 @@ config BR2_PACKAGE_QT6TOOLS
 	  and design of applications.
 
 	  https://github.com/qt/qttools
+
+if BR2_PACKAGE_QT6TOOLS
+
+config BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS
+	bool "linguist tools (host)"
+	select BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT
+	help
+	  Translate Qt C++ and Qt Quick applications into local
+	  languages.
+
+endif
diff --git a/package/qt6/qt6tools/qt6tools.mk b/package/qt6/qt6tools/qt6tools.mk
index 09c986cfc6..897cf43054 100644
--- a/package/qt6/qt6tools/qt6tools.mk
+++ b/package/qt6/qt6tools/qt6tools.mk
@@ -37,11 +37,17 @@ QT6TOOLS_DEPENDENCIES = \
 	qt6base \
 	host-qt6tools
 
+HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
+
+ifeq ($(BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS),y)
+HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=ON
+else
+HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_QT6DECLARATIVE),y)
 QT6TOOLS_DEPENDENCIES += qt6declarative
 endif
 
-HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
-
 $(eval $(cmake-package))
 $(eval $(host-cmake-package))
-- 
2.46.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/2] package/qt6/qt6base: allow selecting the host Qt Print Support module

[Roy Kollen Svendsen]

According to configure.cmake printsupport requires widgets:

qt_feature("printsupport" PRIVATE
    LABEL "Qt PrintSupport"
    CONDITION QT_FEATURE_widgets
    SECTION "Module"
    PURPOSE "Provides the Qt PrintSupport module."
)

So we let print support automatically select widgets support.

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
 package/qt6/qt6base/Config.in.host | 11 +++++++++++
 package/qt6/qt6base/qt6base.mk     | 16 ++++++++++++++--
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/package/qt6/qt6base/Config.in.host b/package/qt6/qt6base/Config.in.host
index 46fb668817..8f0bc1f070 100644
--- a/package/qt6/qt6base/Config.in.host
+++ b/package/qt6/qt6base/Config.in.host
@@ -8,6 +8,13 @@ config BR2_PACKAGE_HOST_QT6BASE_GUI
 config BR2_PACKAGE_HOST_QT6BASE_NETWORK
 	bool
 
+# Select this if you need host qt6 tools that require the Qt Print Support
+# module
+# (e.g. Qt Tools Linguist Tools).
+config BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT
+	bool
+	select BR2_PACKAGE_HOST_QT6BASE_WIDGETS
+
 # Select this if you need host qt6 tools that require the Qt::Test module
 # (e.g. qmltestrunner).
 config BR2_PACKAGE_HOST_QT6BASE_TEST
@@ -17,3 +24,7 @@ config BR2_PACKAGE_HOST_QT6BASE_TEST
 # (e.g. qhelpgenerator).
 config BR2_PACKAGE_HOST_QT6BASE_SQL
 	bool
+
+# The Qt Widgets module is required by the Qt Print Support module
+config BR2_PACKAGE_HOST_QT6BASE_WIDGETS
+	bool
diff --git a/package/qt6/qt6base/qt6base.mk b/package/qt6/qt6base/qt6base.mk
index 4c0392f92d..271f464115 100644
--- a/package/qt6/qt6base/qt6base.mk
+++ b/package/qt6/qt6base/qt6base.mk
@@ -113,10 +113,8 @@ HOST_QT6BASE_CONF_OPTS += \
 	-DFEATURE_png=OFF \
 	-DFEATURE_gif=OFF \
 	-DFEATURE_jpeg=OFF \
-	-DFEATURE_printsupport=OFF \
 	-DFEATURE_kms=OFF \
 	-DFEATURE_fontconfig=OFF \
-	-DFEATURE_widgets=OFF \
 	-DFEATURE_libinput=OFF \
 	-DFEATURE_tslib=OFF \
 	-DFEATURE_eglfs=OFF
@@ -131,6 +129,13 @@ else
 HOST_QT6BASE_CONF_OPTS += -DFEATURE_network=OFF
 endif
 
+# The Qt Print Support module is required for building Qt Tools Linguist Tools
+ifeq ($(BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT),y)
+HOST_QT6BASE_CONF_OPTS += -DFEATURE_printsupport=ON
+else
+HOST_QT6BASE_CONF_OPTS += -DFEATURE_printsupport=OFF
+endif
+
 # We need host qt6base with Sql support for host-qt6tools to generate the
 # qhelpgenerator host tool. qt6tools will fail to build if qhelpgenerator is not
 # available.
@@ -150,6 +155,13 @@ else
 HOST_QT6BASE_CONF_OPTS += -DFEATURE_testlib=OFF
 endif
 
+# The Qt Widgets module is required by the Qt Print Support module
+ifeq ($(BR2_PACKAGE_HOST_QT6BASE_WIDGETS),y)
+HOST_QT6BASE_CONF_OPTS += -DFEATURE_widgets=ON
+else
+HOST_QT6BASE_CONF_OPTS += -DFEATURE_widgets=OFF
+endif
+
 # Conditional blocks below are ordered by alphabetic ordering of the
 # BR2_PACKAGE_* option.
 
-- 
2.46.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/qt6/qt6base: allow selecting the host Qt Print Support module

[Thomas Petazzoni via buildroot]

Hello,

On Wed,  4 Sep 2024 14:20:38 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:

> According to configure.cmake printsupport requires widgets:
> 
> qt_feature("printsupport" PRIVATE
>     LABEL "Qt PrintSupport"
>     CONDITION QT_FEATURE_widgets
>     SECTION "Module"
>     PURPOSE "Provides the Qt PrintSupport module."
> )
> 
> So we let print support automatically select widgets support.
> 
> Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>

This should be PATCH 1/2 in the series, because your patch adding
BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS uses this new
BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT option.

> ---
>  package/qt6/qt6base/Config.in.host | 11 +++++++++++
>  package/qt6/qt6base/qt6base.mk     | 16 ++++++++++++++--
>  2 files changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/package/qt6/qt6base/Config.in.host b/package/qt6/qt6base/Config.in.host
> index 46fb668817..8f0bc1f070 100644
> --- a/package/qt6/qt6base/Config.in.host
> +++ b/package/qt6/qt6base/Config.in.host
> @@ -8,6 +8,13 @@ config BR2_PACKAGE_HOST_QT6BASE_GUI
>  config BR2_PACKAGE_HOST_QT6BASE_NETWORK
>  	bool
>  
> +# Select this if you need host qt6 tools that require the Qt Print Support
> +# module
> +# (e.g. Qt Tools Linguist Tools).

I don't think that this really makes sense. We don't really care about
how is using this (in the future, it may be other things). We care
about what the option does... but what it does is actually pretty
obvious from the option name. I think the only comment is to clarify
that yes, widget support is needed for the print support, which isn't
really obvious.

> +config BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT
> +	bool
> +	select BR2_PACKAGE_HOST_QT6BASE_WIDGETS
> +
>  # Select this if you need host qt6 tools that require the Qt::Test module
>  # (e.g. qmltestrunner).
>  config BR2_PACKAGE_HOST_QT6BASE_TEST
> @@ -17,3 +24,7 @@ config BR2_PACKAGE_HOST_QT6BASE_TEST
>  # (e.g. qhelpgenerator).
>  config BR2_PACKAGE_HOST_QT6BASE_SQL
>  	bool
> +
> +# The Qt Widgets module is required by the Qt Print Support module

And this comment would become useless.

> +config BR2_PACKAGE_HOST_QT6BASE_WIDGETS
> +	bool

Isn't widget support dependent on GUI support?

> diff --git a/package/qt6/qt6base/qt6base.mk b/package/qt6/qt6base/qt6base.mk
> index 4c0392f92d..271f464115 100644
> --- a/package/qt6/qt6base/qt6base.mk
> +++ b/package/qt6/qt6base/qt6base.mk
> @@ -113,10 +113,8 @@ HOST_QT6BASE_CONF_OPTS += \
>  	-DFEATURE_png=OFF \
>  	-DFEATURE_gif=OFF \
>  	-DFEATURE_jpeg=OFF \
> -	-DFEATURE_printsupport=OFF \
>  	-DFEATURE_kms=OFF \
>  	-DFEATURE_fontconfig=OFF \
> -	-DFEATURE_widgets=OFF \
>  	-DFEATURE_libinput=OFF \
>  	-DFEATURE_tslib=OFF \
>  	-DFEATURE_eglfs=OFF
> @@ -131,6 +129,13 @@ else
>  HOST_QT6BASE_CONF_OPTS += -DFEATURE_network=OFF
>  endif
>  
> +# The Qt Print Support module is required for building Qt Tools Linguist Tools

Not needed, it could be other things.

> +ifeq ($(BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT),y)
> +HOST_QT6BASE_CONF_OPTS += -DFEATURE_printsupport=ON
> +else
> +HOST_QT6BASE_CONF_OPTS += -DFEATURE_printsupport=OFF
> +endif
> +
>  # We need host qt6base with Sql support for host-qt6tools to generate the
>  # qhelpgenerator host tool. qt6tools will fail to build if qhelpgenerator is not
>  # available.
> @@ -150,6 +155,13 @@ else
>  HOST_QT6BASE_CONF_OPTS += -DFEATURE_testlib=OFF
>  endif
>  
> +# The Qt Widgets module is required by the Qt Print Support module

Also not very relevant comment IMO.

> +ifeq ($(BR2_PACKAGE_HOST_QT6BASE_WIDGETS),y)
> +HOST_QT6BASE_CONF_OPTS += -DFEATURE_widgets=ON
> +else
> +HOST_QT6BASE_CONF_OPTS += -DFEATURE_widgets=OFF
> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/2] package/qt6/qt6base: allow selecting the host Qt Print Support module

[Roy Kollen Svendsen]

Hi Thomas,

Here is v2 of the patchset:

https://patchwork.ozlabs.org/project/buildroot/patch/20240904211049.866640-1-roykollensvendsen@gmail.com/

Roy

ons. 4. sep. 2024 kl. 14:33 skrev Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> Hello,
>
> On Wed,  4 Sep 2024 14:20:38 +0200
> Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
>
> > According to configure.cmake printsupport requires widgets:
> >
> > qt_feature("printsupport" PRIVATE
> >     LABEL "Qt PrintSupport"
> >     CONDITION QT_FEATURE_widgets
> >     SECTION "Module"
> >     PURPOSE "Provides the Qt PrintSupport module."
> > )
> >
> > So we let print support automatically select widgets support.
> >
> > Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
>
> This should be PATCH 1/2 in the series, because your patch adding
> BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS uses this new
> BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT option.
>
> > ---
> >  package/qt6/qt6base/Config.in.host | 11 +++++++++++
> >  package/qt6/qt6base/qt6base.mk     | 16 ++++++++++++++--
> >  2 files changed, 25 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/qt6/qt6base/Config.in.host b/package/qt6/qt6base/Config.in.host
> > index 46fb668817..8f0bc1f070 100644
> > --- a/package/qt6/qt6base/Config.in.host
> > +++ b/package/qt6/qt6base/Config.in.host
> > @@ -8,6 +8,13 @@ config BR2_PACKAGE_HOST_QT6BASE_GUI
> >  config BR2_PACKAGE_HOST_QT6BASE_NETWORK
> >       bool
> >
> > +# Select this if you need host qt6 tools that require the Qt Print Support
> > +# module
> > +# (e.g. Qt Tools Linguist Tools).
>
> I don't think that this really makes sense. We don't really care about
> how is using this (in the future, it may be other things). We care
> about what the option does... but what it does is actually pretty
> obvious from the option name. I think the only comment is to clarify
> that yes, widget support is needed for the print support, which isn't
> really obvious.
>
> > +config BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT
> > +     bool
> > +     select BR2_PACKAGE_HOST_QT6BASE_WIDGETS
> > +
> >  # Select this if you need host qt6 tools that require the Qt::Test module
> >  # (e.g. qmltestrunner).
> >  config BR2_PACKAGE_HOST_QT6BASE_TEST
> > @@ -17,3 +24,7 @@ config BR2_PACKAGE_HOST_QT6BASE_TEST
> >  # (e.g. qhelpgenerator).
> >  config BR2_PACKAGE_HOST_QT6BASE_SQL
> >       bool
> > +
> > +# The Qt Widgets module is required by the Qt Print Support module
>
> And this comment would become useless.
>
> > +config BR2_PACKAGE_HOST_QT6BASE_WIDGETS
> > +     bool
>
> Isn't widget support dependent on GUI support?
>
> > diff --git a/package/qt6/qt6base/qt6base.mk b/package/qt6/qt6base/qt6base.mk
> > index 4c0392f92d..271f464115 100644
> > --- a/package/qt6/qt6base/qt6base.mk
> > +++ b/package/qt6/qt6base/qt6base.mk
> > @@ -113,10 +113,8 @@ HOST_QT6BASE_CONF_OPTS += \
> >       -DFEATURE_png=OFF \
> >       -DFEATURE_gif=OFF \
> >       -DFEATURE_jpeg=OFF \
> > -     -DFEATURE_printsupport=OFF \
> >       -DFEATURE_kms=OFF \
> >       -DFEATURE_fontconfig=OFF \
> > -     -DFEATURE_widgets=OFF \
> >       -DFEATURE_libinput=OFF \
> >       -DFEATURE_tslib=OFF \
> >       -DFEATURE_eglfs=OFF
> > @@ -131,6 +129,13 @@ else
> >  HOST_QT6BASE_CONF_OPTS += -DFEATURE_network=OFF
> >  endif
> >
> > +# The Qt Print Support module is required for building Qt Tools Linguist Tools
>
> Not needed, it could be other things.
>
> > +ifeq ($(BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT),y)
> > +HOST_QT6BASE_CONF_OPTS += -DFEATURE_printsupport=ON
> > +else
> > +HOST_QT6BASE_CONF_OPTS += -DFEATURE_printsupport=OFF
> > +endif
> > +
> >  # We need host qt6base with Sql support for host-qt6tools to generate the
> >  # qhelpgenerator host tool. qt6tools will fail to build if qhelpgenerator is not
> >  # available.
> > @@ -150,6 +155,13 @@ else
> >  HOST_QT6BASE_CONF_OPTS += -DFEATURE_testlib=OFF
> >  endif
> >
> > +# The Qt Widgets module is required by the Qt Print Support module
>
> Also not very relevant comment IMO.
>
> > +ifeq ($(BR2_PACKAGE_HOST_QT6BASE_WIDGETS),y)
> > +HOST_QT6BASE_CONF_OPTS += -DFEATURE_widgets=ON
> > +else
> > +HOST_QT6BASE_CONF_OPTS += -DFEATURE_widgets=OFF
> > +endif
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/qt6/qt6tools: allow building host Qt Linguist Tools

[Thomas Petazzoni via buildroot]

Hello,

On Wed,  4 Sep 2024 14:20:37 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:

> According to src/linguist/CMakeLists.txt we need to enable the
> linguist feature:
> 
> ...
> if(NOT QT_FEATURE_linguist)
>     return()
> endif()
> add_subdirectory(lconvert)
> add_subdirectory(lprodump)
> add_subdirectory(lrelease)
> add_subdirectory(lrelease-pro)
> add_subdirectory(lupdate)
> add_subdirectory(lupdate-pro)
> if(QT_FEATURE_process AND QT_FEATURE_pushbutton AND QT_FEATURE_toolbutton AND TARGET Qt::Widgets AND NOT no-png)
>     add_subdirectory(linguist)
> endif()
> ...
> 
> And according to configure.cmake we need to select print support:
> ...
> qt_feature("linguist" PRIVATE
>     LABEL "Qt Linguist"
>     PURPOSE "Qt Linguist can be used by translator to translate text in Qt applications."
>     CONDITION TARGET Qt::PrintSupport
> )
> ...
> 
> Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
> ---
>  package/qt6/qt6tools/Config.in   | 11 +++++++++++
>  package/qt6/qt6tools/qt6tools.mk | 10 ++++++++--
>  2 files changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/package/qt6/qt6tools/Config.in b/package/qt6/qt6tools/Config.in
> index 5f52c5644f..eea461a2a9 100644
> --- a/package/qt6/qt6tools/Config.in
> +++ b/package/qt6/qt6tools/Config.in
> @@ -15,3 +15,14 @@ config BR2_PACKAGE_QT6TOOLS
>  	  and design of applications.
>  
>  	  https://github.com/qt/qttools
> +
> +if BR2_PACKAGE_QT6TOOLS
> +
> +config BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS
> +	bool "linguist tools (host)"
> +	select BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT
> +	help
> +	  Translate Qt C++ and Qt Quick applications into local
> +	  languages.

This should go in a package/qt6/qt6tools/Config.in.host, not in
Config.in as Config.in is for options that affect the target build.

> +
> +endif
> diff --git a/package/qt6/qt6tools/qt6tools.mk b/package/qt6/qt6tools/qt6tools.mk
> index 09c986cfc6..897cf43054 100644
> --- a/package/qt6/qt6tools/qt6tools.mk
> +++ b/package/qt6/qt6tools/qt6tools.mk
> @@ -37,11 +37,17 @@ QT6TOOLS_DEPENDENCIES = \
>  	qt6base \
>  	host-qt6tools
>  
> +HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
> +
> +ifeq ($(BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS),y)
> +HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=ON
> +else
> +HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=OFF
> +endif

Please group these host package things...

> +
>  ifeq ($(BR2_PACKAGE_QT6DECLARATIVE),y)
>  QT6TOOLS_DEPENDENCIES += qt6declarative
>  endif
>  
> -HOST_QT6TOOLS_DEPENDENCIES = host-qt6base

... here. Rather than inter-twining target package and host package
details.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/2] package/qt6/qt6tools: allow building host Qt Linguist Tools

[Roy Kollen Svendsen]

Hi Thomas,

Here is v2:

PATCH 2/3:
https://patchwork.ozlabs.org/project/buildroot/patch/20240904211049.866640-2-roykollensvendsen@gmail.com/

PATCH 3/3:
https://patchwork.ozlabs.org/project/buildroot/patch/20240904211049.866640-3-roykollensvendsen@gmail.com/



Roy



ons. 4. sep. 2024 kl. 14:30 skrev Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> Hello,
>
> On Wed,  4 Sep 2024 14:20:37 +0200
> Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
>
> > According to src/linguist/CMakeLists.txt we need to enable the
> > linguist feature:
> >
> > ...
> > if(NOT QT_FEATURE_linguist)
> >     return()
> > endif()
> > add_subdirectory(lconvert)
> > add_subdirectory(lprodump)
> > add_subdirectory(lrelease)
> > add_subdirectory(lrelease-pro)
> > add_subdirectory(lupdate)
> > add_subdirectory(lupdate-pro)
> > if(QT_FEATURE_process AND QT_FEATURE_pushbutton AND QT_FEATURE_toolbutton AND TARGET Qt::Widgets AND NOT no-png)
> >     add_subdirectory(linguist)
> > endif()
> > ...
> >
> > And according to configure.cmake we need to select print support:
> > ...
> > qt_feature("linguist" PRIVATE
> >     LABEL "Qt Linguist"
> >     PURPOSE "Qt Linguist can be used by translator to translate text in Qt applications."
> >     CONDITION TARGET Qt::PrintSupport
> > )
> > ...
> >
> > Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
> > ---
> >  package/qt6/qt6tools/Config.in   | 11 +++++++++++
> >  package/qt6/qt6tools/qt6tools.mk | 10 ++++++++--
> >  2 files changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/qt6/qt6tools/Config.in b/package/qt6/qt6tools/Config.in
> > index 5f52c5644f..eea461a2a9 100644
> > --- a/package/qt6/qt6tools/Config.in
> > +++ b/package/qt6/qt6tools/Config.in
> > @@ -15,3 +15,14 @@ config BR2_PACKAGE_QT6TOOLS
> >         and design of applications.
> >
> >         https://github.com/qt/qttools
> > +
> > +if BR2_PACKAGE_QT6TOOLS
> > +
> > +config BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS
> > +     bool "linguist tools (host)"
> > +     select BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT
> > +     help
> > +       Translate Qt C++ and Qt Quick applications into local
> > +       languages.
>
> This should go in a package/qt6/qt6tools/Config.in.host, not in
> Config.in as Config.in is for options that affect the target build.



>
> > +
> > +endif
> > diff --git a/package/qt6/qt6tools/qt6tools.mk b/package/qt6/qt6tools/qt6tools.mk
> > index 09c986cfc6..897cf43054 100644
> > --- a/package/qt6/qt6tools/qt6tools.mk
> > +++ b/package/qt6/qt6tools/qt6tools.mk
> > @@ -37,11 +37,17 @@ QT6TOOLS_DEPENDENCIES = \
> >       qt6base \
> >       host-qt6tools
> >
> > +HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
> > +
> > +ifeq ($(BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS),y)
> > +HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=ON
> > +else
> > +HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=OFF
> > +endif
>
> Please group these host package things...
>
> > +
> >  ifeq ($(BR2_PACKAGE_QT6DECLARATIVE),y)
> >  QT6TOOLS_DEPENDENCIES += qt6declarative
> >  endif
> >
> > -HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
>
> ... here. Rather than inter-twining target package and host package
> details.
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot