Re: [Buildroot] [PATCH] package/qt6/qt6connectivity: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Christian,

On Wed, 11 Sep 2024 15:12:29 +0200
Christian Hitz via buildroot <buildroot@buildroot.org> wrote:

> From: Christian Hitz <christian.hitz@bbv.ch>
> 
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>

Thanks a lot for your patch. However I'm afraid it looks like you have
copy/pasted qt5connectivity... but a number of things are not the same
and not correct due to that. See below.


> diff --git a/package/qt6/qt6connectivity/Config.in b/package/qt6/qt6connectivity/Config.in
> new file mode 100644
> index 0000000000..1ddd4a6ad0
> --- /dev/null
> +++ b/package/qt6/qt6connectivity/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_QT6CONNECTIVITY
> +	bool "qt6connectivity"
> +	depends on BR2_PACKAGE_NEARD || BR2_PACKAGE_BLUEZ5_UTILS

There is nothing related to neard support in qt6connectivity as far as
I can see.

Also, I believe bluez is not mandatory. I've done a build of
qt6connectivity with neither neard nor bluez5-utils and it did
build/install Qt6Nfc.

> +	select BR2_PACKAGE_QT6BASE_NETWORK
> +	select BR2_PACKAGE_QT6BASE_CONCURRENT
> +	select BR2_PACKAGE_QT6BASE_DBUS

Concurrent is definitely not needed.

DBus doesn't seem to be mandatory either (I tested to build without it,
and it built fine).

In order to package this, you need to do some minimal testing: build
with qt6base, with no other options enabled, and look at what is
*really* needed. Don't blindly copy/paste qt5connectivity, as things
have changed (or perhaps some things are also wrong in
qt5connectivity?).

Could you have a look into this to prepare a v2 that is more solid in
terms of how it handles dependencies?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot