Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/qt6/qt6connectivity: new package
@ 2024-09-11 13:12 Christian Hitz via buildroot
  2024-09-14 11:21 ` Thomas Petazzoni via buildroot
  2025-03-06 11:54 ` [Buildroot] [PATCH v2] " Christian Hitz via buildroot
  0 siblings, 2 replies; 5+ messages in thread
From: Christian Hitz via buildroot @ 2024-09-11 13:12 UTC (permalink / raw)
  To: buildroot
  Cc: Christian Hitz, Jesse Van Gavere, Samuel Martin,
	Roy Kollen Svendsen, Thomas Petazzoni

From: Christian Hitz <christian.hitz@bbv.ch>

Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
---
 package/qt6/Config.in                         |  1 +
 package/qt6/qt6connectivity/Config.in         | 18 +++++++++
 .../qt6/qt6connectivity/qt6connectivity.hash  | 11 ++++++
 .../qt6/qt6connectivity/qt6connectivity.mk    | 38 +++++++++++++++++++
 4 files changed, 68 insertions(+)
 create mode 100644 package/qt6/qt6connectivity/Config.in
 create mode 100644 package/qt6/qt6connectivity/qt6connectivity.hash
 create mode 100644 package/qt6/qt6connectivity/qt6connectivity.mk

diff --git a/package/qt6/Config.in b/package/qt6/Config.in
index 29c1c25c7f..799a955a7c 100644
--- a/package/qt6/Config.in
+++ b/package/qt6/Config.in
@@ -44,6 +44,7 @@ menuconfig BR2_PACKAGE_QT6
 if BR2_PACKAGE_QT6
 
 source "package/qt6/qt6base/Config.in"
+source "package/qt6/qt6connectivity/Config.in"
 source "package/qt6/qt6core5compat/Config.in"
 source "package/qt6/qt6declarative/Config.in"
 source "package/qt6/qt6languageserver/Config.in"
diff --git a/package/qt6/qt6connectivity/Config.in b/package/qt6/qt6connectivity/Config.in
new file mode 100644
index 0000000000..1ddd4a6ad0
--- /dev/null
+++ b/package/qt6/qt6connectivity/Config.in
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_QT6CONNECTIVITY
+	bool "qt6connectivity"
+	depends on BR2_PACKAGE_NEARD || BR2_PACKAGE_BLUEZ5_UTILS
+	select BR2_PACKAGE_QT6BASE_NETWORK
+	select BR2_PACKAGE_QT6BASE_CONCURRENT
+	select BR2_PACKAGE_QT6BASE_DBUS
+	help
+	  Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  Qt Connectivity module provides support for Bluetooth/NFC
+	  peripherials.
+
+	  https://doc.qt.io/qt-6/qtbluetooth-index.html
+	  https://doc.qt.io/qt-6/qtnfc-index.html
+
+comment "qt6connectivity needs neard and/or bluez5_utils"
+	depends on !BR2_PACKAGE_NEARD && !BR2_PACKAGE_BLUEZ5_UTILS
diff --git a/package/qt6/qt6connectivity/qt6connectivity.hash b/package/qt6/qt6connectivity/qt6connectivity.hash
new file mode 100644
index 0000000000..e090af9fef
--- /dev/null
+++ b/package/qt6/qt6connectivity/qt6connectivity.hash
@@ -0,0 +1,11 @@
+# Hash from: https://download.qt.io/official_releases/qt/6.7/6.7.2/submodules/qtconnectivity-everywhere-src-6.7.2.tar.xz.sha256
+sha256  8ed321b242f0e956473a295fa31670271f9b3acb797508644cb740f89f6c08e8  qtconnectivity-everywhere-src-6.7.2.tar.xz
+
+# Hashes for license files:
+sha256  9f0490f18656c6f2435bd14f603ef0c96434d1825615363dce43abb42ed1dcce  LICENSES/BSD-3-Clause.txt
+sha256  110535522396708cea37c72a802c5e7e81391139f5f7985631c93ef242b206a4  LICENSES/GFDL-1.3-no-invariants-only.txt
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  LICENSES/GPL-2.0-only.txt
+sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  LICENSES/GPL-3.0-only.txt
+sha256  da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768  LICENSES/LGPL-3.0-only.txt
+sha256  9b1f50aae6267f9d5e0ceb6775ee86450262c25ec7c0573e151fe5d3f18a4700  LICENSES/LicenseRef-Qt-Commercial.txt
+sha256  40678d338ce53cd93f8b22b281a2ecbcaa3ee65ce60b25ffb0c462b0530846b2  LICENSES/Qt-GPL-exception-1.0.txt
diff --git a/package/qt6/qt6connectivity/qt6connectivity.mk b/package/qt6/qt6connectivity/qt6connectivity.mk
new file mode 100644
index 0000000000..0cfdd5eee1
--- /dev/null
+++ b/package/qt6/qt6connectivity/qt6connectivity.mk
@@ -0,0 +1,38 @@
+################################################################################
+#
+# qt6connectivity
+#
+################################################################################
+
+QT6CONNECTIVITY_VERSION = $(QT6_VERSION)
+QT6CONNECTIVITY_SITE = $(QT6_SITE)
+QT6CONNECTIVITY_SOURCE = qtconnectivity-$(QT6_SOURCE_TARBALL_PREFIX)-$(QT6CONNECTIVITY_VERSION).tar.xz
+QT6CONNECTIVITY_INSTALL_STAGING = YES
+QT6CONNECTIVITY_SUPPORTS_IN_SOURCE_BUILD = NO
+
+QT6CONNECTIVITY_CMAKE_BACKEND = ninja
+
+QT6CONNECTIVITY_LICENSE = \
+	GPL-2.0+ or LGPL-3.0, \
+	GPL-3.0, GFDL-1.3 no invariants (docs)
+
+QT6CONNECTIVITY_LICENSE_FILES = \
+	LICENSES/Apache-2.0.txt \
+	LICENSES/GPL-2.0-only.txt \
+	LICENSES/GPL-3.0-only.txt \
+	LICENSES/LGPL-3.0-only.txt \
+	LICENSES/GFDL-1.3-no-invariants-only.txt
+
+QT6CONNECTIVITY_CONF_OPTS = \
+	-DQT_HOST_PATH=$(HOST_DIR) \
+	-DBUILD_WITH_PCH=OFF \
+	-DQT_BUILD_EXAMPLES=OFF \
+	-DQT_BUILD_TESTS=OFF
+
+QT6CONNECTIVITY_DEPENDENCIES = \
+	qt6base
+
+QT6CONNECTIVITY_DEPENDENCIES += $(if $(BR2_PACKAGE_BLUEZ5_UTILS),bluez5_utils)
+QT6CONNECTIVITY_DEPENDENCIES += $(if $(BR2_PACKAGE_NEARD),neard)
+
+$(eval $(cmake-package))
-- 
2.46.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/qt6/qt6connectivity: new package
  2024-09-11 13:12 [Buildroot] [PATCH] package/qt6/qt6connectivity: new package Christian Hitz via buildroot
@ 2024-09-14 11:21 ` Thomas Petazzoni via buildroot
  2025-03-06  9:35   ` christian--- via buildroot
  2025-03-06 11:54 ` [Buildroot] [PATCH v2] " Christian Hitz via buildroot
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-09-14 11:21 UTC (permalink / raw)
  To: Christian Hitz via buildroot
  Cc: Christian Hitz, Christian Hitz, Jesse Van Gavere, Samuel Martin,
	Roy Kollen Svendsen

Hello Christian,

On Wed, 11 Sep 2024 15:12:29 +0200
Christian Hitz via buildroot <buildroot@buildroot.org> wrote:

> From: Christian Hitz <christian.hitz@bbv.ch>
> 
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>

Thanks a lot for your patch. However I'm afraid it looks like you have
copy/pasted qt5connectivity... but a number of things are not the same
and not correct due to that. See below.


> diff --git a/package/qt6/qt6connectivity/Config.in b/package/qt6/qt6connectivity/Config.in
> new file mode 100644
> index 0000000000..1ddd4a6ad0
> --- /dev/null
> +++ b/package/qt6/qt6connectivity/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_QT6CONNECTIVITY
> +	bool "qt6connectivity"
> +	depends on BR2_PACKAGE_NEARD || BR2_PACKAGE_BLUEZ5_UTILS

There is nothing related to neard support in qt6connectivity as far as
I can see.

Also, I believe bluez is not mandatory. I've done a build of
qt6connectivity with neither neard nor bluez5-utils and it did
build/install Qt6Nfc.

> +	select BR2_PACKAGE_QT6BASE_NETWORK
> +	select BR2_PACKAGE_QT6BASE_CONCURRENT
> +	select BR2_PACKAGE_QT6BASE_DBUS

Concurrent is definitely not needed.

DBus doesn't seem to be mandatory either (I tested to build without it,
and it built fine).

In order to package this, you need to do some minimal testing: build
with qt6base, with no other options enabled, and look at what is
*really* needed. Don't blindly copy/paste qt5connectivity, as things
have changed (or perhaps some things are also wrong in
qt5connectivity?).

Could you have a look into this to prepare a v2 that is more solid in
terms of how it handles dependencies?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/qt6/qt6connectivity: new package
  2024-09-14 11:21 ` Thomas Petazzoni via buildroot
@ 2025-03-06  9:35   ` christian--- via buildroot
  0 siblings, 0 replies; 5+ messages in thread
From: christian--- via buildroot @ 2025-03-06  9:35 UTC (permalink / raw)
  To: Thomas Petazzoni
  Cc: Christian Hitz via buildroot, Christian Hitz, Jesse Van Gavere,
	Samuel Martin, Roy Kollen Svendsen

Hello Thomas

Thanks for the review.

Am 2024-09-14 13:21, schrieb Thomas Petazzoni:
>> +++ b/package/qt6/qt6connectivity/Config.in
>> @@ -0,0 +1,18 @@
>> +config BR2_PACKAGE_QT6CONNECTIVITY
>> +	bool "qt6connectivity"
>> +	depends on BR2_PACKAGE_NEARD || BR2_PACKAGE_BLUEZ5_UTILS
> 
> There is nothing related to neard support in qt6connectivity as far as
> I can see.
The qt6connectivity module uses neard to provide NFC services on Linux. 
[1]
DBus is used to communicate with neard. Technically, the neard
dependency is runtime only.

> 
> Also, I believe bluez is not mandatory. I've done a build of
> qt6connectivity with neither neard nor bluez5-utils and it did
> build/install Qt6Nfc.
I tried to reduce the bluez dependency down to runtime-only, but if
bluez is not available at compile time, QBluetooth is only built
with a dummy backend, skipping the relevant bluez backend.

> 
>> +	select BR2_PACKAGE_QT6BASE_NETWORK
>> +	select BR2_PACKAGE_QT6BASE_CONCURRENT
>> +	select BR2_PACKAGE_QT6BASE_DBUS
> 
> Concurrent is definitely not needed.
Agreed.

> DBus doesn't seem to be mandatory either (I tested to build without it,
> and it built fine).
Network and DBus are required to build. [2] [3] [4]

I will sent a v2 version addressing these points.

Regards,
Christian

[1] 
https://github.com/qt/qtconnectivity/blob/817a2ccffba47d5dd1175a2a10e8ac6628570314/src/nfc/configure.cmake#L10
[2] 
https://github.com/qt/qtconnectivity/blob/817a2ccffba47d5dd1175a2a10e8ac6628570314/src/bluetooth/CMakeLists.txt#L45
[3] 
https://github.com/qt/qtconnectivity/blob/817a2ccffba47d5dd1175a2a10e8ac6628570314/src/bluetooth/CMakeLists.txt#L96
[4] 
https://github.com/qt/qtconnectivity/blob/817a2ccffba47d5dd1175a2a10e8ac6628570314/src/nfc/CMakeLists.txt#L113
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2] package/qt6/qt6connectivity: new package
  2024-09-11 13:12 [Buildroot] [PATCH] package/qt6/qt6connectivity: new package Christian Hitz via buildroot
  2024-09-14 11:21 ` Thomas Petazzoni via buildroot
@ 2025-03-06 11:54 ` Christian Hitz via buildroot
  2025-03-06 19:35   ` Roy Kollen Svendsen
  1 sibling, 1 reply; 5+ messages in thread
From: Christian Hitz via buildroot @ 2025-03-06 11:54 UTC (permalink / raw)
  To: buildroot
  Cc: Christian Hitz, Jesse Van Gavere, Roy Kollen Svendsen,
	Thomas Petazzoni

From: Christian Hitz <christian.hitz@bbv.ch>

Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
---
Changes v1 -> v2:
  - remove concurrent dependency
  - make dependency to neard runtime-only
  - fix licenses and their hashes
---
 package/qt6/Config.in                         |  1 +
 package/qt6/qt6connectivity/Config.in         | 17 ++++++++
 .../qt6/qt6connectivity/qt6connectivity.hash  | 11 +++++
 .../qt6/qt6connectivity/qt6connectivity.mk    | 42 +++++++++++++++++++
 4 files changed, 71 insertions(+)
 create mode 100644 package/qt6/qt6connectivity/Config.in
 create mode 100644 package/qt6/qt6connectivity/qt6connectivity.hash
 create mode 100644 package/qt6/qt6connectivity/qt6connectivity.mk

diff --git a/package/qt6/Config.in b/package/qt6/Config.in
index 10594691cf..3597417ef7 100644
--- a/package/qt6/Config.in
+++ b/package/qt6/Config.in
@@ -45,6 +45,7 @@ if BR2_PACKAGE_QT6
 
 source "package/qt6/qt6base/Config.in"
 source "package/qt6/qt6charts/Config.in"
+source "package/qt6/qt6connectivity/Config.in"
 source "package/qt6/qt6core5compat/Config.in"
 source "package/qt6/qt6declarative/Config.in"
 source "package/qt6/qt6graphs/Config.in"
diff --git a/package/qt6/qt6connectivity/Config.in b/package/qt6/qt6connectivity/Config.in
new file mode 100644
index 0000000000..ba329d732e
--- /dev/null
+++ b/package/qt6/qt6connectivity/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_QT6CONNECTIVITY
+	bool "qt6connectivity"
+	depends on BR2_PACKAGE_NEARD || BR2_PACKAGE_BLUEZ5_UTILS
+	select BR2_PACKAGE_QT6BASE_NETWORK
+	select BR2_PACKAGE_QT6BASE_DBUS
+	help
+	  Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  Qt Connectivity module provides support for Bluetooth/NFC
+	  peripherials.
+
+	  https://doc.qt.io/qt-6/qtbluetooth-index.html
+	  https://doc.qt.io/qt-6/qtnfc-index.html
+
+comment "qt6connectivity needs neard and/or bluez5_utils"
+	depends on !BR2_PACKAGE_NEARD && !BR2_PACKAGE_BLUEZ5_UTILS
diff --git a/package/qt6/qt6connectivity/qt6connectivity.hash b/package/qt6/qt6connectivity/qt6connectivity.hash
new file mode 100644
index 0000000000..f2c10a0adb
--- /dev/null
+++ b/package/qt6/qt6connectivity/qt6connectivity.hash
@@ -0,0 +1,11 @@
+# Hash from: https://download.qt.io/official_releases/qt/6.8/6.8.1/submodules/qtconnectivity-everywhere-src-6.8.1.tar.xz.sha256
+sha256  ccfd46e7ad2290710788274e145fb1f224d8a5ce360764ec10824b5908a6441c  qtconnectivity-everywhere-src-6.8.1.tar.xz
+
+# Hashes for license files:
+sha256  e3ba223bb1423f0aad8c3dfce0fe3148db48926d41e6fbc3afbbf5ff9e1c89cb  LICENSES/Apache-2.0.txt
+sha256  9f0490f18656c6f2435bd14f603ef0c96434d1825615363dce43abb42ed1dcce  LICENSES/BSD-3-Clause.txt
+sha256  110535522396708cea37c72a802c5e7e81391139f5f7985631c93ef242b206a4  LICENSES/GFDL-1.3-no-invariants-only.txt
+sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  LICENSES/GPL-2.0-only.txt
+sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903  LICENSES/GPL-3.0-only.txt
+sha256  da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768  LICENSES/LGPL-3.0-only.txt
+sha256  40678d338ce53cd93f8b22b281a2ecbcaa3ee65ce60b25ffb0c462b0530846b2  LICENSES/Qt-GPL-exception-1.0.txt
diff --git a/package/qt6/qt6connectivity/qt6connectivity.mk b/package/qt6/qt6connectivity/qt6connectivity.mk
new file mode 100644
index 0000000000..4d77b2328b
--- /dev/null
+++ b/package/qt6/qt6connectivity/qt6connectivity.mk
@@ -0,0 +1,42 @@
+################################################################################
+#
+# qt6connectivity
+#
+################################################################################
+
+QT6CONNECTIVITY_VERSION = $(QT6_VERSION)
+QT6CONNECTIVITY_SITE = $(QT6_SITE)
+QT6CONNECTIVITY_SOURCE = qtconnectivity-$(QT6_SOURCE_TARBALL_PREFIX)-$(QT6CONNECTIVITY_VERSION).tar.xz
+QT6CONNECTIVITY_INSTALL_STAGING = YES
+QT6CONNECTIVITY_SUPPORTS_IN_SOURCE_BUILD = NO
+
+QT6CONNECTIVITY_CMAKE_BACKEND = ninja
+
+QT6CONNECTIVITY_LICENSE = \
+	GPL-2.0 or GPL-3.0 or LGPL-3.0, \
+	GPL-3.0 with Qt GPL exception 1.0 (sdpscanner), \
+	BSD-3-Clause (build system, examples), \
+	Apache-2.0 (examples), \
+	GPL-3.0, GFDL-1.3 no invariants (docs)
+
+QT6CONNECTIVITY_LICENSE_FILES = \
+	LICENSES/Apache-2.0.txt \
+	LICENSES/BSD-3-Clause.txt \
+	LICENSES/GFDL-1.3-no-invariants-only.txt \
+	LICENSES/GPL-2.0-only.txt \
+	LICENSES/GPL-3.0-only.txt \
+	LICENSES/LGPL-3.0-only.txt \
+	LICENSES/Qt-GPL-exception-1.0.txt
+
+QT6CONNECTIVITY_CONF_OPTS = \
+	-DQT_HOST_PATH=$(HOST_DIR) \
+	-DBUILD_WITH_PCH=OFF \
+	-DQT_BUILD_EXAMPLES=OFF \
+	-DQT_BUILD_TESTS=OFF
+
+QT6CONNECTIVITY_DEPENDENCIES = \
+	qt6base
+
+QT6CONNECTIVITY_DEPENDENCIES += $(if $(BR2_PACKAGE_BLUEZ5_UTILS),bluez5_utils)
+
+$(eval $(cmake-package))
-- 
2.48.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH v2] package/qt6/qt6connectivity: new package
  2025-03-06 11:54 ` [Buildroot] [PATCH v2] " Christian Hitz via buildroot
@ 2025-03-06 19:35   ` Roy Kollen Svendsen
  0 siblings, 0 replies; 5+ messages in thread
From: Roy Kollen Svendsen @ 2025-03-06 19:35 UTC (permalink / raw)
  To: Christian Hitz
  Cc: buildroot, Christian Hitz, Jesse Van Gavere, Thomas Petazzoni


[-- Attachment #1.1: Type: text/plain, Size: 6005 bytes --]

Hi Christian,

Here are some superficial comments. I'll dig deeper when I have some spare
time.

Please also make a patch based on the series that bumps Qt to v6.8.2.

Regards,
Roy

tor. 6. mars 2025 kl. 12:54 skrev Christian Hitz <christian@klarinett.li>:

> From: Christian Hitz <christian.hitz@bbv.ch>
>
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> ---
> Changes v1 -> v2:
>   - remove concurrent dependency
>   - make dependency to neard runtime-only
>   - fix licenses and their hashes
> ---
>  package/qt6/Config.in                         |  1 +
>  package/qt6/qt6connectivity/Config.in         | 17 ++++++++
>  .../qt6/qt6connectivity/qt6connectivity.hash  | 11 +++++
>  .../qt6/qt6connectivity/qt6connectivity.mk    | 42 +++++++++++++++++++
>  4 files changed, 71 insertions(+)
>  create mode 100644 package/qt6/qt6connectivity/Config.in
>  create mode 100644 package/qt6/qt6connectivity/qt6connectivity.hash
>  create mode 100644 package/qt6/qt6connectivity/qt6connectivity.mk
>
> diff --git a/package/qt6/Config.in b/package/qt6/Config.in
> index 10594691cf..3597417ef7 100644
> --- a/package/qt6/Config.in
> +++ b/package/qt6/Config.in
> @@ -45,6 +45,7 @@ if BR2_PACKAGE_QT6
>
>  source "package/qt6/qt6base/Config.in"
>  source "package/qt6/qt6charts/Config.in"
> +source "package/qt6/qt6connectivity/Config.in"
>  source "package/qt6/qt6core5compat/Config.in"
>  source "package/qt6/qt6declarative/Config.in"
>  source "package/qt6/qt6graphs/Config.in"
> diff --git a/package/qt6/qt6connectivity/Config.in
> b/package/qt6/qt6connectivity/Config.in
> new file mode 100644
> index 0000000000..ba329d732e
> --- /dev/null
> +++ b/package/qt6/qt6connectivity/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_QT6CONNECTIVITY
> +       bool "qt6connectivity"
> +       depends on BR2_PACKAGE_NEARD || BR2_PACKAGE_BLUEZ5_UTILS
> +       select BR2_PACKAGE_QT6BASE_NETWORK
> +       select BR2_PACKAGE_QT6BASE_DBUS
> +       help
> +         Qt is a cross-platform application and UI framework for
> +         developers using C++.
> +
> +         Qt Connectivity module provides support for Bluetooth/NFC
> +         peripherials.
> +
> +         https://doc.qt.io/qt-6/qtbluetooth-index.html
> +         https://doc.qt.io/qt-6/qtnfc-index.html
> +
> +comment "qt6connectivity needs neard and/or bluez5_utils"
> +       depends on !BR2_PACKAGE_NEARD && !BR2_PACKAGE_BLUEZ5_UTILS
> diff --git a/package/qt6/qt6connectivity/qt6connectivity.hash
> b/package/qt6/qt6connectivity/qt6connectivity.hash
> new file mode 100644
> index 0000000000..f2c10a0adb
> --- /dev/null
> +++ b/package/qt6/qt6connectivity/qt6connectivity.hash
> @@ -0,0 +1,11 @@
> +# Hash from:
> https://download.qt.io/official_releases/qt/6.8/6.8.1/submodules/qtconnectivity-everywhere-src-6.8.1.tar.xz.sha256
> +sha256
> <https://download.qt.io/official_releases/qt/6.8/6.8.1/submodules/qtconnectivity-everywhere-src-6.8.1.tar.xz.sha256+sha256>
> ccfd46e7ad2290710788274e145fb1f224d8a5ce360764ec10824b5908a6441c
> qtconnectivity-everywhere-src-6.8.1.tar.xz
> +
> +# Hashes for license files:
> +sha256  e3ba223bb1423f0aad8c3dfce0fe3148db48926d41e6fbc3afbbf5ff9e1c89cb
> LICENSES/Apache-2.0.txt
> +sha256  9f0490f18656c6f2435bd14f603ef0c96434d1825615363dce43abb42ed1dcce
> LICENSES/BSD-3-Clause.txt
> +sha256  110535522396708cea37c72a802c5e7e81391139f5f7985631c93ef242b206a4
> LICENSES/GFDL-1.3-no-invariants-only.txt
> +sha256  8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643
> LICENSES/GPL-2.0-only.txt
> +sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903
> LICENSES/GPL-3.0-only.txt
> +sha256  da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768
> LICENSES/LGPL-3.0-only.txt
> +sha256  40678d338ce53cd93f8b22b281a2ecbcaa3ee65ce60b25ffb0c462b0530846b2
> LICENSES/Qt-GPL-exception-1.0.txt
> diff --git a/package/qt6/qt6connectivity/qt6connectivity.mk
> b/package/qt6/qt6connectivity/qt6connectivity.mk
> new file mode 100644
> index 0000000000..4d77b2328b
> --- /dev/null
> +++ b/package/qt6/qt6connectivity/qt6connectivity.mk
> @@ -0,0 +1,42 @@
>
> +################################################################################
> +#
> +# qt6connectivity
> +#
>
> +################################################################################
> +
> +QT6CONNECTIVITY_VERSION = $(QT6_VERSION)
> +QT6CONNECTIVITY_SITE = $(QT6_SITE)
> +QT6CONNECTIVITY_SOURCE =
> qtconnectivity-$(QT6_SOURCE_TARBALL_PREFIX)-$(QT6CONNECTIVITY_VERSION).tar.xz
> +QT6CONNECTIVITY_INSTALL_STAGING = YES
> +QT6CONNECTIVITY_SUPPORTS_IN_SOURCE_BUILD = NO
> +
>

Remove this empty line when the next variable definition is only one line.
No reason to emphasize this line.


> +QT6CONNECTIVITY_CMAKE_BACKEND = ninja
> +
> +QT6CONNECTIVITY_LICENSE = \
> +       GPL-2.0 or GPL-3.0 or LGPL-3.0, \
> +       GPL-3.0 with Qt GPL exception 1.0 (sdpscanner), \
> +       BSD-3-Clause (build system, examples), \
> +       Apache-2.0 (examples), \
> +       GPL-3.0, GFDL-1.3 no invariants (docs)
>

Only keep licenses for what ends up on target, and only the top level
license is necessary. (I think)


> +
> +QT6CONNECTIVITY_LICENSE_FILES = \
> +       LICENSES/Apache-2.0.txt \
> +       LICENSES/BSD-3-Clause.txt \
> +       LICENSES/GFDL-1.3-no-invariants-only.txt \
> +       LICENSES/GPL-2.0-only.txt \
> +       LICENSES/GPL-3.0-only.txt \
> +       LICENSES/LGPL-3.0-only.txt \
> +       LICENSES/Qt-GPL-exception-1.0.txt
> +
> +QT6CONNECTIVITY_CONF_OPTS = \
> +       -DQT_HOST_PATH=$(HOST_DIR) \
> +       -DBUILD_WITH_PCH=OFF \
> +       -DQT_BUILD_EXAMPLES=OFF \
>
+       -DQT_BUILD_TESTS=OFF
>
+
> +QT6CONNECTIVITY_DEPENDENCIES = \
>
+       qt6base
>

No reason to break this line since it only contains one element

+
> +QT6CONNECTIVITY_DEPENDENCIES += $(if
> $(BR2_PACKAGE_BLUEZ5_UTILS),bluez5_utils)
>

Check the documentation for how to do optional dependencies:

https://buildroot.org/downloads/manual/manual.html (16.2)




> +
> +$(eval $(cmake-package))
> --
> 2.48.1
>
>

[-- Attachment #1.2: Type: text/html, Size: 9827 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-06 19:35 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-11 13:12 [Buildroot] [PATCH] package/qt6/qt6connectivity: new package Christian Hitz via buildroot
2024-09-14 11:21 ` Thomas Petazzoni via buildroot
2025-03-06  9:35   ` christian--- via buildroot
2025-03-06 11:54 ` [Buildroot] [PATCH v2] " Christian Hitz via buildroot
2025-03-06 19:35   ` Roy Kollen Svendsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox