[Buildroot] [PATCH] bluez5_utils: disable asha profile

[Buildroot] [PATCH] bluez5_utils: disable asha profile

[Parthiban Nallathambi]

asha profile as it depends on audio profile which isn't selected
by default (BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO), results in
below linking failure.

ld: profiles/audio/bluetoothd-asha.o: in function `get_transport':
asha.c:(.text.get_transport+0x2c): undefined reference to `media_transport_get_path'

Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
---
 package/bluez5_utils/bluez5_utils.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
index b1caef5cc5..59eb68de61 100644
--- a/package/bluez5_utils/bluez5_utils.mk
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -28,6 +28,7 @@ BLUEZ5_UTILS_CONF_OPTS = \
 	--disable-lsan \
 	--disable-ubsan \
 	--disable-pie \
+	--disable-asha \
 	--with-dbusconfdir=/etc
 
 ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_OBEX),y)
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] bluez5_utils: disable asha profile

[Thomas Petazzoni via buildroot]

Hello Parthiban,

On Sat, 14 Sep 2024 18:24:05 +0530
Parthiban Nallathambi <parthiban@linumiz.com> wrote:

> asha profile as it depends on audio profile which isn't selected
> by default (BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO), results in
> below linking failure.
> 
> ld: profiles/audio/bluetoothd-asha.o: in function `get_transport':
> asha.c:(.text.get_transport+0x2c): undefined reference to `media_transport_get_path'
> 
> Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>

Thanks for the patch! I believe it's fixing an autobuilder failure,
isn't it? If that's the case, then we like to have:

Fixes:

  http://autobuild.buildroot.net/results/75cd510e55d50a1a2da6e9e285ec7a09201d854a/

in the commit message. Of course the reference above is a random build
failure. Could you provide that information? I don't think you really
need to send a new iteration of this patch, just provide a reference to
the autobuilder build failure. But for next patches, you will know it's
something we like to have :-)

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] bluez5_utils: disable asha profile

[Parthiban]

Hi Thomas,

On 9/14/24 6:46 PM, Thomas Petazzoni via buildroot wrote:> Hello Parthiban,
> 
> On Sat, 14 Sep 2024 18:24:05 +0530
> Parthiban Nallathambi <parthiban@linumiz.com> wrote:
> 
>> asha profile as it depends on audio profile which isn't selected
>> by default (BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO), results in
>> below linking failure.
>>
>> ld: profiles/audio/bluetoothd-asha.o: in function `get_transport':
>> asha.c:(.text.get_transport+0x2c): undefined reference to `media_transport_get_path'
>>
>> Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
> 
> Thanks for the patch! I believe it's fixing an autobuilder failure,
> isn't it? If that's the case, then we like to have:
> 
> Fixes:
> 
>   http://autobuild.buildroot.net/results/75cd510e55d50a1a2da6e9e285ec7a09201d854a/
> 
> in the commit message. Of course the reference above is a random build
> failure. Could you provide that information? I don't think you really
> need to send a new iteration of this patch, just provide a reference to
> the autobuilder build failure. But for next patches, you will know it's
> something we like to have :-)

Missed it, it fixes: http://autobuild.buildroot.org/results/317bf4ad2593b1d1a8aec82cc0b3265285f00b7b/

Thanks,
Parthiban N

> 
> Best regards,
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] bluez5_utils: disable asha profile

[Yann E. MORIN]

Parthiban, All,

On 2024-09-14 18:24 +0530, Parthiban Nallathambi spake thusly:
> asha profile as it depends on audio profile which isn't selected
> by default (BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO), results in
> below linking failure.
> 
> ld: profiles/audio/bluetoothd-asha.o: in function `get_transport':
> asha.c:(.text.get_transport+0x2c): undefined reference to `media_transport_get_path'
> 
> Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>

Applied to master with the autobuild reference you later mentionned,
thanks!

Regards,
Yann E. MORIN.

> ---
>  package/bluez5_utils/bluez5_utils.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> index b1caef5cc5..59eb68de61 100644
> --- a/package/bluez5_utils/bluez5_utils.mk
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -28,6 +28,7 @@ BLUEZ5_UTILS_CONF_OPTS = \
>  	--disable-lsan \
>  	--disable-ubsan \
>  	--disable-pie \
> +	--disable-asha \
>  	--with-dbusconfdir=/etc
>  
>  ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_OBEX),y)
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] bluez5_utils: disable asha profile

[Yann E. MORIN]

Parthiban, Marcin, All,

On 2024-09-14 18:24 +0530, Parthiban Nallathambi spake thusly:
> asha profile as it depends on audio profile which isn't selected
> by default (BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO), results in
> below linking failure.
> 
> ld: profiles/audio/bluetoothd-asha.o: in function `get_transport':
> asha.c:(.text.get_transport+0x2c): undefined reference to `media_transport_get_path'

We still get a lot of similar failures:

https://autobuild.buildroot.org/results/730/730310de50273c503eca42e03c7ff263a3cc12b5/build-end.log
https://autobuild.buildroot.org/results/6f3/6f3a1dbd722286ae6a9e826ea21e9ca57d258ff3/build-end.log

Could you have a look, please?

Regards,
Yann E. MORIN.

> Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
> ---
>  package/bluez5_utils/bluez5_utils.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
> index b1caef5cc5..59eb68de61 100644
> --- a/package/bluez5_utils/bluez5_utils.mk
> +++ b/package/bluez5_utils/bluez5_utils.mk
> @@ -28,6 +28,7 @@ BLUEZ5_UTILS_CONF_OPTS = \
>  	--disable-lsan \
>  	--disable-ubsan \
>  	--disable-pie \
> +	--disable-asha \
>  	--with-dbusconfdir=/etc
>  
>  ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_OBEX),y)
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] bluez5_utils: disable asha profile

[James Hilliard]

[-- Attachment #1.1: Type: text/plain, Size: 2542 bytes --]

On Mon, Sep 23, 2024 at 12:51 PM Yann E. MORIN <yann.morin.1998@free.fr>
wrote:

> Parthiban, Marcin, All,
>
> On 2024-09-14 18:24 +0530, Parthiban Nallathambi spake thusly:
> > asha profile as it depends on audio profile which isn't selected
> > by default (BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO), results in
> > below linking failure.
> >
> > ld: profiles/audio/bluetoothd-asha.o: in function `get_transport':
> > asha.c:(.text.get_transport+0x2c): undefined reference to
> `media_transport_get_path'
>
> We still get a lot of similar failures:
>
>
> https://autobuild.buildroot.org/results/730/730310de50273c503eca42e03c7ff263a3cc12b5/build-end.log
>
> https://autobuild.buildroot.org/results/6f3/6f3a1dbd722286ae6a9e826ea21e9ca57d258ff3/build-end.log
>
> Could you have a look, please?
>

We need to enable asha when a2dp is enabled:
https://patchwork.ozlabs.org/project/buildroot/patch/20241003165926.849456-1-james.hilliard1@gmail.com/


>
> Regards,
> Yann E. MORIN.
>
> > Signed-off-by: Parthiban Nallathambi <parthiban@linumiz.com>
> > ---
> >  package/bluez5_utils/bluez5_utils.mk | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/package/bluez5_utils/bluez5_utils.mk
> b/package/bluez5_utils/bluez5_utils.mk
> > index b1caef5cc5..59eb68de61 100644
> > --- a/package/bluez5_utils/bluez5_utils.mk
> > +++ b/package/bluez5_utils/bluez5_utils.mk
> > @@ -28,6 +28,7 @@ BLUEZ5_UTILS_CONF_OPTS = \
> >       --disable-lsan \
> >       --disable-ubsan \
> >       --disable-pie \
> > +     --disable-asha \
> >       --with-dbusconfdir=/etc
> >
> >  ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_OBEX),y)
> > --
> > 2.39.2
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
>
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
> conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
>      |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is
> no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
>  conspiracy.  |
>
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
>

[-- Attachment #1.2: Type: text/html, Size: 4470 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot