[Buildroot] [PATCH v2 1/1] package/bluez5_utils: enable asha/bass when building audio plugins

[Buildroot] [PATCH v2 1/1] package/bluez5_utils: enable asha/bass when building audio plugins

[James Hilliard]

Symbols from the asha plugin are required when building a2dp
support as part of the audio plugins, so always enable asha
when audio plugins are selected.

Symbols from the bass plugin are required when building bap
support as part of the audio plugins, so always enable bass
when audio plugins are selected.

This issue appeared during an attempt to fix a related issue in
ce4e5fd129b557ac0411d0a0704be43717310d6d.

Fixes:
 - http://autobuild.buildroot.net/results/5a3/5a306356f5f190a14a0a2294a4428544b1a018bb
 - http://autobuild.buildroot.net/results/353/3539c83deaa45a3548bcd488659148c62af3fc73

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Cc: Frank TEO <frank128@ymail.com>
---
Changes v1 -> v2:
  - also enable/disable bass plugin
---
 package/bluez5_utils/bluez5_utils.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/package/bluez5_utils/bluez5_utils.mk b/package/bluez5_utils/bluez5_utils.mk
index 13a8ce2f0b..717c10e870 100644
--- a/package/bluez5_utils/bluez5_utils.mk
+++ b/package/bluez5_utils/bluez5_utils.mk
@@ -28,7 +28,6 @@ BLUEZ5_UTILS_CONF_OPTS = \
 	--disable-lsan \
 	--disable-ubsan \
 	--disable-pie \
-	--disable-asha \
 	--with-dbusconfdir=/etc
 
 ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_OBEX),y)
@@ -68,15 +67,19 @@ endif
 ifeq ($(BR2_PACKAGE_BLUEZ5_UTILS_PLUGINS_AUDIO),y)
 BLUEZ5_UTILS_CONF_OPTS += \
 	--enable-a2dp \
+	--enable-asha \
 	--enable-avrcp \
 	--enable-bap \
+	--enable-bass \
 	--enable-mcp \
 	--enable-vcp
 else
 BLUEZ5_UTILS_CONF_OPTS += \
 	--disable-a2dp \
+	--disable-asha \
 	--disable-avrcp \
 	--disable-bap \
+	--disable-bass \
 	--disable-mcp \
 	--disable-vcp
 endif
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/bluez5_utils: enable asha/bass when building audio plugins

[Florian Fainelli]

On 10/4/2024 10:27 AM, James Hilliard wrote:
> Symbols from the asha plugin are required when building a2dp
> support as part of the audio plugins, so always enable asha
> when audio plugins are selected.
> 
> Symbols from the bass plugin are required when building bap
> support as part of the audio plugins, so always enable bass
> when audio plugins are selected.
> 
> This issue appeared during an attempt to fix a related issue in
> ce4e5fd129b557ac0411d0a0704be43717310d6d.
> 
> Fixes:
>   - http://autobuild.buildroot.net/results/5a3/5a306356f5f190a14a0a2294a4428544b1a018bb
>   - http://autobuild.buildroot.net/results/353/3539c83deaa45a3548bcd488659148c62af3fc73
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

This does fix the build failure I just got that was identical to the one 
reported in the above two links. Thanks!

Tested-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 1/1] package/bluez5_utils: enable asha/bass when building audio plugins

[Thomas Petazzoni via buildroot]

On Fri,  4 Oct 2024 11:27:07 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Symbols from the asha plugin are required when building a2dp
> support as part of the audio plugins, so always enable asha
> when audio plugins are selected.
> 
> Symbols from the bass plugin are required when building bap
> support as part of the audio plugins, so always enable bass
> when audio plugins are selected.
> 
> This issue appeared during an attempt to fix a related issue in
> ce4e5fd129b557ac0411d0a0704be43717310d6d.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/5a3/5a306356f5f190a14a0a2294a4428544b1a018bb
>  - http://autobuild.buildroot.net/results/353/3539c83deaa45a3548bcd488659148c62af3fc73
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> Cc: Frank TEO <frank128@ymail.com>
> ---
> Changes v1 -> v2:
>   - also enable/disable bass plugin
> ---
>  package/bluez5_utils/bluez5_utils.mk | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Applied to master, thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot