Re: [Buildroot] [PATCH] package/git: require wchar

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Brandon,

On Wed, 09 Oct 2024 20:44:24 -0500
Brandon Maier <brandon.maier@gmail.com> wrote:

> The latest release of git ported its unit-testing framework to a new
> library that uses wchar.
> 
> Commit that added wchar: https://github.com/git/git/commit/9b7caa2809cba618f2af702d35b12bc99535f2b9
> Fixes: http://autobuild.buildroot.org/results/15e/15e2f470ae6ba0c9c4bf40f306955aaa317bf87e//
> 
> Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> ---
>  package/git/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Thanks for the fix! But it needs some improvements:

- You need to update the Config.in comment in package/git/Config.in to
  mention this wchar dependency

- You need to look at reverse dependencies that "select
  BR2_PACKAGE_GIT" and propagate this wchar dependency. For example
  package/git-crypt/ will need it. And also the reverse dependencies of
  the reverse dependencies, if any;

Did you look at a way of disabling building the test suite? I very
quickly glanced through the git Makefile, and it didn't seem like there
was such a possibility. But if there was such a possibility, it would
be an alternative solution to the addition of the wchar dependency.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot