* [Buildroot] [PATCH] package/libcurl: fix build failure with verbose disabled
@ 2024-09-24 5:24 Baruch Siach via buildroot
2024-10-19 17:48 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach via buildroot @ 2024-09-24 5:24 UTC (permalink / raw)
To: buildroot
Add patch to fix build failure introduced in bump to version 8.10.0.
Fixes:
https://autobuild.buildroot.org/results/2d553687a32651f81813c82d7bbf9bb11fd3eca5/
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
...build-with-verbose-messages-disabled.patch | 44 +++++++++++++++++++
1 file changed, 44 insertions(+)
create mode 100644 package/libcurl/0001-curl_trc-fix-build-with-verbose-messages-disabled.patch
diff --git a/package/libcurl/0001-curl_trc-fix-build-with-verbose-messages-disabled.patch b/package/libcurl/0001-curl_trc-fix-build-with-verbose-messages-disabled.patch
new file mode 100644
index 000000000000..ffa44b87b646
--- /dev/null
+++ b/package/libcurl/0001-curl_trc-fix-build-with-verbose-messages-disabled.patch
@@ -0,0 +1,44 @@
+From 58d490091d097ba2ad108cc66c97e242e5aacb9c Mon Sep 17 00:00:00 2001
+Message-ID: <58d490091d097ba2ad108cc66c97e242e5aacb9c.1727153835.git.baruch@tkos.co.il>
+From: Baruch Siach <baruch@tkos.co.il>
+Date: Tue, 24 Sep 2024 07:52:13 +0300
+Subject: [PATCH] curl_trc: fix build with verbose messages disabled
+
+Add empty definition of Curl_trc_ws() to fix this following build error:
+
+In file included from sendf.h:29,
+ from ws.c:35:
+ws.c: In function 'Curl_ws_accept':
+curl_trc.h:100:10: error: implicit declaration of function 'Curl_trc_ws'; did you mean 'Curl_trc_ftp'? [-Wimplicit-function-declaration]
+ 100 | Curl_trc_ws(data, __VA_ARGS__); } while(0)
+ | ^~~~~~~~~~~
+ws.c:779:5: note: in expansion of macro 'CURL_TRC_WS'
+ 779 | CURL_TRC_WS(data, "WS, using chunk size %zu", chunk_size);
+ | ^~~~~~~~~~~
+
+Signed-off-by: Baruch Siach <baruch@tkos.co.il>
+Upstream: https://github.com/curl/curl/pull/15026
+---
+ lib/curl_trc.h | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/lib/curl_trc.h b/lib/curl_trc.h
+index 5f675b453fd3..1801d33cea7c 100644
+--- a/lib/curl_trc.h
++++ b/lib/curl_trc.h
+@@ -226,6 +226,12 @@ static void Curl_trc_smtp(struct Curl_easy *data, const char *fmt, ...)
+ (void)data; (void)fmt;
+ }
+ #endif
++#if defined(USE_WEBSOCKETS) && !defined(CURL_DISABLE_HTTP)
++static void Curl_trc_ws(struct Curl_easy *data, const char *fmt, ...)
++{
++ (void)data; (void)fmt;
++}
++#endif
+
+ #endif /* !defined(CURL_DISABLE_VERBOSE_STRINGS) */
+
+--
+2.45.2
+
--
2.45.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/libcurl: fix build failure with verbose disabled
2024-09-24 5:24 [Buildroot] [PATCH] package/libcurl: fix build failure with verbose disabled Baruch Siach via buildroot
@ 2024-10-19 17:48 ` Thomas Petazzoni via buildroot
2024-10-20 12:12 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-10-19 17:48 UTC (permalink / raw)
To: Baruch Siach via buildroot
On Tue, 24 Sep 2024 08:24:11 +0300
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:
> Add patch to fix build failure introduced in bump to version 8.10.0.
>
> Fixes:
> https://autobuild.buildroot.org/results/2d553687a32651f81813c82d7bbf9bb11fd3eca5/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> ...build-with-verbose-messages-disabled.patch | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 package/libcurl/0001-curl_trc-fix-build-with-verbose-messages-disabled.patch
Applied to master, thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/libcurl: fix build failure with verbose disabled
2024-10-19 17:48 ` Thomas Petazzoni via buildroot
@ 2024-10-20 12:12 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2024-10-20 12:12 UTC (permalink / raw)
To: Thomas Petazzoni via buildroot; +Cc: Thomas Petazzoni
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Tue, 24 Sep 2024 08:24:11 +0300
> Baruch Siach via buildroot <buildroot@buildroot.org> wrote:
>> Add patch to fix build failure introduced in bump to version 8.10.0.
>>
>> Fixes:
>> https://autobuild.buildroot.org/results/2d553687a32651f81813c82d7bbf9bb11fd3eca5/
>>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> ...build-with-verbose-messages-disabled.patch | 44 +++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>> create mode 100644 package/libcurl/0001-curl_trc-fix-build-with-verbose-messages-disabled.patch
> Applied to master, thanks!
Committed to 2024.02.x and 2024.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-20 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 5:24 [Buildroot] [PATCH] package/libcurl: fix build failure with verbose disabled Baruch Siach via buildroot
2024-10-19 17:48 ` Thomas Petazzoni via buildroot
2024-10-20 12:12 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox