[Buildroot] [PATCH] package/arm-gnu-toolchain: Add $(HOSTARCH) so can be built with aarch64

[Buildroot] [PATCH] package/arm-gnu-toolchain: Add $(HOSTARCH) so can be built with aarch64

[Bryce Johnson]

Was testing building with arm64 build server and failed because it
was downloading the x86_64 version.

Use $(HOSTARCH) instead so it can also downloaded

Tested with building configs/ti_am62x_sk_defconfig on arm64 that it
uses to build the 32bit R5 MCU.

Signed-off-by: Bryce Johnson <bryce@redpinelabs.com>
---
 package/arm-gnu-toolchain/arm-gnu-toolchain.hash | 2 ++
 package/arm-gnu-toolchain/arm-gnu-toolchain.mk   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/arm-gnu-toolchain/arm-gnu-toolchain.hash b/package/arm-gnu-toolchain/arm-gnu-toolchain.hash
index 0800fa2168..110ec40c09 100644
--- a/package/arm-gnu-toolchain/arm-gnu-toolchain.hash
+++ b/package/arm-gnu-toolchain/arm-gnu-toolchain.hash
@@ -1,2 +1,4 @@
 # taken from https://developer.arm.com/-/media/Files/downloads/gnu/13.2.rel1/binrel/arm-gnu-toolchain-13.2.rel1-x86_64-arm-none-eabi.tar.xz.sha256asc
 sha256  6cd1bbc1d9ae57312bcd169ae283153a9572bd6a8e4eeae2fedfbc33b115fdbb  arm-gnu-toolchain-13.2.rel1-x86_64-arm-none-eabi.tar.xz
+# taken from https://developer.arm.com/-/media/Files/downloads/gnu/13.2.rel1/binrel/arm-gnu-toolchain-13.2.rel1-aarch64-arm-none-eabi.tar.xz.sha256asc
+sha256  8fd8b4a0a8d44ab2e195ccfbeef42223dfb3ede29d80f14dcf2183c34b8d199a  arm-gnu-toolchain-13.2.rel1-aarch64-arm-none-eabi.tar.xz
diff --git a/package/arm-gnu-toolchain/arm-gnu-toolchain.mk b/package/arm-gnu-toolchain/arm-gnu-toolchain.mk
index 03bb4dc5da..fce80f2f3a 100644
--- a/package/arm-gnu-toolchain/arm-gnu-toolchain.mk
+++ b/package/arm-gnu-toolchain/arm-gnu-toolchain.mk
@@ -6,7 +6,7 @@
 
 ARM_GNU_TOOLCHAIN_VERSION = 13.2.rel1
 ARM_GNU_TOOLCHAIN_SITE = https://developer.arm.com/-/media/Files/downloads/gnu/$(ARM_GNU_TOOLCHAIN_VERSION)/binrel
-ARM_GNU_TOOLCHAIN_SOURCE = arm-gnu-toolchain-$(ARM_GNU_TOOLCHAIN_VERSION)-x86_64-arm-none-eabi.tar.xz
+ARM_GNU_TOOLCHAIN_SOURCE = arm-gnu-toolchain-$(ARM_GNU_TOOLCHAIN_VERSION)-$(HOSTARCH)-arm-none-eabi.tar.xz
 ARM_GNU_TOOLCHAIN_LICENSE = GPL-3.0+
 
 HOST_ARM_GNU_TOOLCHAIN_INSTALL_DIR = $(HOST_DIR)/opt/gcc-arm-none-eabi
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/arm-gnu-toolchain: Add $(HOSTARCH) so can be built with aarch64

[Thomas Petazzoni via buildroot]

On Tue, 22 Oct 2024 15:03:34 -0600
Bryce Johnson <bryce@redpinelabs.com> wrote:

> Was testing building with arm64 build server and failed because it
> was downloading the x86_64 version.
> 
> Use $(HOSTARCH) instead so it can also downloaded
> 
> Tested with building configs/ti_am62x_sk_defconfig on arm64 that it
> uses to build the 32bit R5 MCU.
> 
> Signed-off-by: Bryce Johnson <bryce@redpinelabs.com>
> ---
>  package/arm-gnu-toolchain/arm-gnu-toolchain.hash | 2 ++
>  package/arm-gnu-toolchain/arm-gnu-toolchain.mk   | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)

Applied to master with an improved commit log. Though I believe making
this dependency more explicit would be useful, as suggested on my
review to your v1. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/arm-gnu-toolchain: Add $(HOSTARCH) so can be built with aarch64

[Bryce Johnson]

Hi Thomas,
I'm looking at that as well, but figured I would start with this
easier change to make sure I followed the contribution process
correctly.

Bryce

On Tue, Oct 22, 2024 at 3:17 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Tue, 22 Oct 2024 15:03:34 -0600
> Bryce Johnson <bryce@redpinelabs.com> wrote:
>
> > Was testing building with arm64 build server and failed because it
> > was downloading the x86_64 version.
> >
> > Use $(HOSTARCH) instead so it can also downloaded
> >
> > Tested with building configs/ti_am62x_sk_defconfig on arm64 that it
> > uses to build the 32bit R5 MCU.
> >
> > Signed-off-by: Bryce Johnson <bryce@redpinelabs.com>
> > ---
> >  package/arm-gnu-toolchain/arm-gnu-toolchain.hash | 2 ++
> >  package/arm-gnu-toolchain/arm-gnu-toolchain.mk   | 2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
>
> Applied to master with an improved commit log. Though I believe making
> this dependency more explicit would be useful, as suggested on my
> review to your v1. Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/arm-gnu-toolchain: Add $(HOSTARCH) so can be built with aarch64

[Thomas Petazzoni via buildroot]

Hello Bryce,

On Tue, 22 Oct 2024 15:37:51 -0600
Bryce Johnson <bryce@redpinelabs.com> wrote:

> I'm looking at that as well, but figured I would start with this
> easier change to make sure I followed the contribution process
> correctly.

Sure, makes sense! I see you've posted a series, I'll have a look!

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot