[Buildroot] [PATCH 1/1] support/scripts/pkg-stats: add unsure_cves to cve_total calculation

[Buildroot] [PATCH 1/1] support/scripts/pkg-stats: add unsure_cves to cve_total calculation

[Sen Hastings]

When I initially made the CVE cells collapsible, I neglected to
count the unsure CVEs. This patch adds unsure CVEs to the cell collapsing
calcualation to ensure that cells with lots of unsure CVEs actually get collapsed.

This patch also removes the "+ 1" from the cve_total calculation,
which fixes the cve_total being off-by-one.
I'm not sure *why* I did that in the first place.

demo:
https://sen-h.codeberg.page/pkg-stats-demos/@pages/add-unsure_cves-to-cve_total-calc.html


Signed-off-by: Sen Hastings <sen@hastings.org>
---
 support/scripts/pkg-stats | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
index f143af6446..33c21e77b4 100755
--- a/support/scripts/pkg-stats
+++ b/support/scripts/pkg-stats
@@ -1043,7 +1043,8 @@ def dump_html_pkg(f, pkg):
     data_field_id = f'cves__{pkg_css_class}'
     div_class = ["centered cves data"]
     div_class.append(f'_{pkg_css_class}')
-    if len(pkg.cves) > 10:
+    cve_total = len(pkg.cves) + len(pkg.unsure_cves)
+    if cve_total > 10:
         div_class.append("collapse")
     if pkg.is_status_ok("cve"):
         div_class.append("cve-ok")
@@ -1054,8 +1055,7 @@ def dump_html_pkg(f, pkg):
     else:
         div_class.append("cve-unknown")
     f.write(f'  <div id="{data_field_id}" class="{" ".join(div_class)}">\n')
-    if len(pkg.cves) > 10:
-        cve_total = len(pkg.cves) + 1
+    if cve_total > 10:
         f.write(f' <div onclick="expandField(\'{data_field_id}\')" \
         class="see-more centered cve_ignored">see all ({cve_total}) &#9662;</div>\n')
     if pkg.is_status_error("cve"):
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/scripts/pkg-stats: add unsure_cves to cve_total calculation

[Thomas Petazzoni via buildroot]

On Wed, 23 Oct 2024 02:52:52 -0700
Sen Hastings <sen@hastings.org> wrote:

> When I initially made the CVE cells collapsible, I neglected to
> count the unsure CVEs. This patch adds unsure CVEs to the cell collapsing
> calcualation to ensure that cells with lots of unsure CVEs actually get collapsed.
> 
> This patch also removes the "+ 1" from the cve_total calculation,
> which fixes the cve_total being off-by-one.
> I'm not sure *why* I did that in the first place.
> 
> demo:
> https://sen-h.codeberg.page/pkg-stats-demos/@pages/add-unsure_cves-to-cve_total-calc.html
> 
> 
> Signed-off-by: Sen Hastings <sen@hastings.org>
> ---
>  support/scripts/pkg-stats | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] support/scripts/pkg-stats: add unsure_cves to cve_total calculation

[Peter Korsgaard]

On 10/23/24 11:52, Sen Hastings wrote:
> When I initially made the CVE cells collapsible, I neglected to
> count the unsure CVEs. This patch adds unsure CVEs to the cell collapsing
> calcualation to ensure that cells with lots of unsure CVEs actually get collapsed.
> 
> This patch also removes the "+ 1" from the cve_total calculation,
> which fixes the cve_total being off-by-one.
> I'm not sure *why* I did that in the first place.
> 
> demo:
> https://sen-h.codeberg.page/pkg-stats-demos/@pages/add-unsure_cves-to-cve_total-calc.html
> 
> 
> Signed-off-by: Sen Hastings <sen@hastings.org>

Committed to 2024.02.x and 2024.08.x, thanks.

-- 
Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot